Message ID | 20181003143824.13059-1-ulf.hansson@linaro.org (mailing list archive) |
---|---|
Headers | show |
Series | PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM) (a subset) | expand |
On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > I have digested the review comments so far, including a recent offlist chat > with with Lorenzo Pieralisi around the debatable PSCI changes. More or less I > have a plan for how to move forward. > > However, to avoid re-posting non-changed patches over and over again, I decided > to withhold the more debatable part from this v9, hence this is not the complete > series to make things play. In v9, I have just included the trivial changes, > which are either already acked/reviewed or hopefully can be rather soon/easily. > > My hope is to get this queued for v4.20, to move things forward. I know it's > late, but there are more or less nothing new here since v8. I have no problems with the first three patches in this series, so I can apply them right away. Do you want me to do that? As for the rest, the cpuidle driver patch looks OK to me, but the PSCI-related ones need ACKs. Thanks, Rafael
On 4 October 2018 at 10:39, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: >> >> I have digested the review comments so far, including a recent offlist chat >> with with Lorenzo Pieralisi around the debatable PSCI changes. More or less I >> have a plan for how to move forward. >> >> However, to avoid re-posting non-changed patches over and over again, I decided >> to withhold the more debatable part from this v9, hence this is not the complete >> series to make things play. In v9, I have just included the trivial changes, >> which are either already acked/reviewed or hopefully can be rather soon/easily. >> >> My hope is to get this queued for v4.20, to move things forward. I know it's >> late, but there are more or less nothing new here since v8. > > I have no problems with the first three patches in this series, so I > can apply them right away. Do you want me to do that? Yes, please. > > As for the rest, the cpuidle driver patch looks OK to me, but the > PSCI-related ones need ACKs. For some yes, but I think you can go ahead with a few more. Patch 4, 5 is already acked/reviewed. Patch 6 should be fine (if you are okay with it else wait for an ack from Daniel) Patch 7 and 8 should be fine. They were suggested by Mark. Patch 9 and 10 needs acks. Patch 11 has been acked, but depends on the other PSCI changes. Kind regards Uffe
On Thursday, October 4, 2018 10:58:53 AM CEST Ulf Hansson wrote: > On 4 October 2018 at 10:39, Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > >> > >> I have digested the review comments so far, including a recent offlist chat > >> with with Lorenzo Pieralisi around the debatable PSCI changes. More or less I > >> have a plan for how to move forward. > >> > >> However, to avoid re-posting non-changed patches over and over again, I decided > >> to withhold the more debatable part from this v9, hence this is not the complete > >> series to make things play. In v9, I have just included the trivial changes, > >> which are either already acked/reviewed or hopefully can be rather soon/easily. > >> > >> My hope is to get this queued for v4.20, to move things forward. I know it's > >> late, but there are more or less nothing new here since v8. > > > > I have no problems with the first three patches in this series, so I > > can apply them right away. Do you want me to do that? > > Yes, please. > > > > > As for the rest, the cpuidle driver patch looks OK to me, but the > > PSCI-related ones need ACKs. > > For some yes, but I think you can go ahead with a few more. > > Patch 4, 5 is already acked/reviewed. > > Patch 6 should be fine (if you are okay with it else wait for an ack > from Daniel) OK, thanks. Do the 4-6 depend on the 1-3? > Patch 7 and 8 should be fine. They were suggested by Mark. I'd rather have ACKs on these two as well. > Patch 9 and 10 needs acks. > > Patch 11 has been acked, but depends on the other PSCI changes. OK
On Thu, Oct 4, 2018 at 11:04 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > On Thursday, October 4, 2018 10:58:53 AM CEST Ulf Hansson wrote: > > On 4 October 2018 at 10:39, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > >> > > >> I have digested the review comments so far, including a recent offlist chat > > >> with with Lorenzo Pieralisi around the debatable PSCI changes. More or less I > > >> have a plan for how to move forward. > > >> > > >> However, to avoid re-posting non-changed patches over and over again, I decided > > >> to withhold the more debatable part from this v9, hence this is not the complete > > >> series to make things play. In v9, I have just included the trivial changes, > > >> which are either already acked/reviewed or hopefully can be rather soon/easily. > > >> > > >> My hope is to get this queued for v4.20, to move things forward. I know it's > > >> late, but there are more or less nothing new here since v8. > > > > > > I have no problems with the first three patches in this series, so I > > > can apply them right away. Do you want me to do that? > > > > Yes, please. > > > > > > > > As for the rest, the cpuidle driver patch looks OK to me, but the > > > PSCI-related ones need ACKs. > > > > For some yes, but I think you can go ahead with a few more. > > > > Patch 4, 5 is already acked/reviewed. > > > > Patch 6 should be fine (if you are okay with it else wait for an ack > > from Daniel) > > OK, thanks. > > Do the 4-6 depend on the 1-3? I don't see any dependency there, so I'll queue up the 1-3 in pm-domains and the 4-6 in pm-cpuidle. Thanks, Rafael
On 4 October 2018 at 11:32, Rafael J. Wysocki <rafael@kernel.org> wrote: > On Thu, Oct 4, 2018 at 11:04 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: >> >> On Thursday, October 4, 2018 10:58:53 AM CEST Ulf Hansson wrote: >> > On 4 October 2018 at 10:39, Rafael J. Wysocki <rafael@kernel.org> wrote: >> > > On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: >> > >> >> > >> I have digested the review comments so far, including a recent offlist chat >> > >> with with Lorenzo Pieralisi around the debatable PSCI changes. More or less I >> > >> have a plan for how to move forward. >> > >> >> > >> However, to avoid re-posting non-changed patches over and over again, I decided >> > >> to withhold the more debatable part from this v9, hence this is not the complete >> > >> series to make things play. In v9, I have just included the trivial changes, >> > >> which are either already acked/reviewed or hopefully can be rather soon/easily. >> > >> >> > >> My hope is to get this queued for v4.20, to move things forward. I know it's >> > >> late, but there are more or less nothing new here since v8. >> > > >> > > I have no problems with the first three patches in this series, so I >> > > can apply them right away. Do you want me to do that? >> > >> > Yes, please. >> > >> > > >> > > As for the rest, the cpuidle driver patch looks OK to me, but the >> > > PSCI-related ones need ACKs. >> > >> > For some yes, but I think you can go ahead with a few more. >> > >> > Patch 4, 5 is already acked/reviewed. >> > >> > Patch 6 should be fine (if you are okay with it else wait for an ack >> > from Daniel) >> >> OK, thanks. >> >> Do the 4-6 depend on the 1-3? > > I don't see any dependency there, so I'll queue up the 1-3 in > pm-domains and the 4-6 in pm-cpuidle. Great, thanks! Make sure you put the remaining of the PSCI changes on pm-cpuidle (once acked), as there are dependency. Kind regards Uffe
On Thu, Oct 04, 2018 at 11:32:41AM +0200, Rafael J. Wysocki wrote: > On Thu, Oct 4, 2018 at 11:04 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > > > On Thursday, October 4, 2018 10:58:53 AM CEST Ulf Hansson wrote: > > > On 4 October 2018 at 10:39, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > >> > > > >> I have digested the review comments so far, including a recent offlist chat > > > >> with with Lorenzo Pieralisi around the debatable PSCI changes. More or less I > > > >> have a plan for how to move forward. > > > >> > > > >> However, to avoid re-posting non-changed patches over and over again, I decided > > > >> to withhold the more debatable part from this v9, hence this is not the complete > > > >> series to make things play. In v9, I have just included the trivial changes, > > > >> which are either already acked/reviewed or hopefully can be rather soon/easily. > > > >> > > > >> My hope is to get this queued for v4.20, to move things forward. I know it's > > > >> late, but there are more or less nothing new here since v8. > > > > > > > > I have no problems with the first three patches in this series, so I > > > > can apply them right away. Do you want me to do that? > > > > > > Yes, please. > > > > > > > > > > > As for the rest, the cpuidle driver patch looks OK to me, but the > > > > PSCI-related ones need ACKs. > > > > > > For some yes, but I think you can go ahead with a few more. > > > > > > Patch 4, 5 is already acked/reviewed. > > > > > > Patch 6 should be fine (if you are okay with it else wait for an ack > > > from Daniel) > > > > OK, thanks. > > > > Do the 4-6 depend on the 1-3? > > I don't see any dependency there, so I'll queue up the 1-3 in > pm-domains and the 4-6 in pm-cpuidle. I do not see why we should merge patches 4-6 for v4.20; they add legacy (DT bindings and related parsing code) with no user in the kernel; we may still want to tweak them, in particular PSCI DT bindings. Likewise, it makes no sense to merge patches 7-8 without the rest of the PSCI patches. Why do not we target v4.20-rc1 for the whole series re-posting and we take it from there given that we are at -rc6 tail end ? Thanks, Lorenzo
On Thu, Oct 4, 2018 at 5:58 PM Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Thu, Oct 04, 2018 at 11:32:41AM +0200, Rafael J. Wysocki wrote: > > On Thu, Oct 4, 2018 at 11:04 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote: > > > > > > On Thursday, October 4, 2018 10:58:53 AM CEST Ulf Hansson wrote: > > > > On 4 October 2018 at 10:39, Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > > On Wed, Oct 3, 2018 at 4:39 PM Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > >> > > > > >> I have digested the review comments so far, including a recent offlist chat > > > > >> with with Lorenzo Pieralisi around the debatable PSCI changes. More or less I > > > > >> have a plan for how to move forward. > > > > >> > > > > >> However, to avoid re-posting non-changed patches over and over again, I decided > > > > >> to withhold the more debatable part from this v9, hence this is not the complete > > > > >> series to make things play. In v9, I have just included the trivial changes, > > > > >> which are either already acked/reviewed or hopefully can be rather soon/easily. > > > > >> > > > > >> My hope is to get this queued for v4.20, to move things forward. I know it's > > > > >> late, but there are more or less nothing new here since v8. > > > > > > > > > > I have no problems with the first three patches in this series, so I > > > > > can apply them right away. Do you want me to do that? > > > > > > > > Yes, please. > > > > > > > > > > > > > > As for the rest, the cpuidle driver patch looks OK to me, but the > > > > > PSCI-related ones need ACKs. > > > > > > > > For some yes, but I think you can go ahead with a few more. > > > > > > > > Patch 4, 5 is already acked/reviewed. > > > > > > > > Patch 6 should be fine (if you are okay with it else wait for an ack > > > > from Daniel) > > > > > > OK, thanks. > > > > > > Do the 4-6 depend on the 1-3? > > > > I don't see any dependency there, so I'll queue up the 1-3 in > > pm-domains and the 4-6 in pm-cpuidle. > > I do not see why we should merge patches 4-6 for v4.20; they add legacy > (DT bindings and related parsing code) with no user in the kernel; we > may still want to tweak them, in particular PSCI DT bindings. My impression was that 4-6 have been agreed on due to the ACKs they carry. I'll drop them if that's not the case. > Likewise, it makes no sense to merge patches 7-8 without the rest of > the PSCI patches. OK I'll let the ARM camp sort out the PSCI material then. Thanks, Rafael
On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: [...] > > > I don't see any dependency there, so I'll queue up the 1-3 in > > > pm-domains and the 4-6 in pm-cpuidle. > > > > I do not see why we should merge patches 4-6 for v4.20; they add legacy > > (DT bindings and related parsing code) with no user in the kernel; we > > may still want to tweak them, in particular PSCI DT bindings. > > My impression was that 4-6 have been agreed on due to the ACKs they > carry. I'll drop them if that's not the case. I have not expressed myself correctly: they have been agreed (even though as I said they may require some tweaking) but I see no urgency of merging them in v4.20 since they have no user. They contain DT bindings, that create ABI/legacy, I think it is better to have code that uses them in the kernel before merging them and creating a dependency that is not needed. > > Likewise, it makes no sense to merge patches 7-8 without the rest of > > the PSCI patches. > > OK > > I'll let the ARM camp sort out the PSCI material then. We will do. Thanks, Lorenzo
On 4 October 2018 at 19:21, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: > > [...] > >> > > I don't see any dependency there, so I'll queue up the 1-3 in >> > > pm-domains and the 4-6 in pm-cpuidle. >> > >> > I do not see why we should merge patches 4-6 for v4.20; they add legacy >> > (DT bindings and related parsing code) with no user in the kernel; we >> > may still want to tweak them, in particular PSCI DT bindings. >> >> My impression was that 4-6 have been agreed on due to the ACKs they >> carry. I'll drop them if that's not the case. > > I have not expressed myself correctly: they have been agreed (even > though as I said they may require some tweaking) but I see no urgency > of merging them in v4.20 since they have no user. They contain DT > bindings, that create ABI/legacy, I think it is better to have code > that uses them in the kernel before merging them and creating a > dependency that is not needed. There is already code using the new bindings, for the idle states. Please have look at patch 5, 6 and 11. Moreover, you have had plenty on time to look at the series, as those patches haven't changed since a very long time. May I suggest you do the review instead, so we can move things forward, please. The changes in the v9 series should be trivial to review. > >> > Likewise, it makes no sense to merge patches 7-8 without the rest of >> > the PSCI patches. Well, those patches are part of this series, because Mark wanted me to move the files. Is really such a big deal? I think it makes sense, no matter what happens afterwards. [...] Kind regards Uffe
On 4 October 2018 at 20:36, Ulf Hansson <ulf.hansson@linaro.org> wrote: > On 4 October 2018 at 19:21, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: >> On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: >> >> [...] >> >>> > > I don't see any dependency there, so I'll queue up the 1-3 in >>> > > pm-domains and the 4-6 in pm-cpuidle. >>> > >>> > I do not see why we should merge patches 4-6 for v4.20; they add legacy >>> > (DT bindings and related parsing code) with no user in the kernel; we >>> > may still want to tweak them, in particular PSCI DT bindings. >>> >>> My impression was that 4-6 have been agreed on due to the ACKs they >>> carry. I'll drop them if that's not the case. >> >> I have not expressed myself correctly: they have been agreed (even >> though as I said they may require some tweaking) but I see no urgency >> of merging them in v4.20 since they have no user. They contain DT >> bindings, that create ABI/legacy, I think it is better to have code >> that uses them in the kernel before merging them and creating a >> dependency that is not needed. > > There is already code using the new bindings, for the idle states. > Please have look at patch 5, 6 and 11. Should be 5, 6 and 10, sorry. > > Moreover, you have had plenty on time to look at the series, as those > patches haven't changed since a very long time. > > May I suggest you do the review instead, so we can move things > forward, please. The changes in the v9 series should be trivial to > review. > >> >>> > Likewise, it makes no sense to merge patches 7-8 without the rest of >>> > the PSCI patches. > > Well, those patches are part of this series, because Mark wanted me to > move the files. Is really such a big deal? I think it makes sense, no > matter what happens afterwards. > > [...] > > Kind regards > Uffe
On Thu, Oct 04, 2018 at 08:36:24PM +0200, Ulf Hansson wrote: > On 4 October 2018 at 19:21, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: > > > > [...] > > > >> > > I don't see any dependency there, so I'll queue up the 1-3 in > >> > > pm-domains and the 4-6 in pm-cpuidle. > >> > > >> > I do not see why we should merge patches 4-6 for v4.20; they add legacy > >> > (DT bindings and related parsing code) with no user in the kernel; we > >> > may still want to tweak them, in particular PSCI DT bindings. > >> > >> My impression was that 4-6 have been agreed on due to the ACKs they > >> carry. I'll drop them if that's not the case. > > > > I have not expressed myself correctly: they have been agreed (even > > though as I said they may require some tweaking) but I see no urgency > > of merging them in v4.20 since they have no user. They contain DT > > bindings, that create ABI/legacy, I think it is better to have code > > that uses them in the kernel before merging them and creating a > > dependency that is not needed. > > There is already code using the new bindings, for the idle states. > Please have look at patch 5, 6 and 11. I had a look before replying and I reiterate the point, there is no reason to merge those patches without the rest of the series, none. There is already a way to describe idle states in the kernel and it works very well, we will add one when we need it not before. > Moreover, you have had plenty on time to look at the series, as those > patches haven't changed since a very long time. So ? > May I suggest you do the review instead, so we can move things > forward, please. The changes in the v9 series should be trivial to > review. There is no reason to merge patches [4, 5, 6, 10] stand-alone, they are not solving any problem and they do not provide any benefit other than adding useless ABI/legacy, they make sense when we look at the whole series. > >> > Likewise, it makes no sense to merge patches 7-8 without the rest of > >> > the PSCI patches. > > Well, those patches are part of this series, because Mark wanted me to > move the files. Is really such a big deal? I think it makes sense, no > matter what happens afterwards. We can merge patches [7-8] even if there is no urgency at all to do so, usually PSCI patches go via arm-soc whose patches queue is now closed and I do not think that's a problem at all. Lorenzo
On 5 October 2018 at 12:47, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > On Thu, Oct 04, 2018 at 08:36:24PM +0200, Ulf Hansson wrote: >> On 4 October 2018 at 19:21, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: >> > On Thu, Oct 04, 2018 at 07:07:27PM +0200, Rafael J. Wysocki wrote: >> > >> > [...] >> > >> >> > > I don't see any dependency there, so I'll queue up the 1-3 in >> >> > > pm-domains and the 4-6 in pm-cpuidle. >> >> > >> >> > I do not see why we should merge patches 4-6 for v4.20; they add legacy >> >> > (DT bindings and related parsing code) with no user in the kernel; we >> >> > may still want to tweak them, in particular PSCI DT bindings. >> >> >> >> My impression was that 4-6 have been agreed on due to the ACKs they >> >> carry. I'll drop them if that's not the case. >> > >> > I have not expressed myself correctly: they have been agreed (even >> > though as I said they may require some tweaking) but I see no urgency >> > of merging them in v4.20 since they have no user. They contain DT >> > bindings, that create ABI/legacy, I think it is better to have code >> > that uses them in the kernel before merging them and creating a >> > dependency that is not needed. >> >> There is already code using the new bindings, for the idle states. >> Please have look at patch 5, 6 and 11. > > I had a look before replying and I reiterate the point, there is > no reason to merge those patches without the rest of the series, > none. There is already a way to describe idle states in the kernel > and it works very well, we will add one when we need it not before. Okay, let's defer them. > >> Moreover, you have had plenty on time to look at the series, as those >> patches haven't changed since a very long time. > > So ? > >> May I suggest you do the review instead, so we can move things >> forward, please. The changes in the v9 series should be trivial to >> review. > > There is no reason to merge patches [4, 5, 6, 10] stand-alone, they > are not solving any problem and they do not provide any benefit > other than adding useless ABI/legacy, they make sense when we look > at the whole series. Okay, let's defer them. > >> >> > Likewise, it makes no sense to merge patches 7-8 without the rest of >> >> > the PSCI patches. >> >> Well, those patches are part of this series, because Mark wanted me to >> move the files. Is really such a big deal? I think it makes sense, no >> matter what happens afterwards. > > We can merge patches [7-8] even if there is no urgency at all to do so, > usually PSCI patches go via arm-soc whose patches queue is now closed > and I do not think that's a problem at all. Okay, let's defer them. That said, can please review the patches? Kind regards Uffe