| Message ID | 20181004161852.11673-1-crosa@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Trivial fixes and clean ups | expand |
On 10/4/18 11:18 AM, Cleber Rosa wrote: > Commit 990dc39c made all tests executable at the time, but 218 came in > later, and missing those permissions. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/qemu-iotests/218 | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tests/qemu-iotests/218 > > diff --git a/tests/qemu-iotests/218 b/tests/qemu-iotests/218 > old mode 100644 > new mode 100755 Reviewed-by: Eric Blake <eblake@redhat.com>
On 04/10/2018 18:18, Cleber Rosa wrote: > Commit 990dc39c made all tests executable at the time, but 218 came in > later, and missing those permissions. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/qemu-iotests/218 | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tests/qemu-iotests/218 > > diff --git a/tests/qemu-iotests/218 b/tests/qemu-iotests/218 > old mode 100644 > new mode 100755 We could add a git pre-commit hook grep'ing for "^#!\ *(/usr/bin/env|/bin/(b?a)?sh)" in the 1st line and then checking the file perms.
On 10/5/18 9:36 AM, Philippe Mathieu-Daudé wrote: > On 04/10/2018 18:18, Cleber Rosa wrote: >> Commit 990dc39c made all tests executable at the time, but 218 came in >> later, and missing those permissions. >> >> Signed-off-by: Cleber Rosa <crosa@redhat.com> >> --- >> tests/qemu-iotests/218 | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> mode change 100644 => 100755 tests/qemu-iotests/218 >> >> diff --git a/tests/qemu-iotests/218 b/tests/qemu-iotests/218 >> old mode 100644 >> new mode 100755 > > We could add a git pre-commit hook grep'ing for "^#!\ > *(/usr/bin/env|/bin/(b?a)?sh)" in the 1st line and then checking the > file perms. > Good idea. Probably better to send that as a different patch, right?
On 10/5/18 12:49 PM, Cleber Rosa wrote: >> >> We could add a git pre-commit hook grep'ing for "^#!\ >> *(/usr/bin/env|/bin/(b?a)?sh)" in the 1st line and then checking the >> file perms. >> > > Good idea. Probably better to send that as a different patch, right? Yes, separate patch. For that matter, "^#!/" is probably a sufficient pattern to catch any file that intends to be run via an interpreter, and therefore wants to be executable, rather than limiting to just env and specific shells.
On 10/5/18 1:02 PM, Eric Blake wrote: > On 10/5/18 12:49 PM, Cleber Rosa wrote: > >>> >>> We could add a git pre-commit hook grep'ing for "^#!\ >>> *(/usr/bin/env|/bin/(b?a)?sh)" in the 1st line and then checking the >>> file perms. >>> >> >> Good idea. Probably better to send that as a different patch, right? > > Yes, separate patch. For that matter, "^#!/" is probably a sufficient > pattern to catch any file that intends to be run via an interpreter, and > therefore wants to be executable, rather than limiting to just env and > specific shells. Also, many maintainers already have scripts/checkpatch.pl as a git pre-commit hook, and putting the check in checkpatch.pl means that patchew would also flag the issue.
On 04/10/2018 17:18, Cleber Rosa wrote: > Commit 990dc39c made all tests executable at the time, but 218 came in > later, and missing those permissions. > > Signed-off-by: Cleber Rosa <crosa@redhat.com> > --- > tests/qemu-iotests/218 | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tests/qemu-iotests/218 > > diff --git a/tests/qemu-iotests/218 b/tests/qemu-iotests/218 > old mode 100644 > new mode 100755 > Applied Thanks, Laurent
On Thu, Oct 04, 2018 at 12:18:42PM -0400, Cleber Rosa wrote: > Just a collection of trivial fixes and clean ups that have been lying > around here for some time. I'm queueing patches 07-10 on python-next. I'm aware that Laurent already queued some of them (thanks!), but I want to avoid conflicts in case other patches touching these modules are queued on python-next.