| Message ID | 20181002215055.8652-1-manasi.d.navare@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: Fix kernel doc for DRM_MODE_PROP_IMMUTABLE | expand |
On Tue, Oct 02, 2018 at 02:50:55PM -0700, Manasi Navare wrote: > This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better > by telling which function to call if kernel wants to update > drm object's immutable properties. > > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > include/drm/drm_property.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h > index 5b9efff35d6d..4a0a80d658c7 100644 > --- a/include/drm/drm_property.h > +++ b/include/drm/drm_property.h > @@ -153,7 +153,8 @@ struct drm_property { > * userspace. The kernel is allowed to update the value of these > * properties. This is generally used to expose probe state to > * userspace, e.g. the EDID, or the connector path property on DP > - * MST sinks. > + * MST sinks. Kernel can update the value of an immutable property > + * by calling drm_object_property_set_value(). > */ > uint32_t flags; > > -- > 2.18.0 >
Thanks for the review. Pushed to drm-misc. Manasi On Wed, Oct 03, 2018 at 09:32:49PM +0200, Daniel Vetter wrote: > On Tue, Oct 02, 2018 at 02:50:55PM -0700, Manasi Navare wrote: > > This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better > > by telling which function to call if kernel wants to update > > drm object's immutable properties. > > > > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > > --- > > include/drm/drm_property.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h > > index 5b9efff35d6d..4a0a80d658c7 100644 > > --- a/include/drm/drm_property.h > > +++ b/include/drm/drm_property.h > > @@ -153,7 +153,8 @@ struct drm_property { > > * userspace. The kernel is allowed to update the value of these > > * properties. This is generally used to expose probe state to > > * userspace, e.g. the EDID, or the connector path property on DP > > - * MST sinks. > > + * MST sinks. Kernel can update the value of an immutable property > > + * by calling drm_object_property_set_value(). > > */ > > uint32_t flags; > > > > -- > > 2.18.0 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch
diff --git a/include/drm/drm_property.h b/include/drm/drm_property.h index 5b9efff35d6d..4a0a80d658c7 100644 --- a/include/drm/drm_property.h +++ b/include/drm/drm_property.h @@ -153,7 +153,8 @@ struct drm_property { * userspace. The kernel is allowed to update the value of these * properties. This is generally used to expose probe state to * userspace, e.g. the EDID, or the connector path property on DP - * MST sinks. + * MST sinks. Kernel can update the value of an immutable property + * by calling drm_object_property_set_value(). */ uint32_t flags;
This patch explains the DRM_MODE_PROP_IMMUTABLE flag a bit better by telling which function to call if kernel wants to update drm object's immutable properties. Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> --- include/drm/drm_property.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)