mbox series

[PATCHv4,0/3] Deprecate DAC960 driver

Message ID 20181009152701.5542-1-hare@suse.de (mailing list archive)
Headers show
Series Deprecate DAC960 driver | expand

Message

Hannes Reinecke Oct. 9, 2018, 3:26 p.m. UTC 
Hi all,

as we're trying to get rid of the remaining request_fn drivers here's
a patchset to move the DAC960 driver to the SCSI stack.
As per request from hch I've split up the driver into two new SCSI
drivers called 'myrb' and 'myrs'.

The 'myrb' driver only supports the earlier (V1) firmware interface, which
doesn't have a SCSI interface for the logical drives; for those I've added
a (pretty rudimentary, admittedly) SCSI translation for them.

The 'myrs' driver supports the newer (V2) firmware interface, which is
SCSI based and doesn't need the translation layer.

And the weird proc interface from DAC960 has been converted to sysfs attributes.

Tested with eXtremeRAID 1100 (for V1 Firmware) and Mylex AcceleRAID 170
(for V2 Firmware).

Changes to v3:
- Rename structures to match the general codingstyle
- Replace typedefs

Changes to v2:
- Move to dma_pool API
- Fixup 0-day build issues
- Add myrb_biosparam
- Dropped patch merged with upstream

Changes to v1:
- Split into two drivers
- Improve scanning for V1 firmware interface

Hannes Reinecke (3):
  myrb: Add Mylex RAID controller (block interface)
  myrs: Add Mylex RAID controller (SCSI interface)
  drivers/block: Remove DAC960 driver

 Documentation/blockdev/README.DAC960 |  756 ----
 drivers/block/DAC960.c               | 7229 ----------------------------------
 drivers/block/DAC960.h               | 4414 ---------------------
 drivers/block/Kconfig                |   12 -
 drivers/block/Makefile               |    1 -
 drivers/scsi/Kconfig                 |   30 +
 drivers/scsi/Makefile                |    2 +
 drivers/scsi/myrb.c                  | 3829 ++++++++++++++++++
 drivers/scsi/myrb.h                  |  970 +++++
 drivers/scsi/myrs.c                  | 3423 ++++++++++++++++
 drivers/scsi/myrs.h                  | 1141 ++++++
 include/linux/pci_ids.h              |    2 +
 12 files changed, 9397 insertions(+), 12412 deletions(-)
 delete mode 100644 Documentation/blockdev/README.DAC960
 delete mode 100644 drivers/block/DAC960.c
 delete mode 100644 drivers/block/DAC960.h
 create mode 100644 drivers/scsi/myrb.c
 create mode 100644 drivers/scsi/myrb.h
 create mode 100644 drivers/scsi/myrs.c
 create mode 100644 drivers/scsi/myrs.h

Comments

Bart Van Assche Oct. 10, 2018, 2:03 a.m. UTC | #1 
On 10/9/18 8:26 AM, Hannes Reinecke wrote:
> as we're trying to get rid of the remaining request_fn drivers here's
> a patchset to move the DAC960 driver to the SCSI stack.
> As per request from hch I've split up the driver into two new SCSI
> drivers called 'myrb' and 'myrs'.

Hi Hannes,

It seems like only patches 1/3 and 2/3 but not 3/3 made it to the list?
See e.g. https://marc.info/?a=105878808800002&r=1.

Thanks,

Bart.
Hannes Reinecke Oct. 10, 2018, 5:49 a.m. UTC | #2 
On 10/10/18 4:03 AM, Bart Van Assche wrote:
> On 10/9/18 8:26 AM, Hannes Reinecke wrote:
>> as we're trying to get rid of the remaining request_fn drivers here's
>> a patchset to move the DAC960 driver to the SCSI stack.
>> As per request from hch I've split up the driver into two new SCSI
>> drivers called 'myrb' and 'myrs'.
> 
> Hi Hannes,
> 
> It seems like only patches 1/3 and 2/3 but not 3/3 made it to the list?
> See e.g. https://marc.info/?a=105878808800002&r=1.
> 
Hmm.

I have them in my inbox, and all patches have the same recipients.
Care to re-check?

Cheers,

Hannes
Christoph Hellwig Oct. 10, 2018, 5:56 a.m. UTC | #3 
On Wed, Oct 10, 2018 at 07:49:03AM +0200, Hannes Reinecke wrote:
> On 10/10/18 4:03 AM, Bart Van Assche wrote:
>> On 10/9/18 8:26 AM, Hannes Reinecke wrote:
>>> as we're trying to get rid of the remaining request_fn drivers here's
>>> a patchset to move the DAC960 driver to the SCSI stack.
>>> As per request from hch I've split up the driver into two new SCSI
>>> drivers called 'myrb' and 'myrs'.
>>
>> Hi Hannes,
>>
>> It seems like only patches 1/3 and 2/3 but not 3/3 made it to the list?
>> See e.g. https://marc.info/?a=105878808800002&r=1.
>>
> Hmm.
>
> I have them in my inbox, and all patches have the same recipients.
> Care to re-check?

I got them all, but 1 had a major, major delay in my inbox.

In my linux-scsi box 3/3 is missing.
Bart Van Assche Oct. 10, 2018, 1:52 p.m. UTC | #4 
On 10/9/18 10:49 PM, Hannes Reinecke wrote:
> On 10/10/18 4:03 AM, Bart Van Assche wrote:
>> On 10/9/18 8:26 AM, Hannes Reinecke wrote:
>>> as we're trying to get rid of the remaining request_fn drivers here's
>>> a patchset to move the DAC960 driver to the SCSI stack.
>>> As per request from hch I've split up the driver into two new SCSI
>>> drivers called 'myrb' and 'myrs'.
>>
>> Hi Hannes,
>>
>> It seems like only patches 1/3 and 2/3 but not 3/3 made it to the list?
>> See e.g. https://marc.info/?a=105878808800002&r=1.
>>
> Hmm.
> 
> I have them in my inbox, and all patches have the same recipients.
> Care to re-check?

Hi Hannes,

If you have a look at the URL in my previous e-mail you will see that 
patch 3/3 didn't make it to marc.info either.

Thanks,

Bart.
Martin K. Petersen Oct. 11, 2018, 2:51 a.m. UTC | #5 
Bart,

> If you have a look at the URL in my previous e-mail you will see that
> patch 3/3 didn't make it to marc.info either.

Also missing in patchwork (although I received my personal copy).

Hannes, please resend.