| Message ID | 20181010170936.316862-2-lkundrak@v3.sk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | spi: pxa2xx: add DT and slave mode support | expand |
On Wed, Oct 10, 2018 at 07:09:26PM +0200, Lubomir Rintel wrote: > This is the SPI controller found on Marvel MMP2 and perhaps more > platforms. *Way* more. Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches.
On Thu, 2018-10-11 at 15:27 +0100, Mark Brown wrote: > On Wed, Oct 10, 2018 at 07:09:26PM +0200, Lubomir Rintel wrote: > > This is the SPI controller found on Marvel MMP2 and perhaps more > > platforms. > > *Way* more. > > Please use subject lines matching the style for the subsystem. This > makes it easier for people to identify relevant patches. Thanks for the response. I'm a little confused here. Why I chose this subject line is because I did this: git log --no-merges Documentation/devicetree/bindings/ to figure out what's the typical subject for the DT binding changes. I also believed that's the right way to get Rob Herring's and Mark Rutland's attention. Do the device tree binding documentation typically go in with the associated drivers, or via their tree ("OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" in MAINTIANERS)? Lubo
On Thu, Oct 11, 2018 at 07:59:15PM +0200, Lubomir Rintel wrote: > On Thu, 2018-10-11 at 15:27 +0100, Mark Brown wrote: > > Please use subject lines matching the style for the subsystem. This > > makes it easier for people to identify relevant patches. > Thanks for the response. > I'm a little confused here. Why I chose this subject line is because I > did this: > git log --no-merges Documentation/devicetree/bindings/ Try Documentation/devicetree/bindings/spi instead :) > to figure out what's the typical subject for the DT binding changes. > I also believed that's the right way to get Rob Herring's and Mark > Rutland's attention. Do the device tree binding documentation typically There *is* some debate for the DT bindings unfortunately. > go in with the associated drivers, or via their tree ("OPEN FIRMWARE > AND FLATTENED DEVICE TREE BINDINGS" in MAINTIANERS)? They usually go in with the drivers. This one isn't so bad since it does mention SPI, it's a worse problem when that's not present at all.
On Fri, Oct 12, 2018 at 07:00:02PM +0200, Mark Brown wrote: > On Thu, Oct 11, 2018 at 07:59:15PM +0200, Lubomir Rintel wrote: > > On Thu, 2018-10-11 at 15:27 +0100, Mark Brown wrote: > > > > Please use subject lines matching the style for the subsystem. This > > > makes it easier for people to identify relevant patches. > > > Thanks for the response. > > > I'm a little confused here. Why I chose this subject line is because I > > did this: > > > git log --no-merges Documentation/devicetree/bindings/ > > Try Documentation/devicetree/bindings/spi instead :) Just so you know, pretty much everything else except SPI, regulators, and ASoC follows 'dt-bindings: <binding dir>:' these days. I don't really care so much about the difference, but it is tribal knowledge that submitters have to learn. Really, this could all be solved with tooling using MAINTAINERS and get_maintainers.pl, but limping around in checkpatch.pl occasionally is enough perl for me. > > to figure out what's the typical subject for the DT binding changes. > > > I also believed that's the right way to get Rob Herring's and Mark > > Rutland's attention. All that matters is CC'ing the DT list really. And Mark R is pretty much AWOL. Reviewing bindings in front of your own will get yours reviewed faster. :) > Do the device tree binding documentation typically > > There *is* some debate for the DT bindings unfortunately. > > > go in with the associated drivers, or via their tree ("OPEN FIRMWARE > > AND FLATTENED DEVICE TREE BINDINGS" in MAINTIANERS)? > > They usually go in with the drivers. This one isn't so bad since it > does mention SPI, it's a worse problem when that's not present at all. Right. I generally only take single patches not in a series with dts or driver changes and when/if the subsystem maintainer doesn't pick them up. Or any standalone fixes I'll take. Rob
On Wed 2018-10-10 19:09:26, Lubomir Rintel wrote: > This is the SPI controller found on Marvel MMP2 and perhaps more > platforms. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk> Acked-by: Pavel Machek <pavel@ucw.cz> Rob, do you want to apply this? Pavel > @@ -0,0 +1,24 @@ > +PXA2xx SSP SPI Controller > + > +Required properties: > +- compatible: Must be "marvell,mmp2-ssp". > +- reg: Offset and length of the device's register set. > +- interrupts: Should be the interrupt number. > +- clocks: Should contain a single entry describing the clock input. > +- #address-cells: Number of cells required to define a chip select address. > +- #size-cells: Should be zero. > + > +Optional properties: > +- cs-gpios: list of GPIO chip selects. See the SPI bus bindings, > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Child nodes represent devices on the SPI bus > + See ../spi/spi-bus.txt > + > +Example: > + ssp1: spi@d4035000 { > + compatible = "marvell,mmp2-ssp"; > + reg = <0xd4035000 0x1000>; > + clocks = <&soc_clocks MMP2_CLK_SSP0>; > + interrupts = <0>; > + };
diff --git a/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt new file mode 100644 index 000000000000..0335a9bd2e8a --- /dev/null +++ b/Documentation/devicetree/bindings/spi/spi-pxa2xx.txt @@ -0,0 +1,24 @@ +PXA2xx SSP SPI Controller + +Required properties: +- compatible: Must be "marvell,mmp2-ssp". +- reg: Offset and length of the device's register set. +- interrupts: Should be the interrupt number. +- clocks: Should contain a single entry describing the clock input. +- #address-cells: Number of cells required to define a chip select address. +- #size-cells: Should be zero. + +Optional properties: +- cs-gpios: list of GPIO chip selects. See the SPI bus bindings, + Documentation/devicetree/bindings/spi/spi-bus.txt + +Child nodes represent devices on the SPI bus + See ../spi/spi-bus.txt + +Example: + ssp1: spi@d4035000 { + compatible = "marvell,mmp2-ssp"; + reg = <0xd4035000 0x1000>; + clocks = <&soc_clocks MMP2_CLK_SSP0>; + interrupts = <0>; + };