| Message ID | 20181011094930.17010-2-vivek.gautam@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Andy Gross |
| Headers | show |
| Series | Enable smmu support on sdm845 | expand |
On Thu, 11 Oct 2018 15:19:29 +0530, Vivek Gautam wrote: > Qcom's implementation of arm,mmu-500 works well with current > arm-smmu driver implementation. Adding a soc specific compatible > along with arm,mmu-500 makes the bindings future safe. > > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > --- > > Changes since v3: > - Refined language more to state things directly for the bindings > description. > > Documentation/devicetree/bindings/iommu/arm,smmu.txt | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On 10/12/2018 3:46 AM, Rob Herring wrote: > On Thu, 11 Oct 2018 15:19:29 +0530, Vivek Gautam wrote: >> Qcom's implementation of arm,mmu-500 works well with current >> arm-smmu driver implementation. Adding a soc specific compatible >> along with arm,mmu-500 makes the bindings future safe. >> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- >> >> Changes since v3: >> - Refined language more to state things directly for the bindings >> description. >> >> Documentation/devicetree/bindings/iommu/arm,smmu.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> > Reviewed-by: Rob Herring <robh@kernel.org> Thank you Rob. Best regards Vivek
Hi Will, On Fri, Oct 12, 2018 at 11:37 AM Vivek Gautam <vivek.gautam@codeaurora.org> wrote: > > > > On 10/12/2018 3:46 AM, Rob Herring wrote: > > On Thu, 11 Oct 2018 15:19:29 +0530, Vivek Gautam wrote: > >> Qcom's implementation of arm,mmu-500 works well with current > >> arm-smmu driver implementation. Adding a soc specific compatible > >> along with arm,mmu-500 makes the bindings future safe. > >> > >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > >> --- > >> > >> Changes since v3: > >> - Refined language more to state things directly for the bindings > >> description. > >> > >> Documentation/devicetree/bindings/iommu/arm,smmu.txt | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Thank you Rob. > Can you please pick this one as well to your tree? This goes on top of the bindings patch for "qcom,smmu-v2". So, it can't go through Andy's tree. Will ask Andy to pick the second patch of the series, that adds the dt node. I guess as I sent this one along with the dt patch, I would have mistakenly added you to 'cc' list rather than 'to' list. Let me know if you would like me to resend it. Thank Vivek
On Wed, Dec 12, 2018 at 03:18:06PM +0530, Vivek Gautam wrote: > On Fri, Oct 12, 2018 at 11:37 AM Vivek Gautam > <vivek.gautam@codeaurora.org> wrote: > > On 10/12/2018 3:46 AM, Rob Herring wrote: > > > On Thu, 11 Oct 2018 15:19:29 +0530, Vivek Gautam wrote: > > >> Qcom's implementation of arm,mmu-500 works well with current > > >> arm-smmu driver implementation. Adding a soc specific compatible > > >> along with arm,mmu-500 makes the bindings future safe. > > >> > > >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> > > >> --- > > >> > > >> Changes since v3: > > >> - Refined language more to state things directly for the bindings > > >> description. > > >> > > >> Documentation/devicetree/bindings/iommu/arm,smmu.txt | 4 ++++ > > >> 1 file changed, 4 insertions(+) > > >> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Thank you Rob. > > > > Can you please pick this one as well to your tree? This goes on top of the > bindings patch for "qcom,smmu-v2". So, it can't go through Andy's tree. > Will ask Andy to pick the second patch of the series, that adds the dt node. > > I guess as I sent this one along with the dt patch, I would have > mistakenly added > you to 'cc' list rather than 'to' list. > Let me know if you would like me to resend it. I've already sent my stuff to Joerg, so it's too late for 4.21. Perhaps resend this patch standalone to Joerg with me on CC so that I can ack it. Will
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.txt b/Documentation/devicetree/bindings/iommu/arm,smmu.txt index a6504b37cc21..3133f3ba7567 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.txt +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.txt @@ -27,6 +27,10 @@ conditions. "qcom,msm8996-smmu-v2", "qcom,smmu-v2", "qcom,sdm845-smmu-v2", "qcom,smmu-v2". + Qcom SoCs implementing "arm,mmu-500" must also include, + as below, SoC-specific compatibles: + "qcom,sdm845-smmu-500", "arm,mmu-500" + - reg : Base address and size of the SMMU. - #global-interrupts : The number of global interrupts exposed by the
Qcom's implementation of arm,mmu-500 works well with current arm-smmu driver implementation. Adding a soc specific compatible along with arm,mmu-500 makes the bindings future safe. Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> --- Changes since v3: - Refined language more to state things directly for the bindings description. Documentation/devicetree/bindings/iommu/arm,smmu.txt | 4 ++++ 1 file changed, 4 insertions(+)