| Message ID | 20181011161444.328-2-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | pwm: lpss: Check PWM powerstate after resume on Cherry Trail devices | expand |
On Thu, Oct 11, 2018 at 06:14:42PM +0200, Hans de Goede wrote: > Export acpi_device_get_power() for use by modular build drivers. > non-GPL export is used to be consistent with setter counterpart, right? Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Changes in v4: > -New patch in v4 of this patch-set > --- > drivers/acpi/device_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c > index a7c2673ffd36..824ae985ad93 100644 > --- a/drivers/acpi/device_pm.c > +++ b/drivers/acpi/device_pm.c > @@ -126,6 +126,7 @@ int acpi_device_get_power(struct acpi_device *device, int *state) > > return 0; > } > +EXPORT_SYMBOL(acpi_device_get_power); > > static int acpi_dev_pm_explicit_set(struct acpi_device *adev, int state) > { > -- > 2.19.0 >
On Thursday, October 11, 2018 6:14:42 PM CEST Hans de Goede wrote: > Export acpi_device_get_power() for use by modular build drivers. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > Changes in v4: > -New patch in v4 of this patch-set > --- > drivers/acpi/device_pm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c > index a7c2673ffd36..824ae985ad93 100644 > --- a/drivers/acpi/device_pm.c > +++ b/drivers/acpi/device_pm.c > @@ -126,6 +126,7 @@ int acpi_device_get_power(struct acpi_device *device, int *state) > > return 0; > } > +EXPORT_SYMBOL(acpi_device_get_power); > > static int acpi_dev_pm_explicit_set(struct acpi_device *adev, int state) > { > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Hi, On 11-10-18 22:37, Rafael J. Wysocki wrote: > On Thursday, October 11, 2018 6:14:42 PM CEST Hans de Goede wrote: >> Export acpi_device_get_power() for use by modular build drivers. >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> Changes in v4: >> -New patch in v4 of this patch-set >> --- >> drivers/acpi/device_pm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c >> index a7c2673ffd36..824ae985ad93 100644 >> --- a/drivers/acpi/device_pm.c >> +++ b/drivers/acpi/device_pm.c >> @@ -126,6 +126,7 @@ int acpi_device_get_power(struct acpi_device *device, int *state) >> >> return 0; >> } >> +EXPORT_SYMBOL(acpi_device_get_power); >> >> static int acpi_dev_pm_explicit_set(struct acpi_device *adev, int state) >> { >> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Does this mean that you are ok with taking this patch upstream through Thierry's PWM tree ? Thierry, do you want me to resend the latest version of all my outstanding PWM LPSS patches as a single series? Regards, Hans
Hi, On 11-10-18 19:14, Andy Shevchenko wrote: > On Thu, Oct 11, 2018 at 06:14:42PM +0200, Hans de Goede wrote: >> Export acpi_device_get_power() for use by modular build drivers. >> > > non-GPL export is used to be consistent with setter counterpart, right? Right. > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks. Regards, Hans > >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> Changes in v4: >> -New patch in v4 of this patch-set >> --- >> drivers/acpi/device_pm.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c >> index a7c2673ffd36..824ae985ad93 100644 >> --- a/drivers/acpi/device_pm.c >> +++ b/drivers/acpi/device_pm.c >> @@ -126,6 +126,7 @@ int acpi_device_get_power(struct acpi_device *device, int *state) >> >> return 0; >> } >> +EXPORT_SYMBOL(acpi_device_get_power); >> >> static int acpi_dev_pm_explicit_set(struct acpi_device *adev, int state) >> { >> -- >> 2.19.0 >> >
On Fri, Oct 12, 2018 at 11:29 AM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi, > > On 11-10-18 22:37, Rafael J. Wysocki wrote: > > On Thursday, October 11, 2018 6:14:42 PM CEST Hans de Goede wrote: > >> Export acpi_device_get_power() for use by modular build drivers. > >> > >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > >> --- > >> Changes in v4: > >> -New patch in v4 of this patch-set > >> --- > >> drivers/acpi/device_pm.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c > >> index a7c2673ffd36..824ae985ad93 100644 > >> --- a/drivers/acpi/device_pm.c > >> +++ b/drivers/acpi/device_pm.c > >> @@ -126,6 +126,7 @@ int acpi_device_get_power(struct acpi_device *device, int *state) > >> > >> return 0; > >> } > >> +EXPORT_SYMBOL(acpi_device_get_power); > >> > >> static int acpi_dev_pm_explicit_set(struct acpi_device *adev, int state) > >> { > >> > > > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Does this mean that you are ok with taking this patch > upstream through Thierry's PWM tree ? Yes, it does. Thanks, Rafael
diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c index a7c2673ffd36..824ae985ad93 100644 --- a/drivers/acpi/device_pm.c +++ b/drivers/acpi/device_pm.c @@ -126,6 +126,7 @@ int acpi_device_get_power(struct acpi_device *device, int *state) return 0; } +EXPORT_SYMBOL(acpi_device_get_power); static int acpi_dev_pm_explicit_set(struct acpi_device *adev, int state) {
Export acpi_device_get_power() for use by modular build drivers. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- Changes in v4: -New patch in v4 of this patch-set --- drivers/acpi/device_pm.c | 1 + 1 file changed, 1 insertion(+)