mbox series

[v2,0/4] misc patches for nvdimm security fixes

Message ID 153937659078.70378.7857051533055879370.stgit@djiang5-desk3.ch.intel.com (mailing list archive)
Headers show
Series misc patches for nvdimm security fixes | expand

Message

Dave Jiang Oct. 12, 2018, 8:39 p.m. UTC
v2:
- Fix key perm flags and remove SET_ATTR. (Dan)
- Fixup comment for key_update code block (Dan)
- Use key_destroy() instead of key_invalidate+key_put (Dan)
- Fix dev_warn() output for nvdimm_security_disable() (Dan)
- Drop patch 3/5 (applied by Dan)
- Add support for self verify the requested key before giving up and freeze
  security. (Dan)

---

Dave Jiang (4):
      libnvdimm: fix updating of kernel key during nvdimm key update
      libnvdimm: fix incorrect output when nvdimm disable failed
      libnvdimm: remove code to pull user key when there's no kernel key
      libnvdimm: address state where dimm is unlocked in preOS


 drivers/nvdimm/security.c |  129 +++++++++++++++++++++++++++++----------------
 1 file changed, 82 insertions(+), 47 deletions(-)

--

Comments

Dan Williams Oct. 12, 2018, 11:26 p.m. UTC | #1
On Fri, Oct 12, 2018 at 1:39 PM Dave Jiang <dave.jiang@intel.com> wrote:
>
> v2:
> - Fix key perm flags and remove SET_ATTR. (Dan)
> - Fixup comment for key_update code block (Dan)
> - Use key_destroy() instead of key_invalidate+key_put (Dan)
> - Fix dev_warn() output for nvdimm_security_disable() (Dan)
> - Drop patch 3/5 (applied by Dan)
> - Add support for self verify the requested key before giving up and freeze
>   security. (Dan)
>
> ---
>
> Dave Jiang (4):
>       libnvdimm: fix updating of kernel key during nvdimm key update
>       libnvdimm: fix incorrect output when nvdimm disable failed
>       libnvdimm: remove code to pull user key when there's no kernel key
>       libnvdimm: address state where dimm is unlocked in preOS
>

These look good to me, applied.