| Message ID | 20181007093905.11253-5-jernej.skrabec@siol.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allwinner H6 DE3 and HDMI support | expand |
On Sunday 07 October 2018 03:08 PM, Jernej Skrabec wrote: > Video PLL factors can be set in a way that final PLL rate is outside > stable range. H6 user manual specifically says that N factor should not > be below 12. While it doesn't says anything about maximum stable rate, it Manual says "In application, PLL_FACTOR_N should be more than or equal to 11" can't it be 11? > is clear that PLL doesn't work at 6.096 GHz (254 * 24 MHz). > > Set minimum allowed PLL video rate to 288 MHz (12 * 24 MHz) and maximum > to 2.4 GHz, which is maximum in BSP driver. Is this max freq from here [1] [1] https://github.com/Allwinner-Homlet/H6-BSP4.9-linux/blob/master/drivers/clk/sunxi/clk-sun50iw6.c#L164
On Fri, Oct 12, 2018 at 4:14 PM Jagan Teki <jagan@openedev.com> wrote: > > On Sunday 07 October 2018 03:08 PM, Jernej Skrabec wrote: > > Video PLL factors can be set in a way that final PLL rate is outside > > stable range. H6 user manual specifically says that N factor should not > > be below 12. While it doesn't says anything about maximum stable rate, it > > Manual says "In application, PLL_FACTOR_N should be more than or equal > to 11" can't it be 11? PLL_FACTOR_N is the raw value, which starts from 0. That translates to an actual factor of 12 used in the calculations. > > is clear that PLL doesn't work at 6.096 GHz (254 * 24 MHz). > > > > Set minimum allowed PLL video rate to 288 MHz (12 * 24 MHz) and maximum > > to 2.4 GHz, which is maximum in BSP driver. > > Is this max freq from here [1] > > [1] > https://github.com/Allwinner-Homlet/H6-BSP4.9-linux/blob/master/drivers/clk/sunxi/clk-sun50iw6.c#L164 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
diff --git a/drivers/clk/sunxi-ng/ccu-sun50i-h6.c b/drivers/clk/sunxi-ng/ccu-sun50i-h6.c index 2193e1495086..19ff09f610e4 100644 --- a/drivers/clk/sunxi-ng/ccu-sun50i-h6.c +++ b/drivers/clk/sunxi-ng/ccu-sun50i-h6.c @@ -120,6 +120,8 @@ static struct ccu_nm pll_video0_clk = { .n = _SUNXI_CCU_MULT_MIN(8, 8, 12), .m = _SUNXI_CCU_DIV(1, 1), /* input divider */ .fixed_post_div = 4, + .min_rate = 288000000, + .max_rate = 2400000000UL, .common = { .reg = 0x040, .features = CCU_FEATURE_FIXED_POSTDIV, @@ -136,6 +138,8 @@ static struct ccu_nm pll_video1_clk = { .n = _SUNXI_CCU_MULT_MIN(8, 8, 12), .m = _SUNXI_CCU_DIV(1, 1), /* input divider */ .fixed_post_div = 4, + .min_rate = 288000000, + .max_rate = 2400000000UL, .common = { .reg = 0x048, .features = CCU_FEATURE_FIXED_POSTDIV,
Video PLL factors can be set in a way that final PLL rate is outside stable range. H6 user manual specifically says that N factor should not be below 12. While it doesn't says anything about maximum stable rate, it is clear that PLL doesn't work at 6.096 GHz (254 * 24 MHz). Set minimum allowed PLL video rate to 288 MHz (12 * 24 MHz) and maximum to 2.4 GHz, which is maximum in BSP driver. Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> --- drivers/clk/sunxi-ng/ccu-sun50i-h6.c | 4 ++++ 1 file changed, 4 insertions(+)