mbox series

[v3,0/2] mmc: tmio: remove confusing TMIO_MMC_HAVE_HIGH_REG flag

Message ID 1539143492-32605-1-git-send-email-yamada.masahiro@socionext.com (mailing list archive)
Headers show
Series mmc: tmio: remove confusing TMIO_MMC_HAVE_HIGH_REG flag | expand

Message

Masahiro Yamada Oct. 10, 2018, 3:51 a.m. UTC 
CTL_SDIO_REGS is a register specific to tmio_mmc.c

Currently, we handle it in tmio_mmc_core.c, hence need
TMIO_MMC_HAVE_HIGH_REG flag to prevent the other platforms
from accessing to it.

We can just move CTL_SDIO_REGS to tmio_mmc.c
and delete the confusing TMIO_MMC_HAVE_HIGH_REG flag.


Masahiro Yamada (2):
  mmc: tmio: move MFD variant reset to a platform hook
  mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag

 drivers/mmc/host/tmio_mmc.c      | 24 ++++++++++++++++++++++--
 drivers/mmc/host/tmio_mmc.h      |  4 +---
 drivers/mmc/host/tmio_mmc_core.c | 14 ++++++--------
 include/linux/mfd/tmio.h         |  7 -------
 4 files changed, 29 insertions(+), 20 deletions(-)

Comments

Wolfram Sang Oct. 14, 2018, 10:30 p.m. UTC | #1 
On Wed, Oct 10, 2018 at 12:51:30PM +0900, Masahiro Yamada wrote:
> CTL_SDIO_REGS is a register specific to tmio_mmc.c
> 
> Currently, we handle it in tmio_mmc_core.c, hence need
> TMIO_MMC_HAVE_HIGH_REG flag to prevent the other platforms
> from accessing to it.
> 
> We can just move CTL_SDIO_REGS to tmio_mmc.c
> and delete the confusing TMIO_MMC_HAVE_HIGH_REG flag.

Looks good, thanks! Ulf, please give me Monday to test the changes on
some more devices...
Ulf Hansson Oct. 15, 2018, 1:15 p.m. UTC | #2 
On 10 October 2018 at 05:51, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> CTL_SDIO_REGS is a register specific to tmio_mmc.c
>
> Currently, we handle it in tmio_mmc_core.c, hence need
> TMIO_MMC_HAVE_HIGH_REG flag to prevent the other platforms
> from accessing to it.
>
> We can just move CTL_SDIO_REGS to tmio_mmc.c
> and delete the confusing TMIO_MMC_HAVE_HIGH_REG flag.
>
>
> Masahiro Yamada (2):
>   mmc: tmio: move MFD variant reset to a platform hook
>   mmc: tmio: remove TMIO_MMC_HAVE_HIGH_REG flag
>
>  drivers/mmc/host/tmio_mmc.c      | 24 ++++++++++++++++++++++--
>  drivers/mmc/host/tmio_mmc.h      |  4 +---
>  drivers/mmc/host/tmio_mmc_core.c | 14 ++++++--------
>  include/linux/mfd/tmio.h         |  7 -------
>  4 files changed, 29 insertions(+), 20 deletions(-)
>
> --
> 2.7.4
>

Applied for next, thanks!

Kind regards
Uffe