| Message ID | 943d4f75-f12b-6ff4-711c-27a3a17465e7@kernel.dk (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | IB/srp: remove old request_fn_active check | expand |
On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote: > This check is only viable for non scsi-mq. Since that is going away, > kill this legacy check. > > Cc: Bart Van Assche <bvanassche@acm.org> > Cc: Parav Pandit <parav@mellanox.com> > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Jens Axboe <axboe@kernel.dk> > --- > drivers/infiniband/ulp/srp/ib_srp.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c > index 0b34e909505f..5a79444c2f3c 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -1334,13 +1334,6 @@ static void srp_terminate_io(struct srp_rport *rport) > struct scsi_device *sdev; > int i, j; > > - /* > - * Invoking srp_terminate_io() while srp_queuecommand() is running > - * is not safe. Hence the warning statement below. > - */ > - shost_for_each_device(sdev, shost) > - WARN_ON_ONCE(sdev->request_queue->request_fn_active); > - > for (i = 0; i < target->ch_count; i++) { > ch = &target->ch[i]; How about adding Hannes' Signed-off-by? See also https://www.spinics.net/lists/linux-scsi/msg123488.html. Anyway: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On 10/16/18 8:55 AM, Bart Van Assche wrote: > On Tue, 2018-10-16 at 08:31 -0600, Jens Axboe wrote: >> This check is only viable for non scsi-mq. Since that is going away, >> kill this legacy check. >> >> Cc: Bart Van Assche <bvanassche@acm.org> >> Cc: Parav Pandit <parav@mellanox.com> >> Cc: linux-scsi@vger.kernel.org >> Signed-off-by: Jens Axboe <axboe@kernel.dk> >> --- >> drivers/infiniband/ulp/srp/ib_srp.c | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c >> index 0b34e909505f..5a79444c2f3c 100644 >> --- a/drivers/infiniband/ulp/srp/ib_srp.c >> +++ b/drivers/infiniband/ulp/srp/ib_srp.c >> @@ -1334,13 +1334,6 @@ static void srp_terminate_io(struct srp_rport *rport) >> struct scsi_device *sdev; >> int i, j; >> >> - /* >> - * Invoking srp_terminate_io() while srp_queuecommand() is running >> - * is not safe. Hence the warning statement below. >> - */ >> - shost_for_each_device(sdev, shost) >> - WARN_ON_ONCE(sdev->request_queue->request_fn_active); >> - >> for (i = 0; i < target->ch_count; i++) { >> ch = &target->ch[i]; > > How about adding Hannes' Signed-off-by? See also > https://www.spinics.net/lists/linux-scsi/msg123488.html. I had no idea this existed, I'll just replace with that one instead and your reviewed-by (and mine). Martin, is this queued up?
Jens, >> How about adding Hannes' Signed-off-by? See also >> https://www.spinics.net/lists/linux-scsi/msg123488.html. > > I had no idea this existed, I'll just replace with that one instead > and your reviewed-by (and mine). > Martin, is this queued up? Nope, I was waiting for Hannes to address the feedback from Bart and Johannes.
On 10/16/18 9:09 AM, Martin K. Petersen wrote: > > Jens, > >>> How about adding Hannes' Signed-off-by? See also >>> https://www.spinics.net/lists/linux-scsi/msg123488.html. >> >> I had no idea this existed, I'll just replace with that one instead >> and your reviewed-by (and mine). > >> Martin, is this queued up? > > Nope, I was waiting for Hannes to address the feedback from Bart and > Johannes. Hannes, please get this resent with Johannes comment addressed. Bart's comment should no longer be relevant. You can add his and mine reviewed-by, as per previous email.
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 0b34e909505f..5a79444c2f3c 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -1334,13 +1334,6 @@ static void srp_terminate_io(struct srp_rport *rport) struct scsi_device *sdev; int i, j; - /* - * Invoking srp_terminate_io() while srp_queuecommand() is running - * is not safe. Hence the warning statement below. - */ - shost_for_each_device(sdev, shost) - WARN_ON_ONCE(sdev->request_queue->request_fn_active); - for (i = 0; i < target->ch_count; i++) { ch = &target->ch[i];
This check is only viable for non scsi-mq. Since that is going away, kill this legacy check. Cc: Bart Van Assche <bvanassche@acm.org> Cc: Parav Pandit <parav@mellanox.com> Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe <axboe@kernel.dk> --- drivers/infiniband/ulp/srp/ib_srp.c | 7 ------- 1 file changed, 7 deletions(-)