| Message ID | 1539599008-8382-2-git-send-email-patryk.mungai-ndungu.kx@renesas.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Delegated to: | Nobuhiro Iwamatsu |
| Headers | show |
| Series | Add PMU support to iwg2[02]m | expand |
Hi, > > [Backport to CIP] I suggest to address what you've modified from the upstream patch, it would be helpful for maintainer's review task. For example: [Context changes] Just my two cents. > Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com> > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > --- > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi > index 69b383c..54b556b 100644 > --- a/arch/arm/boot/dts/r8a7745.dtsi > +++ b/arch/arm/boot/dts/r8a7745.dtsi > @@ -93,6 +93,13 @@ > }; > }; > > + pmu { > + compatible = "arm,cortex-a7-pmu"; > + interrupts-extended = <&gic GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>, > + <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-affinity = <&cpu0>, <&cpu1>; > + }; > + > soc { > compatible = "simple-bus"; > interrupt-parent = <&gic>; > -- > 2.7.4 > > _______________________________________________ > cip-dev mailing list > cip-dev@lists.cip-project.org > https://lists.cip-project.org/mailman/listinfo/cip-dev
Hi, 2018年10月21日(日) 16:49 SZ Lin (林上智) <sz.lin@moxa.com>: > > Hi, > > > > > [Backport to CIP] > > I suggest to address what you've modified from the upstream patch, it > would be helpful for maintainer's review task. > > For example: [Context changes] > I think so, too. Patryk, could you please post with changes? > Just my two cents. Best regards, Nobuhiro > > > Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com> > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > --- > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi > > index 69b383c..54b556b 100644 > > --- a/arch/arm/boot/dts/r8a7745.dtsi > > +++ b/arch/arm/boot/dts/r8a7745.dtsi > > @@ -93,6 +93,13 @@ > > }; > > }; > > > > + pmu { > > + compatible = "arm,cortex-a7-pmu"; > > + interrupts-extended = <&gic GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>, > > + <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-affinity = <&cpu0>, <&cpu1>; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > interrupt-parent = <&gic>; > > -- > > 2.7.4 > > > > _______________________________________________ > > cip-dev mailing list > > cip-dev@lists.cip-project.org > > https://lists.cip-project.org/mailman/listinfo/cip-dev > _______________________________________________ > cip-dev mailing list > cip-dev@lists.cip-project.org > https://lists.cip-project.org/mailman/listinfo/cip-dev
Hello SZ, Nobuhiro-san, > From: cip-dev-bounces@lists.cip-project.org <cip-dev-bounces@lists.cip- > project.org> On Behalf Of ???? > Sent: 21 October 2018 09:06 > > Hi, > > 2018年10月21日(日) 16:49 SZ Lin (林上智) <sz.lin@moxa.com>: > > > > Hi, > > > > > > > > [Backport to CIP] > > > > I suggest to address what you've modified from the upstream patch, it > > would be helpful for maintainer's review task. > > > > For example: [Context changes] > > > > I think so, too. Me too, however for the patches in this series the changes are actually identical to the upstream commits. The intention of [Backport to CIP] was just to split the signed-off tags between upstream and backport committers, as we moved the cherry-picked commit ID to the top of the patch. Kind regards, Chris > Patryk, could you please post with changes? > > > Just my two cents. > > Best regards, > Nobuhiro > > > > > > Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com> > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > --- > > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644 > > > --- a/arch/arm/boot/dts/r8a7745.dtsi > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi > > > @@ -93,6 +93,13 @@ > > > }; > > > }; > > > > > > + pmu { > > > + compatible = "arm,cortex-a7-pmu"; > > > + interrupts-extended = <&gic GIC_SPI 82 > IRQ_TYPE_LEVEL_HIGH>, > > > + <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; > > > + interrupt-affinity = <&cpu0>, <&cpu1>; > > > + }; > > > + > > > soc { > > > compatible = "simple-bus"; > > > interrupt-parent = <&gic>; > > > -- > > > 2.7.4 > > > > > > _______________________________________________ > > > cip-dev mailing list > > > cip-dev@lists.cip-project.org > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > _______________________________________________ > > cip-dev mailing list > > cip-dev@lists.cip-project.org > > https://lists.cip-project.org/mailman/listinfo/cip-dev > _______________________________________________ > cip-dev mailing list > cip-dev@lists.cip-project.org > https://lists.cip-project.org/mailman/listinfo/cip-dev
Hi, > Me too, however for the patches in this series the changes are actually identical to the > upstream commits. > > The intention of [Backport to CIP] was just to split the signed-off tags between upstream > and backport committers, as we moved the cherry-picked commit ID to the top of the > patch. According to the guide of submitting patches [1] - "the line between the last Signed-off-by header and yours, indicating the nature of your changes", I think it is unnecessary to add this comment in this case. Furthermore, it doesn't need to split signed-off tags between upstream and backport committers in stable kernel [2]. Nevertheless, we can define our policy here if we decided to add this line for each CIP patches. [1] https://www.kernel.org/doc/html/v4.18/process/submitting-patches.html [2] https://lkml.org/lkml/2018/10/16/595 SZ > > Kind regards, Chris > > > Patryk, could you please post with changes? > > > > > Just my two cents. > > > > Best regards, > > Nobuhiro > > > > > > > > > Signed-off-by: Patryk Mungai <patryk.mungai-ndungu.kx@renesas.com> > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > --- > > > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi > > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644 > > > > --- a/arch/arm/boot/dts/r8a7745.dtsi > > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi > > > > @@ -93,6 +93,13 @@ > > > > }; > > > > }; > > > > > > > > + pmu { > > > > + compatible = "arm,cortex-a7-pmu"; > > > > + interrupts-extended = <&gic GIC_SPI 82 > > IRQ_TYPE_LEVEL_HIGH>, > > > > + <&gic GIC_SPI 83 > IRQ_TYPE_LEVEL_HIGH>; > > > > + interrupt-affinity = <&cpu0>, <&cpu1>; > > > > + }; > > > > + > > > > soc { > > > > compatible = "simple-bus"; > > > > interrupt-parent = <&gic>; > > > > -- > > > > 2.7.4 > > > > > > > > _______________________________________________ > > > > cip-dev mailing list > > > > cip-dev@lists.cip-project.org > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > _______________________________________________ > > > cip-dev mailing list > > > cip-dev@lists.cip-project.org > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > _______________________________________________ > > cip-dev mailing list > > cip-dev@lists.cip-project.org > > https://lists.cip-project.org/mailman/listinfo/cip-dev
Hello Nobuhiro-san, In light of all the previous comments, would you like me to change the [Backported to CIP] tag to describe the changes of the patch, or to get rid of it altogether before I send the patch? Kind Regards, Patryk > -----Original Message----- > From: cip-dev-bounces@lists.cip-project.org <cip-dev-bounces@lists.cip- > project.org> On Behalf Of SZ Lin (???) > Sent: 22 October 2018 07:53 > To: Chris Paterson <Chris.Paterson2@renesas.com>; 岩松信洋 > <nobuhiro.iwamatsu@miraclelinux.com> > Cc: cip-dev@lists.cip-project.org > Subject: Re: [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node > > Hi, > > > Me too, however for the patches in this series the changes are > > actually identical to the upstream commits. > > > > The intention of [Backport to CIP] was just to split the signed-off > > tags between upstream and backport committers, as we moved the > > cherry-picked commit ID to the top of the patch. > > According to the guide of submitting patches [1] - "the line between the last > Signed-off-by header and yours, indicating the nature of your changes", I > think it is unnecessary to add this comment in this case. Furthermore, it > doesn't need to split signed-off tags between upstream and backport > committers in stable kernel [2]. > > Nevertheless, we can define our policy here if we decided to add this line for > each CIP patches. > > [1] https://www.kernel.org/doc/html/v4.18/process/submitting- > patches.html > [2] https://lkml.org/lkml/2018/10/16/595 > > SZ > > > > > Kind regards, Chris > > > > > Patryk, could you please post with changes? > > > > > > > Just my two cents. > > > > > > Best regards, > > > Nobuhiro > > > > > > > > > > > > Signed-off-by: Patryk Mungai > > > > > <patryk.mungai-ndungu.kx@renesas.com> > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > --- > > > > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++ > > > > > 1 file changed, 7 insertions(+) > > > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi > > > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644 > > > > > --- a/arch/arm/boot/dts/r8a7745.dtsi > > > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi > > > > > @@ -93,6 +93,13 @@ > > > > > }; > > > > > }; > > > > > > > > > > + pmu { > > > > > + compatible = "arm,cortex-a7-pmu"; > > > > > + interrupts-extended = <&gic GIC_SPI 82 > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > + <&gic GIC_SPI 83 > > IRQ_TYPE_LEVEL_HIGH>; > > > > > + interrupt-affinity = <&cpu0>, <&cpu1>; > > > > > + }; > > > > > + > > > > > soc { > > > > > compatible = "simple-bus"; > > > > > interrupt-parent = <&gic>; > > > > > -- > > > > > 2.7.4 > > > > > > > > > > _______________________________________________ > > > > > cip-dev mailing list > > > > > cip-dev@lists.cip-project.org > > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > > _______________________________________________ > > > > cip-dev mailing list > > > > cip-dev@lists.cip-project.org > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > _______________________________________________ > > > cip-dev mailing list > > > cip-dev@lists.cip-project.org > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > _______________________________________________ > cip-dev mailing list > cip-dev@lists.cip-project.org > https://lists.cip-project.org/mailman/listinfo/cip-dev Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Hi, Patryk. These patches has not changed from upstream commit. So Could you resend the patch with [Backport to CIP] removed? And if the patch has been modified from the upstream patch, please add the [Backport to CIP] tag and the changes as before. Best regards, Nobuhiro 2018年10月23日(火) 0:42 Patryk Mungai Ndungu <patryk.mungai-ndungu.kx@renesas.com>: > > Hello Nobuhiro-san, > > In light of all the previous comments, would you like me to change the [Backported to CIP] tag to describe the changes of the patch, or to get rid of it altogether before I send the patch? > > Kind Regards, > > Patryk > > > > > -----Original Message----- > > From: cip-dev-bounces@lists.cip-project.org <cip-dev-bounces@lists.cip- > > project.org> On Behalf Of SZ Lin (???) > > Sent: 22 October 2018 07:53 > > To: Chris Paterson <Chris.Paterson2@renesas.com>; 岩松信洋 > > <nobuhiro.iwamatsu@miraclelinux.com> > > Cc: cip-dev@lists.cip-project.org > > Subject: Re: [cip-dev] [PATCH 1/2] ARM: dts: r8a7745: Add PMU device node > > > > Hi, > > > > > Me too, however for the patches in this series the changes are > > > actually identical to the upstream commits. > > > > > > The intention of [Backport to CIP] was just to split the signed-off > > > tags between upstream and backport committers, as we moved the > > > cherry-picked commit ID to the top of the patch. > > > > According to the guide of submitting patches [1] - "the line between the last > > Signed-off-by header and yours, indicating the nature of your changes", I > > think it is unnecessary to add this comment in this case. Furthermore, it > > doesn't need to split signed-off tags between upstream and backport > > committers in stable kernel [2]. > > > > Nevertheless, we can define our policy here if we decided to add this line for > > each CIP patches. > > > > [1] https://www.kernel.org/doc/html/v4.18/process/submitting- > > patches.html > > [2] https://lkml.org/lkml/2018/10/16/595 > > > > SZ > > > > > > > > Kind regards, Chris > > > > > > > Patryk, could you please post with changes? > > > > > > > > > Just my two cents. > > > > > > > > Best regards, > > > > Nobuhiro > > > > > > > > > > > > > > > Signed-off-by: Patryk Mungai > > > > > > <patryk.mungai-ndungu.kx@renesas.com> > > > > > > Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com> > > > > > > --- > > > > > > arch/arm/boot/dts/r8a7745.dtsi | 7 +++++++ > > > > > > 1 file changed, 7 insertions(+) > > > > > > > > > > > > diff --git a/arch/arm/boot/dts/r8a7745.dtsi > > > > > > b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644 > > > > > > --- a/arch/arm/boot/dts/r8a7745.dtsi > > > > > > +++ b/arch/arm/boot/dts/r8a7745.dtsi > > > > > > @@ -93,6 +93,13 @@ > > > > > > }; > > > > > > }; > > > > > > > > > > > > + pmu { > > > > > > + compatible = "arm,cortex-a7-pmu"; > > > > > > + interrupts-extended = <&gic GIC_SPI 82 > > > > IRQ_TYPE_LEVEL_HIGH>, > > > > > > + <&gic GIC_SPI 83 > > > IRQ_TYPE_LEVEL_HIGH>; > > > > > > + interrupt-affinity = <&cpu0>, <&cpu1>; > > > > > > + }; > > > > > > + > > > > > > soc { > > > > > > compatible = "simple-bus"; > > > > > > interrupt-parent = <&gic>; > > > > > > -- > > > > > > 2.7.4 > > > > > > > > > > > > _______________________________________________ > > > > > > cip-dev mailing list > > > > > > cip-dev@lists.cip-project.org > > > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > > > _______________________________________________ > > > > > cip-dev mailing list > > > > > cip-dev@lists.cip-project.org > > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > > _______________________________________________ > > > > cip-dev mailing list > > > > cip-dev@lists.cip-project.org > > > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > _______________________________________________ > > cip-dev mailing list > > cip-dev@lists.cip-project.org > > https://lists.cip-project.org/mailman/listinfo/cip-dev > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/arch/arm/boot/dts/r8a7745.dtsi b/arch/arm/boot/dts/r8a7745.dtsi index 69b383c..54b556b 100644 --- a/arch/arm/boot/dts/r8a7745.dtsi +++ b/arch/arm/boot/dts/r8a7745.dtsi @@ -93,6 +93,13 @@ }; }; + pmu { + compatible = "arm,cortex-a7-pmu"; + interrupts-extended = <&gic GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>, + <&gic GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>; + interrupt-affinity = <&cpu0>, <&cpu1>; + }; + soc { compatible = "simple-bus"; interrupt-parent = <&gic>;