| Message ID | 20181004135636.GA15157@embeddedor.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | power: max8925: mark expected switch fall-through | expand |
Hi, On Thu, Oct 04, 2018 at 03:56:36PM +0200, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 201510 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- Thanks, queued. -- Sebastian > drivers/power/supply/max8925_power.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/power/supply/max8925_power.c b/drivers/power/supply/max8925_power.c > index 3b94620..39b4d5b 100644 > --- a/drivers/power/supply/max8925_power.c > +++ b/drivers/power/supply/max8925_power.c > @@ -124,6 +124,7 @@ static irqreturn_t max8925_charger_handler(int irq, void *data) > case MAX8925_IRQ_VCHG_THM_OK_F: > /* Battery is not ready yet */ > dev_dbg(chip->dev, "Battery temperature is out of range\n"); > + /* Fall through */ > case MAX8925_IRQ_VCHG_DC_OVP: > dev_dbg(chip->dev, "Error detection\n"); > __set_charger(info, 0); > -- > 2.7.4 >
diff --git a/drivers/power/supply/max8925_power.c b/drivers/power/supply/max8925_power.c index 3b94620..39b4d5b 100644 --- a/drivers/power/supply/max8925_power.c +++ b/drivers/power/supply/max8925_power.c @@ -124,6 +124,7 @@ static irqreturn_t max8925_charger_handler(int irq, void *data) case MAX8925_IRQ_VCHG_THM_OK_F: /* Battery is not ready yet */ dev_dbg(chip->dev, "Battery temperature is out of range\n"); + /* Fall through */ case MAX8925_IRQ_VCHG_DC_OVP: dev_dbg(chip->dev, "Error detection\n"); __set_charger(info, 0);
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 201510 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/power/supply/max8925_power.c | 1 + 1 file changed, 1 insertion(+)