[28/28] xfs: remove [cm]time update from reflink calls

Message ID	154013869780.29026.674362788764806472.stgit@magnolia (mailing list archive)
State	New, archived
Headers	show Return-Path: <owner-linux-mm@kvack.org> Received-SPF: pass (google.com: domain of darrick.wong@oracle.com designates 156.151.31.86 as permitted sender) client-ip=156.151.31.86; Subject: [PATCH 28/28] xfs: remove [cm]time update from reflink calls From: "Darrick J. Wong" <darrick.wong@oracle.com> To: david@fromorbit.com, darrick.wong@oracle.com Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com Date: Sun, 21 Oct 2018 09:18:17 -0700 Message-ID: <154013869780.29026.674362788764806472.stgit@magnolia> In-Reply-To: <154013850285.29026.16168387526580596209.stgit@magnolia> References: <154013850285.29026.16168387526580596209.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Precedence: bulk
Series	fs: fixes for serious clone/dedupe problems \| expand [v6,00/28] fs: fixes for serious clone/dedupe problems [01/28] vfs: vfs_clone_file_prep_inodes should return EINVAL for a clone from beyond EOF [02/28] vfs: check file ranges before cloning files [03/28] vfs: exit early from zero length remap operations [04/28] vfs: strengthen checking of file range inputs to generic_remap_checks [05/28] vfs: avoid problematic remapping requests into partial EOF block [06/28] vfs: skip zero-length dedupe requests [07/28] vfs: rename vfs_clone_file_prep to be more descriptive [08/28] vfs: rename clone_verify_area to remap_verify_area [09/28] vfs: combine the clone and dedupe into a single remap_file_range [10/28] vfs: pass remap flags to generic_remap_file_range_prep [11/28] vfs: pass remap flags to generic_remap_checks [12/28] vfs: remap helper should update destination inode metadata [13/28] vfs: make remap_file_range functions take and return bytes completed [14/28] vfs: plumb remap flags through the vfs clone functions [15/28] vfs: plumb remap flags through the vfs dedupe functions [16/28] vfs: enable remap callers that can handle short operations [17/28] vfs: hide file range comparison function [18/28] vfs: clean up generic_remap_file_range_prep return value [19/28] ocfs2: truncate page cache for clone destination file before remapping [20/28] ocfs2: fix pagecache truncation prior to reflink [21/28] ocfs2: support partial clone range and dedupe range [22/28] ocfs2: remove ocfs2_reflink_remap_range [23/28] xfs: fix pagecache truncation prior to reflink [24/28] xfs: clean up xfs_reflink_remap_blocks call site [25/28] xfs: support returning partial reflink results [26/28] xfs: remove redundant remap partial EOF block checks [27/28] xfs: remove xfs_reflink_remap_range [28/28] xfs: remove [cm]time update from reflink calls

Message ID

154013869780.29026.674362788764806472.stgit@magnolia (mailing list archive)

State

New, archived

Headers

Received-SPF: pass (google.com: domain of darrick.wong@oracle.com designates
 156.151.31.86 as permitted sender) client-ip=156.151.31.86;
Subject: [PATCH 28/28] xfs: remove [cm]time update from reflink calls
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: david@fromorbit.com, darrick.wong@oracle.com
Cc: sandeen@redhat.com, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
        linux-unionfs@vger.kernel.org, linux-xfs@vger.kernel.org,
        linux-mm@kvack.org, linux-btrfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com
Date: Sun, 21 Oct 2018 09:18:17 -0700
Message-ID: <154013869780.29026.674362788764806472.stgit@magnolia>
In-Reply-To: <154013850285.29026.16168387526580596209.stgit@magnolia>
References: <154013850285.29026.16168387526580596209.stgit@magnolia>
User-Agent: StGit/0.17.1-dirty
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: owner-linux-mm@kvack.org
Precedence: bulk

Series

fs: fixes for serious clone/dedupe problems | expand

Commit Message

Darrick J. Wong Oct. 21, 2018, 4:18 p.m. UTC

From: Darrick J. Wong <darrick.wong@oracle.com>

Now that the vfs remap helper dirties the inode [cm]time for us, xfs no
longer needs to do that on its own.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_reflink.c |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Dave Chinner Oct. 22, 2018, 2:18 a.m. UTC | #1

On Sun, Oct 21, 2018 at 09:18:17AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Now that the vfs remap helper dirties the inode [cm]time for us, xfs no
> longer needs to do that on its own.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
index 84f372f7ea04..e72218477bf2 100644
--- a/fs/xfs/xfs_reflink.c
+++ b/fs/xfs/xfs_reflink.c
@@ -927,8 +927,7 @@  xfs_reflink_update_dest(
 	struct xfs_trans	*tp;
 	int			error;
 
-	if ((remap_flags & REMAP_FILE_DEDUP) &&
-	    newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0)
+	if (newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0)
 		return 0;
 
 	error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ichange, 0, 0, 0, &tp);
@@ -949,10 +948,6 @@  xfs_reflink_update_dest(
 		dest->i_d.di_flags2 |= XFS_DIFLAG2_COWEXTSIZE;
 	}
 
-	if (!(remap_flags & REMAP_FILE_DEDUP)) {
-		xfs_trans_ichgtime(tp, dest,
-				   XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG);
-	}
 	xfs_trans_log_inode(tp, dest, XFS_ILOG_CORE);
 
 	error = xfs_trans_commit(tp);

[28/28] xfs: remove [cm]time update from reflink calls

Commit Message

Comments

Patch