| Message ID | 20181023155035.9101-11-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: Allwinner A64 MIPI-DSI support | expand |
On Tue, Oct 23, 2018 at 09:20:30PM +0530, Jagan Teki wrote: > Bananapi S070WV20-CT16 ICN6211 is 800x480, 4-lane MIPI-DSI to RGB bridge panel, > the same panel PCB comes with parallel RBG which is supported via > panel-simple driver with "bananapi,s070wv20-ct16" compatible. > > But this binding is specific for MIPI DSI to RGB bridge panels, > which usually accessed using MIPI DSI controller driver. > > for information: > - "bananapi,s070wv20-ct16" compatible for parallel RGB panels > - "bananapi,s070wv20-ct16-icn6211" compatible for MIPI-DSI to RGB > bridge panels > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> Why not just reusing the same binding document? Maxime
On Wed, Oct 24, 2018 at 7:08 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Tue, Oct 23, 2018 at 09:20:30PM +0530, Jagan Teki wrote: > > Bananapi S070WV20-CT16 ICN6211 is 800x480, 4-lane MIPI-DSI to RGB bridge panel, > > the same panel PCB comes with parallel RBG which is supported via > > panel-simple driver with "bananapi,s070wv20-ct16" compatible. > > > > But this binding is specific for MIPI DSI to RGB bridge panels, > > which usually accessed using MIPI DSI controller driver. > > > > for information: > > - "bananapi,s070wv20-ct16" compatible for parallel RGB panels > > - "bananapi,s070wv20-ct16-icn6211" compatible for MIPI-DSI to RGB > > bridge panels > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > Why not just reusing the same binding document? Agreed. Just put the MIPI-DSI-specific information you added here into the existing document. Rob suggested that we could even use the same compatible. That would make sense if you are modelling the entire panel + PCB as a module, instead of a panel node + a bridge node as I originally wanted. Don't worry, I gave it some thought and I think having a single combined panel node makes more sense. ChenYu
diff --git a/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16-icn6211.txt b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16-icn6211.txt new file mode 100644 index 000000000000..68a89b6feaee --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16-icn6211.txt @@ -0,0 +1,21 @@ +Bananapi S070WV20-CT16 ICN6211 MIPI-DSI to RGB bridge + +Required properties: +- compatible: must be "bananapi,s070wv20-ct16-icn6211" +- reg: DSI virtual channel used by that screen +- avdd-supply: analog regulator dc1 switch +- dvdd-supply: 3v3 digital regulator +- reset-gpios: a GPIO phandle for the reset pin + +Optional properties: +- backlight: phandle for the backlight control. + +Example: +panel@0 { + compatible = "bananapi,s070wv20-ct16-icn6211"; + reg = <0>; + avdd-supply = <®_dc1sw>; + dvdd-supply = <®_dldo1>; + reset-gpios = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ + backlight = <&backlight_dsi>; +};
Bananapi S070WV20-CT16 ICN6211 is 800x480, 4-lane MIPI-DSI to RGB bridge panel, the same panel PCB comes with parallel RBG which is supported via panel-simple driver with "bananapi,s070wv20-ct16" compatible. But this binding is specific for MIPI DSI to RGB bridge panels, which usually accessed using MIPI DSI controller driver. for information: - "bananapi,s070wv20-ct16" compatible for parallel RGB panels - "bananapi,s070wv20-ct16-icn6211" compatible for MIPI-DSI to RGB bridge panels Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v2: - Add detailed commit message - Update the bindings as MIPI-DSI to RGB bridge .../panel/bananapi,s070wv20-ct16-icn6211.txt | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/bananapi,s070wv20-ct16-icn6211.txt