| Message ID | 20181023155035.9101-16-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/sun4i: Allwinner A64 MIPI-DSI support | expand |
On Tue, Oct 23, 2018 at 09:20:35PM +0530, Jagan Teki wrote: > This patch add support for Bananapi S070WV20-CT16 DSI panel to > BPI-M64 board. > > DSI panel connected via board DSI port with, > - DC1SW as AVDD supply > - DCDC1 as DVDD supply > - PD6 gpio for reset pin > - PD5 gpio for backlight enable pin > - PD7 gpio for backlight vdd supply > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2: > - Use quadratic rule on pwm brightness > > .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > index ef1c90401bb2..e0c6d1870a94 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > @@ -45,6 +45,7 @@ > #include "sun50i-a64.dtsi" > > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/pwm/pwm.h> > > / { > model = "BananaPi-M64"; > @@ -56,6 +57,24 @@ > serial1 = &uart1; > }; > > + vdd_bl: regulator@0 { You shouldn't have a unit address if you don't have a reg property. This will trigger a DTC warning. > + compatible = "regulator-fixed"; > + regulator-name = "bl-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + gpio = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* PD7 */ > + enable-active-high; > + }; > + > + backlight_dsi: backlight-dsi { > + compatible = "pwm-backlight"; > + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels = <1 2 4 8 16 32 64 128 512>; > + default-brightness-level = <2>; > + enable-gpios = <&pio 3 5 GPIO_ACTIVE_HIGH>; /* PD5 */ > + power-supply = <&vdd_bl>; > + }; These nodes should be ordered by alphabetical order. Maxime
On Wed, Oct 24, 2018 at 7:12 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > On Tue, Oct 23, 2018 at 09:20:35PM +0530, Jagan Teki wrote: > > This patch add support for Bananapi S070WV20-CT16 DSI panel to > > BPI-M64 board. > > > > DSI panel connected via board DSI port with, > > - DC1SW as AVDD supply > > - DCDC1 as DVDD supply > > - PD6 gpio for reset pin > > - PD5 gpio for backlight enable pin > > - PD7 gpio for backlight vdd supply This is for a removable module, which is best handled using an overlay. This patch should be marked [DO NOT MERGE]. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v2: > > - Use quadratic rule on pwm brightness > > > > .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42 +++++++++++++++++++ > > 1 file changed, 42 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > index ef1c90401bb2..e0c6d1870a94 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > > @@ -45,6 +45,7 @@ > > #include "sun50i-a64.dtsi" > > > > #include <dt-bindings/gpio/gpio.h> > > +#include <dt-bindings/pwm/pwm.h> > > > > / { > > model = "BananaPi-M64"; > > @@ -56,6 +57,24 @@ > > serial1 = &uart1; > > }; > > > > + vdd_bl: regulator@0 { > > You shouldn't have a unit address if you don't have a reg > property. This will trigger a DTC warning. > > + compatible = "regulator-fixed"; > > + regulator-name = "bl-3v3"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + gpio = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* PD7 */ > > + enable-active-high; > > + }; > > + > > + backlight_dsi: backlight-dsi { This should be just "backlight". There's nothing DSI specific about a backlight. > > + compatible = "pwm-backlight"; > > + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; > > + brightness-levels = <1 2 4 8 16 32 64 128 512>; > > + default-brightness-level = <2>; > > + enable-gpios = <&pio 3 5 GPIO_ACTIVE_HIGH>; /* PD5 */ > > + power-supply = <&vdd_bl>; > > + }; > > These nodes should be ordered by alphabetical order. > > Maxime > > -- > Maxime Ripard, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts index ef1c90401bb2..e0c6d1870a94 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts @@ -45,6 +45,7 @@ #include "sun50i-a64.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/pwm/pwm.h> / { model = "BananaPi-M64"; @@ -56,6 +57,24 @@ serial1 = &uart1; }; + vdd_bl: regulator@0 { + compatible = "regulator-fixed"; + regulator-name = "bl-3v3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&pio 3 7 GPIO_ACTIVE_HIGH>; /* PD7 */ + enable-active-high; + }; + + backlight_dsi: backlight-dsi { + compatible = "pwm-backlight"; + pwms = <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; + brightness-levels = <1 2 4 8 16 32 64 128 512>; + default-brightness-level = <2>; + enable-gpios = <&pio 3 5 GPIO_ACTIVE_HIGH>; /* PD5 */ + power-supply = <&vdd_bl>; + }; + chosen { stdout-path = "serial0:115200n8"; }; @@ -101,6 +120,23 @@ status = "okay"; }; +&dphy { + status = "okay"; +}; + +&dsi { + status = "okay"; + + panel@0 { + compatible = "bananapi,s070wv20-ct16-icn6211"; + reg = <0>; + avdd-supply = <®_dc1sw>; + dvdd-supply = <®_dldo1>; + reset-gpios = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ + backlight = <&backlight_dsi>; + }; +}; + &ehci0 { status = "okay"; }; @@ -193,6 +229,12 @@ status = "okay"; }; +&r_pwm { + pinctrl-names = "default"; + pinctrl-0 = <&r_pwm_pin>; + status = "okay"; +}; + &r_rsb { status = "okay";
This patch add support for Bananapi S070WV20-CT16 DSI panel to BPI-M64 board. DSI panel connected via board DSI port with, - DC1SW as AVDD supply - DCDC1 as DVDD supply - PD6 gpio for reset pin - PD5 gpio for backlight enable pin - PD7 gpio for backlight vdd supply Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v2: - Use quadratic rule on pwm brightness .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+)