diff mbox series

tpm: tpm_ibmvtpm: fix kdoc warnings

Message ID 20181026184043.5524-2-tomas.winkler@intel.com (mailing list archive)
State New, archived
Headers show
Series tpm: tpm_ibmvtpm: fix kdoc warnings | expand

Commit Message

Winkler, Tomas Oct. 26, 2018, 6:40 p.m. UTC 
Remove redundant lines in the kdoc:

Fixes kdoc warnings:

drivers/char/tpm/tpm_ibmvtpm.c:42: warning: Cannot understand  *
 on line 42 - I thought it was a doc line
drivers/char/tpm/tpm_ibmvtpm.c:57: warning: Cannot understand  *
 on line 57 - I thought it was a doc line

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
 drivers/char/tpm/tpm_ibmvtpm.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Jarkko Sakkinen Oct. 30, 2018, 11:23 a.m. UTC | #1 
On Fri, 26 Oct 2018, Tomas Winkler wrote:
> Remove redundant lines in the kdoc:
>
> Fixes kdoc warnings:
>
> drivers/char/tpm/tpm_ibmvtpm.c:42: warning: Cannot understand  *
> on line 42 - I thought it was a doc line
> drivers/char/tpm/tpm_ibmvtpm.c:57: warning: Cannot understand  *
> on line 57 - I thought it was a doc line
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 25f6e2665385..07b5a487d0c8 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -39,8 +39,7 @@ static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
> MODULE_DEVICE_TABLE(vio, tpm_ibmvtpm_device_table);
>
> /**
> - *
> - * ibmvtpm_send_crq_word - Send a CRQ request
> + * ibmvtpm_send_crq_word() - Send a CRQ request
>  * @vdev:	vio device struct
>  * @w1:		pre-constructed first word of tpm crq (second word is reserved)
>  *
> @@ -54,8 +53,7 @@ static int ibmvtpm_send_crq_word(struct vio_dev *vdev, u64 w1)
> }
>
> /**
> - *
> - * ibmvtpm_send_crq - Send a CRQ request
> + * ibmvtpm_send_crq() - Send a CRQ request
>  *
>  * @vdev:	vio device struct
>  * @valid:	Valid field
> -- 
> 2.14.5
>
>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko
diff mbox series

Patch

diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 25f6e2665385..07b5a487d0c8 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -39,8 +39,7 @@  static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
 MODULE_DEVICE_TABLE(vio, tpm_ibmvtpm_device_table);
 
 /**
- *
- * ibmvtpm_send_crq_word - Send a CRQ request
+ * ibmvtpm_send_crq_word() - Send a CRQ request
  * @vdev:	vio device struct
  * @w1:		pre-constructed first word of tpm crq (second word is reserved)
  *
@@ -54,8 +53,7 @@  static int ibmvtpm_send_crq_word(struct vio_dev *vdev, u64 w1)
 }
 
 /**
- *
- * ibmvtpm_send_crq - Send a CRQ request
+ * ibmvtpm_send_crq() - Send a CRQ request
  *
  * @vdev:	vio device struct
  * @valid:	Valid field