mbox series

[v3,0/3] Deprecate QMP & HMP `cpu-add`; document vCPU hotplug

Message ID 20181030123526.26415-1-kchamart@redhat.com (mailing list archive)
Headers show
Series Deprecate QMP & HMP `cpu-add`; document vCPU hotplug | expand

Message

Kashyap Chamarthy Oct. 30, 2018, 12:35 p.m. UTC 
The first patch deprecates the QMP `cpu-add`, the second its HMP 
equivalent, and the third documents vCPU hotplug procedure using QMP
`device_add` et al.

v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03191.html

Kashyap Chamarthy (3):
  Deprecate QMP `cpu-add`
  Deprecate HMP `cpu-add`
  docs: Document vCPU hotplug procedure

 docs/cpu-hotplug.rst | 142 +++++++++++++++++++++++++++++++++++++++++++
 hmp-commands.hx      |   6 +-
 hmp.c                |   2 +
 qapi/misc.json       |   8 ++-
 qemu-deprecated.texi |   5 ++
 5 files changed, 160 insertions(+), 3 deletions(-)
 create mode 100644 docs/cpu-hotplug.rst

Comments

Kashyap Chamarthy Oct. 30, 2018, 1 p.m. UTC | #1 
[Cc: libvir-list]

On Tue, Oct 30, 2018 at 01:35:23PM +0100, Kashyap Chamarthy wrote:
> The first patch deprecates the QMP `cpu-add`, the second its HMP 
> equivalent, and the third documents vCPU hotplug procedure using QMP
> `device_add` et al.
> 
> v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03191.html
> 
> Kashyap Chamarthy (3):
>   Deprecate QMP `cpu-add`
>   Deprecate HMP `cpu-add`
>   docs: Document vCPU hotplug procedure
> 
>  docs/cpu-hotplug.rst | 142 +++++++++++++++++++++++++++++++++++++++++++
>  hmp-commands.hx      |   6 +-
>  hmp.c                |   2 +
>  qapi/misc.json       |   8 ++-
>  qemu-deprecated.texi |   5 ++
>  5 files changed, 160 insertions(+), 3 deletions(-)
>  create mode 100644 docs/cpu-hotplug.rst
> 
> -- 
> 2.17.1
>
Michal Privoznik Oct. 30, 2018, 3:56 p.m. UTC | #2 
On 10/30/2018 02:00 PM, Kashyap Chamarthy wrote:
> [Cc: libvir-list]
> 
> On Tue, Oct 30, 2018 at 01:35:23PM +0100, Kashyap Chamarthy wrote:
>> The first patch deprecates the QMP `cpu-add`, the second its HMP 
>> equivalent, and the third documents vCPU hotplug procedure using QMP
>> `device_add` et al.

Thanks for heads up. Libvirt already uses device_add if
'query-hotpluggable-cpus' command is available and 'query-machines'
returns 'hotpluggable-cpus: yes' for given machine type. It only falls
back to cpu-add.

Michal
Markus Armbruster Oct. 31, 2018, 3:17 p.m. UTC | #3 
Kashyap Chamarthy <kchamart@redhat.com> writes:

> The first patch deprecates the QMP `cpu-add`, the second its HMP 
> equivalent, and the third documents vCPU hotplug procedure using QMP
> `device_add` et al.
>
> v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03191.html

Preferably reordered so that PATCH 3 comes before 1 & 2, series
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Eduardo Habkost Oct. 31, 2018, 6:24 p.m. UTC | #4 
On Wed, Oct 31, 2018 at 04:17:26PM +0100, Markus Armbruster wrote:
> Kashyap Chamarthy <kchamart@redhat.com> writes:
> 
> > The first patch deprecates the QMP `cpu-add`, the second its HMP 
> > equivalent, and the third documents vCPU hotplug procedure using QMP
> > `device_add` et al.
> >
> > v2: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03191.html
> 
> Preferably reordered so that PATCH 3 comes before 1 & 2, series
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Thanks, queued on machine-next.

Being only documentation updates, I consider it to be reasonable
to be included after soft freeze.