| Message ID | 20181026023812.29720-4-martin@martingkelly.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/4] iio: magnetometer: add clarifying comment | expand |
On Thu, 25 Oct 2018 19:38:12 -0700 Martin Kelly <martin@martingkelly.com> wrote: > From: Martin Kelly <martin@martingkelly.com> > > Add DT binding documentation for the LSM9DS1 magnetometer driver. > > Signed-off-by: Martin Kelly <martin@martingkelly.com> Given here isn't really an alternative way of doing this (or we haven't come up with one yet) in the sensors that are basically multiple chips in one package, I'll hope that Rob is happy with the new name and apply it. As I'm only pushing out for build tests today I can revert or add his Reviewed-by as needed. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > Documentation/devicetree/bindings/iio/st-sensors.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt b/Documentation/devicetree/bindings/iio/st-sensors.txt > index 6f626f73417e..07f1767c7ee6 100644 > --- a/Documentation/devicetree/bindings/iio/st-sensors.txt > +++ b/Documentation/devicetree/bindings/iio/st-sensors.txt > @@ -67,6 +67,7 @@ Magnetometers: > - st,lsm303dlm-magn > - st,lis3mdl-magn > - st,lis2mdl > +- st,lsm9ds1-magn > > Pressure sensors: > - st,lps001wp-press
On Sun, Oct 28, 2018 at 06:53:08PM +0000, Jonathan Cameron wrote: > On Thu, 25 Oct 2018 19:38:12 -0700 > Martin Kelly <martin@martingkelly.com> wrote: > > > From: Martin Kelly <martin@martingkelly.com> > > > > Add DT binding documentation for the LSM9DS1 magnetometer driver. Bindings are for h/w, not drivers. > > > > Signed-off-by: Martin Kelly <martin@martingkelly.com> > Given here isn't really an alternative way of doing this (or we > haven't come up with one yet) in the sensors that are basically multiple > chips in one package, I'll hope that Rob is happy with the new name > and apply it. As I'm only pushing out for build tests today I can > revert or add his Reviewed-by as needed. Given only the supplies seem to be shared and those can be handled correctly with ref counting, separate devices is fine. We do the same thing for BT/WiFi combo chips with separate host interfaces. Reviewed-by: Rob Herring <robh@kernel.org> Rob
On Tue, 30 Oct 2018 16:44:41 -0500 Rob Herring <robh@kernel.org> wrote: > On Sun, Oct 28, 2018 at 06:53:08PM +0000, Jonathan Cameron wrote: > > On Thu, 25 Oct 2018 19:38:12 -0700 > > Martin Kelly <martin@martingkelly.com> wrote: > > > > > From: Martin Kelly <martin@martingkelly.com> > > > > > > Add DT binding documentation for the LSM9DS1 magnetometer driver. > > Bindings are for h/w, not drivers. > > > > > > > Signed-off-by: Martin Kelly <martin@martingkelly.com> > > Given here isn't really an alternative way of doing this (or we > > haven't come up with one yet) in the sensors that are basically multiple > > chips in one package, I'll hope that Rob is happy with the new name > > and apply it. As I'm only pushing out for build tests today I can > > revert or add his Reviewed-by as needed. > > Given only the supplies seem to be shared and those can be handled > correctly with ref counting, separate devices is fine. We do the same > thing for BT/WiFi combo chips with separate host interfaces. > > Reviewed-by: Rob Herring <robh@kernel.org> Seems I'd actually failed to apply this last week, so now applied with the message tweaked and Rob's tag. Thanks to both of you, Jonathan > > Rob
diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt b/Documentation/devicetree/bindings/iio/st-sensors.txt index 6f626f73417e..07f1767c7ee6 100644 --- a/Documentation/devicetree/bindings/iio/st-sensors.txt +++ b/Documentation/devicetree/bindings/iio/st-sensors.txt @@ -67,6 +67,7 @@ Magnetometers: - st,lsm303dlm-magn - st,lis3mdl-magn - st,lis2mdl +- st,lsm9ds1-magn Pressure sensors: - st,lps001wp-press