diff mbox series

[v2,5/6] dt-bindings: media: mt9m111: adapt documentation to be more clear

Message ID 20181029182410.18783-6-m.felsch@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series media: mt9m111 features | expand

Commit Message

Marco Felsch Oct. 29, 2018, 6:24 p.m. UTC
Replace the vague binding by a more verbose. Remove the remote property
from the example since the driver don't support such a property. Also
remove the bus-width property from the endpoint since the driver don't
take care of it.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 .../devicetree/bindings/media/i2c/mt9m111.txt         | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Rob Herring (Arm) Oct. 30, 2018, 10:30 p.m. UTC | #1
On Mon, Oct 29, 2018 at 07:24:09PM +0100, Marco Felsch wrote:
> Replace the vague binding by a more verbose. Remove the remote property
> from the example since the driver don't support such a property. Also
> remove the bus-width property from the endpoint since the driver don't
> take care of it.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../devicetree/bindings/media/i2c/mt9m111.txt         | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> index 6b910036b57e..921cc48c488b 100644
> --- a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
> @@ -9,8 +9,13 @@ Required Properties:
>  - clocks: reference to the master clock.
>  - clock-names: shall be "mclk".
>  
> -For further reading on port node refer to
> -Documentation/devicetree/bindings/media/video-interfaces.txt.
> +The device node must contain one 'port' child node with one 'endpoint' child
> +sub-node for its digital output video port, in accordance with the video
> +interface bindings defined in:
> +Documentation/devicetree/bindings/media/video-interfaces.txt
> +
> +Required endpoint properties:
> +- remote-endpoint: For information see ../video-interfaces.txt.

You don't need to explicitly document this.

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
index 6b910036b57e..921cc48c488b 100644
--- a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
+++ b/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
@@ -9,8 +9,13 @@  Required Properties:
 - clocks: reference to the master clock.
 - clock-names: shall be "mclk".
 
-For further reading on port node refer to
-Documentation/devicetree/bindings/media/video-interfaces.txt.
+The device node must contain one 'port' child node with one 'endpoint' child
+sub-node for its digital output video port, in accordance with the video
+interface bindings defined in:
+Documentation/devicetree/bindings/media/video-interfaces.txt
+
+Required endpoint properties:
+- remote-endpoint: For information see ../video-interfaces.txt.
 
 Example:
 
@@ -21,10 +26,8 @@  Example:
 			clocks = <&mclk>;
 			clock-names = "mclk";
 
-			remote = <&pxa_camera>;
 			port {
 				mt9m111_1: endpoint {
-					bus-width = <8>;
 					remote-endpoint = <&pxa_camera>;
 				};
 			};