| Message ID | d6b6aeda46121f59a53b43599bf0200580d7a79d.1541082656.git.renatogeh@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: ad7780: correct driver read | expand |
On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > This patch removes the unnecessary field int_vref_mv in ad7780_state > referring to the device's voltage. > > Signed-off-by: Renato Lui Geh <renatogeh@gmail.com> > --- > Changes in v3: > - removed unnecessary int_vref_mv from ad7780_state > > drivers/staging/iio/adc/ad7780.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7780.c > b/drivers/staging/iio/adc/ad7780.c > index f2a11e9424cd..f250370efcf7 100644 > --- a/drivers/staging/iio/adc/ad7780.c > +++ b/drivers/staging/iio/adc/ad7780.c > @@ -42,7 +42,6 @@ struct ad7780_state { > struct regulator *reg; > struct gpio_desc *powerdown_gpio; > unsigned int gain; > - u16 int_vref_mv; > > struct ad_sigma_delta sd; > }; > @@ -190,9 +189,7 @@ static int ad7780_probe(struct spi_device *spi) > st->chip_info = > &ad7780_chip_info_tbl[spi_get_device_id(spi)->driver_data]; > > - if (voltage_uv) > - st->int_vref_mv = voltage_uv / 1000; > - else > + if (!voltage_uv) > dev_warn(&spi->dev, "Reference voltage unspecified\n"); I think you could remove this altogether, and also remove the entire `voltage_uv = regulator_get_voltage(st->reg);` assignment. It doesn't make much sense to read the voltage here, since it won't be used in the probe part anymore. > > spi_set_drvdata(spi, indio_dev);
On Thu, 1 Nov 2018 15:28:19 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > > This patch removes the unnecessary field int_vref_mv in ad7780_state > > referring to the device's voltage. > > > > Signed-off-by: Renato Lui Geh <renatogeh@gmail.com> > > --- > > Changes in v3: > > - removed unnecessary int_vref_mv from ad7780_state > > > > drivers/staging/iio/adc/ad7780.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/staging/iio/adc/ad7780.c > > b/drivers/staging/iio/adc/ad7780.c > > index f2a11e9424cd..f250370efcf7 100644 > > --- a/drivers/staging/iio/adc/ad7780.c > > +++ b/drivers/staging/iio/adc/ad7780.c > > @@ -42,7 +42,6 @@ struct ad7780_state { > > struct regulator *reg; > > struct gpio_desc *powerdown_gpio; > > unsigned int gain; > > - u16 int_vref_mv; > > > > struct ad_sigma_delta sd; > > }; > > @@ -190,9 +189,7 @@ static int ad7780_probe(struct spi_device *spi) > > st->chip_info = > > &ad7780_chip_info_tbl[spi_get_device_id(spi)->driver_data]; > > > > - if (voltage_uv) > > - st->int_vref_mv = voltage_uv / 1000; > > - else > > + if (!voltage_uv) > > dev_warn(&spi->dev, "Reference voltage unspecified\n"); > > I think you could remove this altogether, and also remove the entire > `voltage_uv = regulator_get_voltage(st->reg);` assignment. > > It doesn't make much sense to read the voltage here, since it won't be used > in the probe part anymore. > Absolutely agree on this. There is no point in reading here at all. Jonathan > > > > spi_set_drvdata(spi, indio_dev);
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c index f2a11e9424cd..f250370efcf7 100644 --- a/drivers/staging/iio/adc/ad7780.c +++ b/drivers/staging/iio/adc/ad7780.c @@ -42,7 +42,6 @@ struct ad7780_state { struct regulator *reg; struct gpio_desc *powerdown_gpio; unsigned int gain; - u16 int_vref_mv; struct ad_sigma_delta sd; }; @@ -190,9 +189,7 @@ static int ad7780_probe(struct spi_device *spi) st->chip_info = &ad7780_chip_info_tbl[spi_get_device_id(spi)->driver_data]; - if (voltage_uv) - st->int_vref_mv = voltage_uv / 1000; - else + if (!voltage_uv) dev_warn(&spi->dev, "Reference voltage unspecified\n"); spi_set_drvdata(spi, indio_dev);
This patch removes the unnecessary field int_vref_mv in ad7780_state referring to the device's voltage. Signed-off-by: Renato Lui Geh <renatogeh@gmail.com> --- Changes in v3: - removed unnecessary int_vref_mv from ad7780_state drivers/staging/iio/adc/ad7780.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)