| Message ID | 2191be4d531651db39682178ec0660eeb5697439.1541082656.git.renatogeh@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: ad7780: correct driver read | expand |
Good catch. Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > This was fixed by assigning the correct value instead. > > Signed-off-by: Renato Lui Geh <renatogeh@gmail.com> > --- > drivers/staging/iio/adc/ad7780.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/adc/ad7780.c > b/drivers/staging/iio/adc/ad7780.c > index b67412db0318..91e016d534ed 100644 > --- a/drivers/staging/iio/adc/ad7780.c > +++ b/drivers/staging/iio/adc/ad7780.c > @@ -96,7 +96,7 @@ static int ad7780_read_raw(struct iio_dev *indio_dev, > *val2 = chan->scan_type.realbits - 1; > return IIO_VAL_FRACTIONAL_LOG2; > case IIO_CHAN_INFO_OFFSET: > - *val -= (1 << (chan->scan_type.realbits - 1)); > + *val = -(1 << (chan->scan_type.realbits - 1)); > return IIO_VAL_INT; > } >
On Thu, 1 Nov 2018 15:02:32 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > Good catch. > > Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> On the basis this has been broken for a long time, and you are clearly doing other nearby not fix work, I'm going to take this through the togreg tree rather than via the quicker fix path. It makes my life easier :) Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > > On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote: > > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > > This was fixed by assigning the correct value instead. > > > > Signed-off-by: Renato Lui Geh <renatogeh@gmail.com> > > --- > > drivers/staging/iio/adc/ad7780.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/iio/adc/ad7780.c > > b/drivers/staging/iio/adc/ad7780.c > > index b67412db0318..91e016d534ed 100644 > > --- a/drivers/staging/iio/adc/ad7780.c > > +++ b/drivers/staging/iio/adc/ad7780.c > > @@ -96,7 +96,7 @@ static int ad7780_read_raw(struct iio_dev *indio_dev, > > *val2 = chan->scan_type.realbits - 1; > > return IIO_VAL_FRACTIONAL_LOG2; > > case IIO_CHAN_INFO_OFFSET: > > - *val -= (1 << (chan->scan_type.realbits - 1)); > > + *val = -(1 << (chan->scan_type.realbits - 1)); > > return IIO_VAL_INT; > > } > >
Hi, >On Thu, 1 Nov 2018 15:02:32 +0000 >"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > >> Good catch. That was actually Jonathan's catch. :) >> Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> I read up on Acked-by on the kernel docs, as I didn't know exactly what it meant, but I'm not so sure on how to proceed once the patch has been acked. For future patches, do I add this Acked-by line on the patch's message body? Or is this just an informal way of approval? >On the basis this has been broken for a long time, and you are clearly >doing other nearby not fix work, I'm going to take this through the togreg >tree rather than via the quicker fix path. It makes my life >easier :) > >Applied to the togreg branch of iio.git and pushed out as testing for >the autobuilders to play with it. So this means I should skip this patch on v4, right? Thanks, Renato
On Sat, 3 Nov 2018 12:59:16 -0300 Renato Lui Geh <renatogeh@gmail.com> wrote: > Hi, > > >On Thu, 1 Nov 2018 15:02:32 +0000 > >"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > > > >> Good catch. > > That was actually Jonathan's catch. :) > > >> Acked-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > > I read up on Acked-by on the kernel docs, as I didn't know exactly what > it meant, but I'm not so sure on how to proceed once the patch has been > acked. For future patches, do I add this Acked-by line on the patch's > message body? Or is this just an informal way of approval? It's formal. You put the line directly below your Signed-off-by: line if you are resending. If I pick up the patch I paste it in there whilst applying. > > >On the basis this has been broken for a long time, and you are clearly > >doing other nearby not fix work, I'm going to take this through the togreg > >tree rather than via the quicker fix path. It makes my life > >easier :) > > > >Applied to the togreg branch of iio.git and pushed out as testing for > >the autobuilders to play with it. > > So this means I should skip this patch on v4, right? Yes. Already in the tree so don't send it again. Thanks Jonathan > > Thanks, > Renato >
diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c index b67412db0318..91e016d534ed 100644 --- a/drivers/staging/iio/adc/ad7780.c +++ b/drivers/staging/iio/adc/ad7780.c @@ -96,7 +96,7 @@ static int ad7780_read_raw(struct iio_dev *indio_dev, *val2 = chan->scan_type.realbits - 1; return IIO_VAL_FRACTIONAL_LOG2; case IIO_CHAN_INFO_OFFSET: - *val -= (1 << (chan->scan_type.realbits - 1)); + *val = -(1 << (chan->scan_type.realbits - 1)); return IIO_VAL_INT; }
Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. This was fixed by assigning the correct value instead. Signed-off-by: Renato Lui Geh <renatogeh@gmail.com> --- drivers/staging/iio/adc/ad7780.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)