| Message ID | 1541186471-2998-1-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | watchdog: renesas_wdt: Fix typos | expand |
On Fri, Nov 02, 2018 at 07:21:11PM +0000, Fabrizio Castro wrote: Do not use "," but ";" to separate instructions. > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/renesas_wdt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c > index 0d74c3e..b570962 100644 > --- a/drivers/watchdog/renesas_wdt.c > +++ b/drivers/watchdog/renesas_wdt.c > @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev) > goto out_pm_disable; > } > > - priv->wdev.info = &rwdt_ident, > - priv->wdev.ops = &rwdt_ops, > + priv->wdev.info = &rwdt_ident; > + priv->wdev.ops = &rwdt_ops; > priv->wdev.parent = &pdev->dev; > priv->wdev.min_timeout = 1; > priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536); > -- > 2.7.4 >
On Fri, Nov 2, 2018 at 8:48 PM Guenter Roeck <linux@roeck-us.net> wrote: > On Fri, Nov 02, 2018 at 07:21:11PM +0000, Fabrizio Castro wrote: > > Do not use "," but ";" to separate instructions. +1 Thanks, my eyes had a hard time finding out what had been changed ;-) > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > > --- > > drivers/watchdog/renesas_wdt.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c > > index 0d74c3e..b570962 100644 > > --- a/drivers/watchdog/renesas_wdt.c > > +++ b/drivers/watchdog/renesas_wdt.c > > @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev) > > goto out_pm_disable; > > } > > > > - priv->wdev.info = &rwdt_ident, > > - priv->wdev.ops = &rwdt_ops, > > + priv->wdev.info = &rwdt_ident; > > + priv->wdev.ops = &rwdt_ops; > > priv->wdev.parent = &pdev->dev; > > priv->wdev.min_timeout = 1; > > priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536); Gr{oetje,eeting}s, Geert
> Subject: Re: [PATCH] watchdog: renesas_wdt: Fix typos > > On Fri, Nov 02, 2018 at 07:21:11PM +0000, Fabrizio Castro wrote: > > Do not use "," but ";" to separate instructions. I agree, will send a v2 for this. Thanks, Fab > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Reviewed-by: Guenter Roeck <linux@roeck-us.net> > > > --- > > drivers/watchdog/renesas_wdt.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c > > index 0d74c3e..b570962 100644 > > --- a/drivers/watchdog/renesas_wdt.c > > +++ b/drivers/watchdog/renesas_wdt.c > > @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev) > > goto out_pm_disable; > > } > > > > -priv->wdev.info = &rwdt_ident, > > -priv->wdev.ops = &rwdt_ops, > > +priv->wdev.info = &rwdt_ident; > > +priv->wdev.ops = &rwdt_ops; > > priv->wdev.parent = &pdev->dev; > > priv->wdev.min_timeout = 1; > > priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536); > > -- > > 2.7.4 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c index 0d74c3e..b570962 100644 --- a/drivers/watchdog/renesas_wdt.c +++ b/drivers/watchdog/renesas_wdt.c @@ -220,8 +220,8 @@ static int rwdt_probe(struct platform_device *pdev) goto out_pm_disable; } - priv->wdev.info = &rwdt_ident, - priv->wdev.ops = &rwdt_ops, + priv->wdev.info = &rwdt_ident; + priv->wdev.ops = &rwdt_ops; priv->wdev.parent = &pdev->dev; priv->wdev.min_timeout = 1; priv->wdev.max_timeout = DIV_BY_CLKS_PER_SEC(priv, 65536);
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- drivers/watchdog/renesas_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)