| Message ID | 20181105170853.17367-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panel: simple: switch AUO g185han01 typical clock to 135MHz | expand |
Am Montag, den 05.11.2018, 18:08 +0100 schrieb Lucas Stach: > While 144MHz is listed in the datasheet as the typical pixel clock > this leads to a vrefresh rate of 64Fps, which is not what most people > expect. Change this to 135MHz to provide a more common 60Fps refresh > rate. Please ignore this patch. The clock rate is fine, it's just the blanking that is too small due to a confusion of dual/single LVDS in the patch introducing this panel. I'll send a revised patch to fix this. Regards, Lucas > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c > index 97964f7f2ace..2243151c4c34 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -661,7 +661,7 @@ static const struct panel_desc auo_g133han01 = { > }; > > static const struct display_timing auo_g185han01_timings = { > - .pixelclock = { 120000000, 144000000, 175000000 }, > + .pixelclock = { 120000000, 135000000, 175000000 }, > .hactive = { 1920, 1920, 1920 }, > .hfront_porch = { 18, 60, 74 }, > .hback_porch = { 12, 44, 54 },
On Mon, 2018-11-05 at 18:08 +0100, Lucas Stach wrote: > While 144MHz is listed in the datasheet as the typical pixel clock > this leads to a vrefresh rate of 64Fps, which is not what most people > expect. Change this to 135MHz to provide a more common 60Fps refresh > rate. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 97964f7f2ace..2243151c4c34 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -661,7 +661,7 @@ static const struct panel_desc auo_g133han01 = { > }; > > static const struct display_timing auo_g185han01_timings = { > - .pixelclock = { 120000000, 144000000, 175000000 }, > + .pixelclock = { 120000000, 135000000, 175000000 }, > .hactive = { 1920, 1920, 1920 }, > .hfront_porch = { 18, 60, 74 }, > .hback_porch = { 12, 44, 54 }, Looking at the datasheet, the typical horizontal blanking is given as 128 clocks per LVDS channel. Since hactive is doubled for dual-LVDS, the blanking intervals should be doubled as well. With that, (960+128)*2 * (1080+20) * 60 = 143.616 MHz. That would be about 60.16 Hz at 144 MHz. regards Philipp
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 97964f7f2ace..2243151c4c34 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -661,7 +661,7 @@ static const struct panel_desc auo_g133han01 = { }; static const struct display_timing auo_g185han01_timings = { - .pixelclock = { 120000000, 144000000, 175000000 }, + .pixelclock = { 120000000, 135000000, 175000000 }, .hactive = { 1920, 1920, 1920 }, .hfront_porch = { 18, 60, 74 }, .hback_porch = { 12, 44, 54 },
While 144MHz is listed in the datasheet as the typical pixel clock this leads to a vrefresh rate of 64Fps, which is not what most people expect. Change this to 135MHz to provide a more common 60Fps refresh rate. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)