| Message ID | 154145234526.29224.2575533246153120029.stgit@ahduyck-desk1.jf.intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add NUMA aware async_schedule calls | expand |
On Mon, 2018-11-05 at 13:12 -0800, Alexander Duyck wrote: > This patch is meant to force the device registration for nvdimm devices to > be closer to the actual device. This is achieved by using either the NUMA > node ID of the region, or of the parent. By doing this we can have > everything above the region based on the region, and everything below the > region based on the nvdimm bus. > > By guaranteeing NUMA locality I see an improvement of as high as 25% for > per-node init of a system with 12TB of persistent memory. Thank you for having included the performance numbers. Reviewed-by: Bart Van Assche <bvanassche@acm.org>
diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c index f1fb39921236..b1e193541874 100644 --- a/drivers/nvdimm/bus.c +++ b/drivers/nvdimm/bus.c @@ -23,6 +23,7 @@ #include <linux/ndctl.h> #include <linux/sched.h> #include <linux/slab.h> +#include <linux/cpu.h> #include <linux/fs.h> #include <linux/io.h> #include <linux/mm.h> @@ -513,11 +514,15 @@ void __nd_device_register(struct device *dev) set_dev_node(dev, to_nd_region(dev)->numa_node); dev->bus = &nvdimm_bus_type; - if (dev->parent) + if (dev->parent) { get_device(dev->parent); + if (dev_to_node(dev) == NUMA_NO_NODE) + set_dev_node(dev, dev_to_node(dev->parent)); + } get_device(dev); - async_schedule_domain(nd_async_device_register, dev, - &nd_async_domain); + + async_schedule_dev_domain(nd_async_device_register, dev, + &nd_async_domain); } void nd_device_register(struct device *dev)
This patch is meant to force the device registration for nvdimm devices to be closer to the actual device. This is achieved by using either the NUMA node ID of the region, or of the parent. By doing this we can have everything above the region based on the region, and everything below the region based on the nvdimm bus. By guaranteeing NUMA locality I see an improvement of as high as 25% for per-node init of a system with 12TB of persistent memory. Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com> --- drivers/nvdimm/bus.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)