diff mbox series

arm64: fix commit style in the comments

Message ID 1541605151-6757-1-git-send-email-peng.hao2@zte.com.cn (mailing list archive)
State New, archived
Headers show
Series arm64: fix commit style in the comments | expand

Commit Message

Peng Hao Nov. 7, 2018, 3:39 p.m. UTC
Use git commit description style 'commit <12+ chars of sha1>
("<title line>")' in the comments.

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 arch/arm64/kernel/sys32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Catalin Marinas Nov. 7, 2018, 9:18 a.m. UTC | #1
On Wed, Nov 07, 2018 at 11:39:11PM +0800, Peng Hao wrote:
> Use git commit description style 'commit <12+ chars of sha1>
> ("<title line>")' in the comments.
> 
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>  arch/arm64/kernel/sys32.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/sys32.c b/arch/arm64/kernel/sys32.c
> index 0f8bcb7..8317a5a 100644
> --- a/arch/arm64/kernel/sys32.c
> +++ b/arch/arm64/kernel/sys32.c
> @@ -40,8 +40,8 @@
>  	 * arbitrary binaries may rely upon it, so we must do the same.
>  	 * For more details, see commit:
>  	 *
> -	 * 713c481519f19df9 ("[ARM] 3108/2: old ABI compat: statfs64 and
> -	 * fstatfs64")
> +	 * commit 713c481519f19df9 ("[ARM] 3108/2: old ABI compat: statfs64
> +	 * and fstatfs64")

Seriously, how does this help? It already states "see commit:" on the
previous line.
diff mbox series

Patch

diff --git a/arch/arm64/kernel/sys32.c b/arch/arm64/kernel/sys32.c
index 0f8bcb7..8317a5a 100644
--- a/arch/arm64/kernel/sys32.c
+++ b/arch/arm64/kernel/sys32.c
@@ -40,8 +40,8 @@ 
 	 * arbitrary binaries may rely upon it, so we must do the same.
 	 * For more details, see commit:
 	 *
-	 * 713c481519f19df9 ("[ARM] 3108/2: old ABI compat: statfs64 and
-	 * fstatfs64")
+	 * commit 713c481519f19df9 ("[ARM] 3108/2: old ABI compat: statfs64
+	 * and fstatfs64")
 	 */
 	if (sz == 88)
 		sz = 84;