| Message ID | 20181107154708.422-1-heiko@sntech.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dt-bindings: hwmon: tmp108: add optional interrupts and #thermal-sensor-cells | expand |
Hi, On Wed, Nov 07, 2018 at 04:47:08PM +0100, Heiko Stuebner wrote: > From: Heiko Stuebner <heiko.stuebner@bq.com> > > The tmp108 does have an alert output that can be used as interrupt source > and can of course also be used as part of a thermal sensor setup for things > like thermal-based cpu frequencies, so document the necessary properties. > > Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com> Do you also plan to actually implement interrupt support in the driver ? Guenter > --- > Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt > index 8c4b10df86d9..54d4beed4ee5 100644 > --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt > +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt > @@ -7,6 +7,10 @@ Requires node properties: > - compatible : "ti,tmp108" > - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. > > +Optional properties: > +- interrupts: Reference to the TMP108 alert interrupt. > +- #thermal-sensor-cells: should be set to 0. > + > Example: > tmp108@48 { > compatible = "ti,tmp108"; > -- > 2.18.0 >
Hi Guenter, Am Mittwoch, 7. November 2018, 19:39:58 CET schrieb Guenter Roeck: > On Wed, Nov 07, 2018 at 04:47:08PM +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@bq.com> > > > > The tmp108 does have an alert output that can be used as interrupt source > > and can of course also be used as part of a thermal sensor setup for > > things > > like thermal-based cpu frequencies, so document the necessary properties. > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com> > > Do you also plan to actually implement interrupt support in the driver ? Not right now but I'm hoping down the road. The main argument for including this standard property is that the dt-binding is of course a description of the hardware and not the state of the linux driver and the tmp108 obviously has that alert output pin, hence I'd really like to already have it in the new board-dts I'm currently working on so it simply magically works once the driver can use it :-) . Heiko > > --- > > > > Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt > > b/Documentation/devicetree/bindings/hwmon/tmp108.txt index > > 8c4b10df86d9..54d4beed4ee5 100644 > > --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt > > +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt > > > > @@ -7,6 +7,10 @@ Requires node properties: > > - compatible : "ti,tmp108" > > - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. > > > > +Optional properties: > > +- interrupts: Reference to the TMP108 alert interrupt. > > +- #thermal-sensor-cells: should be set to 0. > > + > > > > Example: > > tmp108@48 { > > > > compatible = "ti,tmp108";
On Wed, Nov 07, 2018 at 10:33:12PM +0100, Heiko Stübner wrote: > Hi Guenter, > > Am Mittwoch, 7. November 2018, 19:39:58 CET schrieb Guenter Roeck: > > On Wed, Nov 07, 2018 at 04:47:08PM +0100, Heiko Stuebner wrote: > > > From: Heiko Stuebner <heiko.stuebner@bq.com> > > > > > > The tmp108 does have an alert output that can be used as interrupt source > > > and can of course also be used as part of a thermal sensor setup for > > > things > > > like thermal-based cpu frequencies, so document the necessary properties. > > > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com> > > > > Do you also plan to actually implement interrupt support in the driver ? > > Not right now but I'm hoping down the road. > > The main argument for including this standard property is that > the dt-binding is of course a description of the hardware and not the > state of the linux driver and the tmp108 obviously has that alert output > pin, hence I'd really like to already have it in the new board-dts I'm > currently working on so it simply magically works once the driver can > use it :-) . > NP, just asking. Let's wait for Rob's review, then I'll apply the patch unless he has issues. Thanks, Guenter > > Heiko > > > > --- > > > > > > Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt > > > b/Documentation/devicetree/bindings/hwmon/tmp108.txt index > > > 8c4b10df86d9..54d4beed4ee5 100644 > > > --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt > > > +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt > > > > > > @@ -7,6 +7,10 @@ Requires node properties: > > > - compatible : "ti,tmp108" > > > - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. > > > > > > +Optional properties: > > > +- interrupts: Reference to the TMP108 alert interrupt. > > > +- #thermal-sensor-cells: should be set to 0. > > > + > > > > > > Example: > > > tmp108@48 { > > > > > > compatible = "ti,tmp108"; > > > >
On Mon, Nov 12, 2018 at 05:37:46PM -0600, Rob Herring wrote: > On Wed, 7 Nov 2018 16:47:08 +0100, Heiko Stuebner wrote: > > From: Heiko Stuebner <heiko.stuebner@bq.com> > > > > The tmp108 does have an alert output that can be used as interrupt source > > and can of course also be used as part of a thermal sensor setup for things > > like thermal-based cpu frequencies, so document the necessary properties. > > > > Signed-off-by: Heiko Stuebner <heiko.stuebner@bq.com> > > --- > > Documentation/devicetree/bindings/hwmon/tmp108.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > Reviewed-by: Rob Herring <robh@kernel.org> > Applied to hwmon-next. Thanks, Guenter
diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt index 8c4b10df86d9..54d4beed4ee5 100644 --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt +++ b/Documentation/devicetree/bindings/hwmon/tmp108.txt @@ -7,6 +7,10 @@ Requires node properties: - compatible : "ti,tmp108" - reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b. +Optional properties: +- interrupts: Reference to the TMP108 alert interrupt. +- #thermal-sensor-cells: should be set to 0. + Example: tmp108@48 { compatible = "ti,tmp108";