| Message ID | 20181011072135.588-1-famz@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | file-posix: Simplifications on image locking | expand |
On Thu, 10/11 15:21, Fam Zheng wrote: > v5: Address Max's comments (Thanks for reviewing): > - Clean up after test done. > - Add rev-by to patch 1 and 2. Ping? Fam
Am 11.10.2018 um 09:21 hat Fam Zheng geschrieben: > v5: Address Max's comments (Thanks for reviewing): > - Clean up after test done. > - Add rev-by to patch 1 and 2. > > v4: Fix test on systems without OFD. [Patchew] > > The first patch reduces chances of QEMU crash in unusual (but not unlikely) > cases especially when used by Libvirt (see commit message). > > The second patch halves fd for images. > > The third adds some more test for patch one (would have caught the regression > caused by v2). Thanks, applied to the block branch. Kevin
v5: Address Max's comments (Thanks for reviewing): - Clean up after test done. - Add rev-by to patch 1 and 2. v4: Fix test on systems without OFD. [Patchew] The first patch reduces chances of QEMU crash in unusual (but not unlikely) cases especially when used by Libvirt (see commit message). The second patch halves fd for images. The third adds some more test for patch one (would have caught the regression caused by v2). Fam Zheng (3): file-posix: Skip effectiveless OFD lock operations file-posix: Drop s->lock_fd tests: Add unit tests for image locking block/file-posix.c | 83 +++++++++++++------- tests/Makefile.include | 2 + tests/test-image-locking.c | 157 +++++++++++++++++++++++++++++++++++++ 3 files changed, 212 insertions(+), 30 deletions(-) create mode 100644 tests/test-image-locking.c