[net-next,0/4] Remove VLAN_TAG_PRESENT from drivers

Message

Michał Mirosław Nov. 8, 2018, 5:44 p.m. UTC

This series removes VLAN_TAG_PRESENT use from network drivers in
preparation to removing its special meaning.

Michał Mirosław (4):
  i40iw: remove use of VLAN_TAG_PRESENT
  cnic: remove use of VLAN_TAG_PRESENT
  gianfar: remove use of VLAN_TAG_PRESENT
  OVS: remove use of VLAN_TAG_PRESENT

 drivers/infiniband/hw/i40iw/i40iw_cm.c        |  8 +++----
 drivers/net/ethernet/broadcom/cnic.c          |  2 +-
 .../net/ethernet/freescale/gianfar_ethtool.c  |  8 +++----
 net/openvswitch/actions.c                     | 13 +++++++----
 net/openvswitch/flow.c                        |  4 ++--
 net/openvswitch/flow.h                        |  2 +-
 net/openvswitch/flow_netlink.c                | 22 +++++++++----------
 7 files changed, 31 insertions(+), 28 deletions(-)

Comments

Leon Romanovsky Nov. 8, 2018, 6:50 p.m. UTC | #1

On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote:
> This series removes VLAN_TAG_PRESENT use from network drivers in
> preparation to removing its special meaning.

Can you please give an extra explanation why it is removed?
Such series come out-of-blue, for people who are not following
netdev mailing list closely (drivers/infiniband/*).

Thanks

>
> Michał Mirosław (4):
>   i40iw: remove use of VLAN_TAG_PRESENT
>   cnic: remove use of VLAN_TAG_PRESENT
>   gianfar: remove use of VLAN_TAG_PRESENT
>   OVS: remove use of VLAN_TAG_PRESENT
>
>  drivers/infiniband/hw/i40iw/i40iw_cm.c        |  8 +++----
>  drivers/net/ethernet/broadcom/cnic.c          |  2 +-
>  .../net/ethernet/freescale/gianfar_ethtool.c  |  8 +++----
>  net/openvswitch/actions.c                     | 13 +++++++----
>  net/openvswitch/flow.c                        |  4 ++--
>  net/openvswitch/flow.h                        |  2 +-
>  net/openvswitch/flow_netlink.c                | 22 +++++++++----------
>  7 files changed, 31 insertions(+), 28 deletions(-)
>
> --
> 2.19.1
>

Michał Mirosław Nov. 8, 2018, 10:11 p.m. UTC | #2

On Thu, Nov 08, 2018 at 08:50:05PM +0200, Leon Romanovsky wrote:
> On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote:
> > This series removes VLAN_TAG_PRESENT use from network drivers in
> > preparation to removing its special meaning.
> Can you please give an extra explanation why it is removed?
> Such series come out-of-blue, for people who are not following
> netdev mailing list closely (drivers/infiniband/*).

This is one of the steps to remove VLAN_TAG_PRESENT overlap with CFI/DEI
bit of VLAN tag. Currently this overlap causes Linux kernel to always
clear CFI/DEI in packets.

There is skb_vlan_tag_present() that drivers should use to check if
the tag in skb is valid.

Best Regards,
Michał Mirosław

David Miller Nov. 9, 2018, 3:49 a.m. UTC | #3

From: Michał Mirosław <[e-mail]>
Date: Thu, 08 Nov 2018 18:44:46 +0100

> This series removes VLAN_TAG_PRESENT use from network drivers in
> preparation to removing its special meaning.

Series applied, thank you.

Shiraz Saleem Nov. 9, 2018, 9:58 p.m. UTC | #4

On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote:
> This series removes VLAN_TAG_PRESENT use from network drivers in
> preparation to removing its special meaning.
> 
> Michał Mirosław (4):
>   i40iw: remove use of VLAN_TAG_PRESENT
>   cnic: remove use of VLAN_TAG_PRESENT
>   gianfar: remove use of VLAN_TAG_PRESENT
>   OVS: remove use of VLAN_TAG_PRESENT
> 
>  drivers/infiniband/hw/i40iw/i40iw_cm.c        |  8 +++----
>

i40iw bit looks fine. Thanks!

Acked-by: Shiraz Saleem <[e-mail]>