mbox series

[0/4] crypto: crypto_user reporting fixes and cleanups

Message ID 20181103215603.16250-1-ebiggers@kernel.org (mailing list archive)
Headers show
Series crypto: crypto_user reporting fixes and cleanups | expand

Message

Eric Biggers Nov. 3, 2018, 9:55 p.m. UTC
This series fixes all the information leaks in crypto_user reporting,
removes some redundant reporting functions, and makes some changes to
reduce the chance of similar information leaks in the future.  Patch 2
is based on a patch already sent by Corentin Labbe, but it was
incomplete so I fixed it.

Corentin Labbe (1):
  crypto: crypto_user_stat - Zeroize whole structure given to user space

Eric Biggers (3):
  crypto: crypto_user - fix leaking uninitialized memory to userspace
  crypto: crypto_user - remove redundant reporting functions
  crypto: crypto_user - clean up report structure copying

 crypto/ablkcipher.c       |  32 ++++------
 crypto/acompress.c        |  10 +---
 crypto/aead.c             |  14 ++---
 crypto/ahash.c            |  12 ++--
 crypto/akcipher.c         |  11 ++--
 crypto/blkcipher.c        |  16 ++---
 crypto/crypto_user_base.c |  95 +++++------------------------
 crypto/crypto_user_stat.c | 123 ++++++++++++++------------------------
 crypto/kpp.c              |  10 +---
 crypto/rng.c              |  12 ++--
 crypto/scompress.c        |  11 ++--
 crypto/shash.c            |  12 ++--
 crypto/skcipher.c         |  15 ++---
 13 files changed, 116 insertions(+), 257 deletions(-)

Comments

Herbert Xu Nov. 9, 2018, 9:46 a.m. UTC | #1
On Sat, Nov 03, 2018 at 02:55:59PM -0700, Eric Biggers wrote:
> This series fixes all the information leaks in crypto_user reporting,
> removes some redundant reporting functions, and makes some changes to
> reduce the chance of similar information leaks in the future.  Patch 2
> is based on a patch already sent by Corentin Labbe, but it was
> incomplete so I fixed it.
> 
> Corentin Labbe (1):
>   crypto: crypto_user_stat - Zeroize whole structure given to user space
> 
> Eric Biggers (3):
>   crypto: crypto_user - fix leaking uninitialized memory to userspace
>   crypto: crypto_user - remove redundant reporting functions
>   crypto: crypto_user - clean up report structure copying
> 
>  crypto/ablkcipher.c       |  32 ++++------
>  crypto/acompress.c        |  10 +---
>  crypto/aead.c             |  14 ++---
>  crypto/ahash.c            |  12 ++--
>  crypto/akcipher.c         |  11 ++--
>  crypto/blkcipher.c        |  16 ++---
>  crypto/crypto_user_base.c |  95 +++++------------------------
>  crypto/crypto_user_stat.c | 123 ++++++++++++++------------------------
>  crypto/kpp.c              |  10 +---
>  crypto/rng.c              |  12 ++--
>  crypto/scompress.c        |  11 ++--
>  crypto/shash.c            |  12 ++--
>  crypto/skcipher.c         |  15 ++---
>  13 files changed, 116 insertions(+), 257 deletions(-)

All applied.  Patches 1-2 went into crypto and 3-4 are in cryptodev.

Thanks,