diff mbox series

ARM: dts: pxa3xx: add gcu node

Message ID 20181105191827.3860-1-daniel@zonque.org (mailing list archive)
State New, archived
Headers show
Series ARM: dts: pxa3xx: add gcu node | expand

Commit Message

Daniel Mack Nov. 5, 2018, 7:18 p.m. UTC
Add a device node for hardware graphic acceleration.

Signed-off-by: Daniel Mack <daniel@zonque.org>
---
 arch/arm/boot/dts/pxa3xx.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Robert Jarzmik Nov. 10, 2018, 8:43 p.m. UTC | #1
Daniel Mack <daniel@zonque.org> writes:

> Add a device node for hardware graphic acceleration.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
Hi Daniel,

> +	gcu: display-controller@54000000 {
> +		compatible = "marvell,pxa300-gcu";
Isn't every IP devicetree entry supposed to have a documentation in
Documentation/devicetree going along a definition in the .dtsi files ?

Cheers.
Daniel Mack Nov. 14, 2018, 7:58 p.m. UTC | #2
Hi Robert,

On 10/11/2018 9:43 PM, Robert Jarzmik wrote:
> Daniel Mack <daniel@zonque.org> writes:
> 
>> Add a device node for hardware graphic acceleration.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
> Hi Daniel,
> 
>> +	gcu: display-controller@54000000 {
>> +		compatible = "marvell,pxa300-gcu";
> Isn't every IP devicetree entry supposed to have a documentation in
> Documentation/devicetree going along a definition in the .dtsi files ?

Ah, that's already there, see cf925575d292b.

I did that when I taught the driver DT probing.


Thanks,
Daniel
Robert Jarzmik Nov. 17, 2018, 8:11 p.m. UTC | #3
Daniel Mack <daniel@zonque.org> writes:

> Ah, that's already there, see cf925575d292b.
Applied to pxa/dt, thanks.

Cheers.
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/pxa3xx.dtsi b/arch/arm/boot/dts/pxa3xx.dtsi
index 3a8f0edc3af9..264f681bebd9 100644
--- a/arch/arm/boot/dts/pxa3xx.dtsi
+++ b/arch/arm/boot/dts/pxa3xx.dtsi
@@ -300,4 +300,12 @@ 
 		clocks = <&clks CLK_OSTIMER>;
 		status = "okay";
 	};
+
+	gcu: display-controller@54000000 {
+		compatible = "marvell,pxa300-gcu";
+		reg = <0x54000000 0x1000>;
+		interrupts = <39>;
+		clocks = <&clks CLK_PXA300_GCU>;
+		status = "disabled";
+	};
 };