| Message ID | 1541648845-194984-2-git-send-email-chi-hsien.lin@cypress.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | brcmfmac: p2p/miracast/apsta fixes | expand |
On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote: > From: Wright Feng <wright.feng@cypress.com> > > APSTA can work on two band concurrently with using VSDB(Virtual > Simultaneous Dual-Band) or RSDB(Real Simultaneous Dual-Band) features. > In this case, we have to keep apsta is 1 in firmware side. However, if > we start wpa_supplicant on wlan0 and then start hostapd on wlan 1, the > apsta will be set to 0, and we will see data stall on wlan0(station) > So that, we only set apsta to 1 when AP start on primary interface. The description makes my head spin. From reading the commit message I think the code should add a !VSDB check instead of dropping the !RSDB check. Would you agree? Regards, Arend > Signed-off-by: Wright Feng <wright.feng@cypress.com> > Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-)
On 2018/11/9 下午 08:48, Arend van Spriel wrote: > On 11/8/2018 4:48 AM, Chi-Hsien Lin wrote: >> From: Wright Feng <wright.feng@cypress.com> >> >> APSTA can work on two band concurrently with using VSDB(Virtual >> Simultaneous Dual-Band) or RSDB(Real Simultaneous Dual-Band) features. >> In this case, we have to keep apsta is 1 in firmware side. However, if >> we start wpa_supplicant on wlan0 and then start hostapd on wlan 1, the >> apsta will be set to 0, and we will see data stall on wlan0(station) >> So that, we only set apsta to 1 when AP start on primary interface. > > The description makes my head spin. From reading the commit message I > think the code should add a !VSDB check instead of dropping the !RSDB > check. Would you agree? > > Regards, > Arend I will revise the commit message as below and add two checks (!MCHAN and !RSDB)in v2. Let me know if you have concern about that. When starting station mode on wlan0 and AP mode on wlan1, the apsta will be disabled and cause data stall on wlan0(station) The apsta feature with MCHAN(Multi-Channel Concurrent) or RSDB(Real Simultaneous Dual-Band) can make STA+AP work on two bands concurrently. Because of that, we keep apsta enabled if firmware supports MCHAN or RSDB features. - Wright > >> Signed-off-by: Wright Feng <wright.feng@cypress.com> >> Signed-off-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c index 230a378c26fc..165ab1a3f943 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c @@ -4513,9 +4513,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wiphy, struct net_device *ndev, } } - if ((dev_role == NL80211_IFTYPE_AP) && - ((ifp->ifidx == 0) || - !brcmf_feat_is_enabled(ifp, BRCMF_FEAT_RSDB))) { + if (dev_role == NL80211_IFTYPE_AP && ifp->ifidx == 0) { err = brcmf_fil_cmd_int_set(ifp, BRCMF_C_DOWN, 1); if (err < 0) { brcmf_err("BRCMF_C_DOWN error %d\n", err);