mbox series

[0/2] avoid unsigned long for timestamps

Message ID 20181112084031.11769-1-carenas@gmail.com (mailing list archive)
Headers show
Series avoid unsigned long for timestamps | expand

Message

Carlo Marcelo Arenas Belón Nov. 12, 2018, 8:40 a.m. UTC 
specially problematic in Windows where unsigned long is only 32bit wide
and therefore the assumption that a time_t would fit will lead to loss
of precision in a 64bit OS.

 builtin/commit.c | 4 ++--
 read-cache.c     | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

Comments

Johannes Schindelin Nov. 12, 2018, 12:06 p.m. UTC | #1 
Hi Carlo,

On Mon, 12 Nov 2018, Carlo Marcelo Arenas Belón wrote:

> specially problematic in Windows where unsigned long is only 32bit wide
> and therefore the assumption that a time_t would fit will lead to loss
> of precision in a 64bit OS.

Both patches look correct to me.

Thanks!
Dscho

> 
>  builtin/commit.c | 4 ++--
>  read-cache.c     | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> 
>