| Message ID | 20181113063122.13950-1-honli@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] opensm/osm_ucast_mgr.h: Add comment for field 'max_lid' of osm_ucast_mgr_t | expand |
On 11/13/2018 1:31 AM, Honggang LI wrote: > From: Honggang Li <honli@redhat.com> > > Also, adjust the order of comment of field 'is_dor' > > Signed-off-by: Honggang Li <honli@redhat.com> > --- > include/opensm/osm_ucast_mgr.h | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/include/opensm/osm_ucast_mgr.h b/include/opensm/osm_ucast_mgr.h > index b9c1ca12..475e2328 100644 > --- a/include/opensm/osm_ucast_mgr.h > +++ b/include/opensm/osm_ucast_mgr.h > @@ -116,12 +116,15 @@ typedef struct osm_ucast_mgr { > * p_lock > * Pointer to the serializing lock. > * > -* is_dor > -* Dimension Order Routing (DOR) will be done > +* max_lid > +* Max LID that is accessible of the Unicast Manager structure It's the max LID of all the switches in the subnet. > * > * port_order_list > * List of ports ordered for routing. > * > +* is_dor > +* Dimension Order Routing (DOR) will be done > +* > * some_hop_count_set > * Initialized to FALSE at the beginning of each the min hop > * tables calculation iteration cycle, set to TRUE to indicate Thanks. Applied (with change noted above). -- Hal
On Tue, Nov 13, 2018 at 07:42:42AM -0500, Hal Rosenstock wrote: > On 11/13/2018 1:31 AM, Honggang LI wrote: > > From: Honggang Li <honli@redhat.com> > > > > Also, adjust the order of comment of field 'is_dor' > > > > Signed-off-by: Honggang Li <honli@redhat.com> > > --- > > include/opensm/osm_ucast_mgr.h | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/include/opensm/osm_ucast_mgr.h b/include/opensm/osm_ucast_mgr.h > > index b9c1ca12..475e2328 100644 > > --- a/include/opensm/osm_ucast_mgr.h > > +++ b/include/opensm/osm_ucast_mgr.h > > @@ -116,12 +116,15 @@ typedef struct osm_ucast_mgr { > > * p_lock > > * Pointer to the serializing lock. > > * > > -* is_dor > > -* Dimension Order Routing (DOR) will be done > > +* max_lid > > +* Max LID that is accessible of the Unicast Manager structure > > It's the max LID of all the switches in the subnet. Make sense, as opensm will iterate over all switches. > > > * > > * port_order_list > > * List of ports ordered for routing. > > * > > +* is_dor > > +* Dimension Order Routing (DOR) will be done > > +* > > * some_hop_count_set > > * Initialized to FALSE at the beginning of each the min hop > > * tables calculation iteration cycle, set to TRUE to indicate > > Thanks. Applied (with change noted above). unfortunately, the applied patch has a typo in the new title. field --> foeld > > -- Hal
On 11/13/2018 1:40 PM, Honggang LI wrote: > On Tue, Nov 13, 2018 at 07:42:42AM -0500, Hal Rosenstock wrote: >> On 11/13/2018 1:31 AM, Honggang LI wrote: >>> From: Honggang Li <honli@redhat.com> >>> >>> Also, adjust the order of comment of field 'is_dor' >>> >>> Signed-off-by: Honggang Li <honli@redhat.com> >>> --- >>> include/opensm/osm_ucast_mgr.h | 7 +++++-- >>> 1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/include/opensm/osm_ucast_mgr.h b/include/opensm/osm_ucast_mgr.h >>> index b9c1ca12..475e2328 100644 >>> --- a/include/opensm/osm_ucast_mgr.h >>> +++ b/include/opensm/osm_ucast_mgr.h >>> @@ -116,12 +116,15 @@ typedef struct osm_ucast_mgr { >>> * p_lock >>> * Pointer to the serializing lock. >>> * >>> -* is_dor >>> -* Dimension Order Routing (DOR) will be done >>> +* max_lid >>> +* Max LID that is accessible of the Unicast Manager structure >> >> It's the max LID of all the switches in the subnet. > > Make sense, as opensm will iterate over all switches. > >> >>> * >>> * port_order_list >>> * List of ports ordered for routing. >>> * >>> +* is_dor >>> +* Dimension Order Routing (DOR) will be done >>> +* >>> * some_hop_count_set >>> * Initialized to FALSE at the beginning of each the min hop >>> * tables calculation iteration cycle, set to TRUE to indicate >> >> Thanks. Applied (with change noted above). > > unfortunately, the applied patch has a typo in the new title. > > field --> foeld I noticed that after I had already pushed it and can't easily fix already pushed commits as this would affect anyone who's already pulled this. We can live with this typo (as we do with others). >> >> -- Hal >
diff --git a/include/opensm/osm_ucast_mgr.h b/include/opensm/osm_ucast_mgr.h index b9c1ca12..475e2328 100644 --- a/include/opensm/osm_ucast_mgr.h +++ b/include/opensm/osm_ucast_mgr.h @@ -116,12 +116,15 @@ typedef struct osm_ucast_mgr { * p_lock * Pointer to the serializing lock. * -* is_dor -* Dimension Order Routing (DOR) will be done +* max_lid +* Max LID that is accessible of the Unicast Manager structure * * port_order_list * List of ports ordered for routing. * +* is_dor +* Dimension Order Routing (DOR) will be done +* * some_hop_count_set * Initialized to FALSE at the beginning of each the min hop * tables calculation iteration cycle, set to TRUE to indicate