| Message ID | 1542124216-102420-3-git-send-email-vadimp@mellanox.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | platform/x86: Mellanox: add new features and bug fix | expand |
On Tue, Nov 13, 2018 at 3:55 PM Vadim Pasternak <vadimp@mellanox.com> wrote: > > Rename product names for next generation systems QMB7, SN37, SN34 to > respectively MQMB7, MSN37, MSN34. > Wait, do we have the old names still present in the wild? > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > --- > drivers/platform/x86/mlx-platform.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c > index 63edab5..cdf4498 100644 > --- a/drivers/platform/x86/mlx-platform.c > +++ b/drivers/platform/x86/mlx-platform.c > @@ -1508,21 +1508,21 @@ static const struct dmi_system_id mlxplat_dmi_table[] __initconst = { > .callback = mlxplat_dmi_qmb7xx_matched, > .matches = { > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > - DMI_MATCH(DMI_PRODUCT_NAME, "QMB7"), > + DMI_MATCH(DMI_PRODUCT_NAME, "MQM87"), > }, > }, > { > .callback = mlxplat_dmi_qmb7xx_matched, > .matches = { > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > - DMI_MATCH(DMI_PRODUCT_NAME, "SN37"), > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN37"), > }, > }, > { > .callback = mlxplat_dmi_qmb7xx_matched, > .matches = { > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > - DMI_MATCH(DMI_PRODUCT_NAME, "SN34"), > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN34"), > }, > }, > { > -- > 2.1.4 >
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Tuesday, November 13, 2018 5:20 PM > To: Vadim Pasternak <vadimp@mellanox.com> > Cc: Darren Hart <dvhart@infradead.org>; Platform Driver <platform-driver- > x86@vger.kernel.org>; Jiří Pírko <jiri@resnulli.us>; Michael Shych > <michaelsh@mellanox.com> > Subject: Re: [PATCH platform-next v1 2/7] platform/x86: mlx-platform: Rename > new systems product names > > On Tue, Nov 13, 2018 at 3:55 PM Vadim Pasternak <vadimp@mellanox.com> > wrote: > > > > Rename product names for next generation systems QMB7, SN37, SN34 to > > respectively MQMB7, MSN37, MSN34. > > > > Wait, do we have the old names still present in the wild? Hi Andy, No. These systems are about to be released to the customers. So, no one have a systems with the old names. The names have been changed due to marketing decision (symbol 'M" at the beginning). > > > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > > --- > > drivers/platform/x86/mlx-platform.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/platform/x86/mlx-platform.c > > b/drivers/platform/x86/mlx-platform.c > > index 63edab5..cdf4498 100644 > > --- a/drivers/platform/x86/mlx-platform.c > > +++ b/drivers/platform/x86/mlx-platform.c > > @@ -1508,21 +1508,21 @@ static const struct dmi_system_id > mlxplat_dmi_table[] __initconst = { > > .callback = mlxplat_dmi_qmb7xx_matched, > > .matches = { > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > > - DMI_MATCH(DMI_PRODUCT_NAME, "QMB7"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "MQM87"), > > }, > > }, > > { > > .callback = mlxplat_dmi_qmb7xx_matched, > > .matches = { > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > > - DMI_MATCH(DMI_PRODUCT_NAME, "SN37"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN37"), > > }, > > }, > > { > > .callback = mlxplat_dmi_qmb7xx_matched, > > .matches = { > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > > - DMI_MATCH(DMI_PRODUCT_NAME, "SN34"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN34"), > > }, > > }, > > { > > -- > > 2.1.4 > > > > > -- > With Best Regards, > Andy Shevchenko
On Tue, Nov 13, 2018 at 5:23 PM Vadim Pasternak <vadimp@mellanox.com> wrote: > > > > > -----Original Message----- > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > Sent: Tuesday, November 13, 2018 5:20 PM > > To: Vadim Pasternak <vadimp@mellanox.com> > > Cc: Darren Hart <dvhart@infradead.org>; Platform Driver <platform-driver- > > x86@vger.kernel.org>; Jiří Pírko <jiri@resnulli.us>; Michael Shych > > <michaelsh@mellanox.com> > > Subject: Re: [PATCH platform-next v1 2/7] platform/x86: mlx-platform: Rename > > new systems product names > > > > On Tue, Nov 13, 2018 at 3:55 PM Vadim Pasternak <vadimp@mellanox.com> > > wrote: > > > > > > Rename product names for next generation systems QMB7, SN37, SN34 to > > > respectively MQMB7, MSN37, MSN34. > > > > > > > Wait, do we have the old names still present in the wild? > > Hi Andy, > > No. These systems are about to be released to the customers. > So, no one have a systems with the old names. > > The names have been changed due to marketing decision > (symbol 'M" at the beginning). This needs to be elaborated in the commit message. > > > > > > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > > > --- > > > drivers/platform/x86/mlx-platform.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/platform/x86/mlx-platform.c > > > b/drivers/platform/x86/mlx-platform.c > > > index 63edab5..cdf4498 100644 > > > --- a/drivers/platform/x86/mlx-platform.c > > > +++ b/drivers/platform/x86/mlx-platform.c > > > @@ -1508,21 +1508,21 @@ static const struct dmi_system_id > > mlxplat_dmi_table[] __initconst = { > > > .callback = mlxplat_dmi_qmb7xx_matched, > > > .matches = { > > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > > > - DMI_MATCH(DMI_PRODUCT_NAME, "QMB7"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "MQM87"), > > > }, > > > }, > > > { > > > .callback = mlxplat_dmi_qmb7xx_matched, > > > .matches = { > > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > > > - DMI_MATCH(DMI_PRODUCT_NAME, "SN37"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN37"), > > > }, > > > }, > > > { > > > .callback = mlxplat_dmi_qmb7xx_matched, > > > .matches = { > > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), > > > - DMI_MATCH(DMI_PRODUCT_NAME, "SN34"), > > > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN34"), > > > }, > > > }, > > > { > > > -- > > > 2.1.4 > > > > > > > > > -- > > With Best Regards, > > Andy Shevchenko
> -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: Tuesday, November 13, 2018 5:25 PM > To: Vadim Pasternak <vadimp@mellanox.com> > Cc: Darren Hart <dvhart@infradead.org>; Platform Driver <platform-driver- > x86@vger.kernel.org>; Jiří Pírko <jiri@resnulli.us>; Michael Shych > <michaelsh@mellanox.com> > Subject: Re: [PATCH platform-next v1 2/7] platform/x86: mlx-platform: Rename > new systems product names > > On Tue, Nov 13, 2018 at 5:23 PM Vadim Pasternak <vadimp@mellanox.com> > wrote: > > > > > > > > > -----Original Message----- > > > From: Andy Shevchenko <andy.shevchenko@gmail.com> > > > Sent: Tuesday, November 13, 2018 5:20 PM > > > To: Vadim Pasternak <vadimp@mellanox.com> > > > Cc: Darren Hart <dvhart@infradead.org>; Platform Driver > > > <platform-driver- x86@vger.kernel.org>; Jiří Pírko > > > <jiri@resnulli.us>; Michael Shych <michaelsh@mellanox.com> > > > Subject: Re: [PATCH platform-next v1 2/7] platform/x86: > > > mlx-platform: Rename new systems product names > > > > > > On Tue, Nov 13, 2018 at 3:55 PM Vadim Pasternak > > > <vadimp@mellanox.com> > > > wrote: > > > > > > > > Rename product names for next generation systems QMB7, SN37, SN34 > > > > to respectively MQMB7, MSN37, MSN34. > > > > > > > > > > Wait, do we have the old names still present in the wild? > > > > Hi Andy, > > > > No. These systems are about to be released to the customers. > > So, no one have a systems with the old names. > > > > The names have been changed due to marketing decision (symbol 'M" at > > the beginning). > > This needs to be elaborated in the commit message. OK. Will update. > > > > > > > > > > Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> > > > > --- > > > > drivers/platform/x86/mlx-platform.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/platform/x86/mlx-platform.c > > > > b/drivers/platform/x86/mlx-platform.c > > > > index 63edab5..cdf4498 100644 > > > > --- a/drivers/platform/x86/mlx-platform.c > > > > +++ b/drivers/platform/x86/mlx-platform.c > > > > @@ -1508,21 +1508,21 @@ static const struct dmi_system_id > > > mlxplat_dmi_table[] __initconst = { > > > > .callback = mlxplat_dmi_qmb7xx_matched, > > > > .matches = { > > > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox > Technologies"), > > > > - DMI_MATCH(DMI_PRODUCT_NAME, "QMB7"), > > > > + DMI_MATCH(DMI_PRODUCT_NAME, "MQM87"), > > > > }, > > > > }, > > > > { > > > > .callback = mlxplat_dmi_qmb7xx_matched, > > > > .matches = { > > > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox > Technologies"), > > > > - DMI_MATCH(DMI_PRODUCT_NAME, "SN37"), > > > > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN37"), > > > > }, > > > > }, > > > > { > > > > .callback = mlxplat_dmi_qmb7xx_matched, > > > > .matches = { > > > > DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox > Technologies"), > > > > - DMI_MATCH(DMI_PRODUCT_NAME, "SN34"), > > > > + DMI_MATCH(DMI_PRODUCT_NAME, "MSN34"), > > > > }, > > > > }, > > > > { > > > > -- > > > > 2.1.4 > > > > > > > > > > > > > -- > > > With Best Regards, > > > Andy Shevchenko > > > > -- > With Best Regards, > Andy Shevchenko
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c index 63edab5..cdf4498 100644 --- a/drivers/platform/x86/mlx-platform.c +++ b/drivers/platform/x86/mlx-platform.c @@ -1508,21 +1508,21 @@ static const struct dmi_system_id mlxplat_dmi_table[] __initconst = { .callback = mlxplat_dmi_qmb7xx_matched, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), - DMI_MATCH(DMI_PRODUCT_NAME, "QMB7"), + DMI_MATCH(DMI_PRODUCT_NAME, "MQM87"), }, }, { .callback = mlxplat_dmi_qmb7xx_matched, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), - DMI_MATCH(DMI_PRODUCT_NAME, "SN37"), + DMI_MATCH(DMI_PRODUCT_NAME, "MSN37"), }, }, { .callback = mlxplat_dmi_qmb7xx_matched, .matches = { DMI_MATCH(DMI_BOARD_VENDOR, "Mellanox Technologies"), - DMI_MATCH(DMI_PRODUCT_NAME, "SN34"), + DMI_MATCH(DMI_PRODUCT_NAME, "MSN34"), }, }, {
Rename product names for next generation systems QMB7, SN37, SN34 to respectively MQMB7, MSN37, MSN34. Signed-off-by: Vadim Pasternak <vadimp@mellanox.com> --- drivers/platform/x86/mlx-platform.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)