| Message ID | 20181114224020.6100-1-lsahlber@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | cifs: moar compounding | expand |
tentatively merged into cifs-2.6.git for-next but would like thoughts on whether we should allow > 64K EAs to some Samba or Windows servers? On Wed, Nov 14, 2018 at 4:40 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote: > > Steve, All > > Some patches to consider for the next merge window. > The first two patches changes querying the EAs to use compounding > and adds a new query info compound helpers we can use for all other > open/query info/close places as well. > > The third patch adds an Open/Query/Close compound before setitng an > EA in order to make sure that we do not add so many EAs that we go beyond > the 64k limit that we have in the client for queries. > That used to be very annoying since you could keep adding more and more > large EAs until the point where you went above 64k, at which point you > could no longer list or access the EAs from the client any more :-( > > Unfortunately it adds an extra roundtrip to setting an EA but that should > be fine. Setting EAs should be relatively uncommon operation. >
Sure, we can set a higher max than 64k, It is easy to add if/when the need arises. On Thu, Nov 15, 2018 at 4:53 PM Steve French <smfrench@gmail.com> wrote: > > tentatively merged into cifs-2.6.git for-next > > but would like thoughts on whether we should allow > 64K EAs to some > Samba or Windows servers? > On Wed, Nov 14, 2018 at 4:40 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote: > > > > Steve, All > > > > Some patches to consider for the next merge window. > > The first two patches changes querying the EAs to use compounding > > and adds a new query info compound helpers we can use for all other > > open/query info/close places as well. > > > > The third patch adds an Open/Query/Close compound before setitng an > > EA in order to make sure that we do not add so many EAs that we go beyond > > the 64k limit that we have in the client for queries. > > That used to be very annoying since you could keep adding more and more > > large EAs until the point where you went above 64k, at which point you > > could no longer list or access the EAs from the client any more :-( > > > > Unfortunately it adds an extra roundtrip to setting an EA but that should > > be fine. Setting EAs should be relatively uncommon operation. > > > > > -- > Thanks, > > Steve