| Message ID | cb016b53-906a-adec-d8c6-019d2c74569b@free.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Regenerate arm64 defconfig for current kernel | expand |
On 09/11/2018 02:03, Marc Gonzalez wrote: > Commit e78d57b2f87c ("pinctrl: mediatek: add pinctrl-moore that > implements the generic pinctrl dt-bindings") made PINCTRL_MT7622 > depend on PINCTRL_MTK_MOORE. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> > --- > arch/arm64/configs/defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 6fe418d72337..725b9471b21c 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -369,7 +369,7 @@ CONFIG_PINCTRL_MSM8994=y > CONFIG_PINCTRL_MSM8996=y > CONFIG_PINCTRL_QDF2XXX=y > CONFIG_PINCTRL_QCOM_SPMI_PMIC=y > -CONFIG_PINCTRL_MT7622=y > +CONFIG_PINCTRL_MTK_MOORE=y This would disable pinctrl for mt7622, I don't think that is what we want. Regards, Matthias > CONFIG_GPIO_DWAPB=y > CONFIG_GPIO_MB86S7X=y > CONFIG_GPIO_PL061=y >
On 09/11/2018 14:03, Matthias Brugger wrote: > On 09/11/2018 02:03, Marc Gonzalez wrote: > >> Commit e78d57b2f87c ("pinctrl: mediatek: add pinctrl-moore that >> implements the generic pinctrl dt-bindings") made PINCTRL_MT7622 >> depend on PINCTRL_MTK_MOORE. >> >> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> >> --- >> arch/arm64/configs/defconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >> index 6fe418d72337..725b9471b21c 100644 >> --- a/arch/arm64/configs/defconfig >> +++ b/arch/arm64/configs/defconfig >> @@ -369,7 +369,7 @@ CONFIG_PINCTRL_MSM8994=y >> CONFIG_PINCTRL_MSM8996=y >> CONFIG_PINCTRL_QDF2XXX=y >> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y >> -CONFIG_PINCTRL_MT7622=y >> +CONFIG_PINCTRL_MTK_MOORE=y > > This would disable pinctrl for mt7622, I don't think that is what we want. I don't think so, because PINCTRL_MT7622 is "default y" I compared the .config files before and after the patch series to make sure no option changed unexpectedly. Regards.
On 09/11/2018 20:59, Marc Gonzalez wrote: > On 09/11/2018 14:03, Matthias Brugger wrote: > >> On 09/11/2018 02:03, Marc Gonzalez wrote: >> >>> Commit e78d57b2f87c ("pinctrl: mediatek: add pinctrl-moore that >>> implements the generic pinctrl dt-bindings") made PINCTRL_MT7622 >>> depend on PINCTRL_MTK_MOORE. >>> >>> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> >>> --- >>> arch/arm64/configs/defconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig >>> index 6fe418d72337..725b9471b21c 100644 >>> --- a/arch/arm64/configs/defconfig >>> +++ b/arch/arm64/configs/defconfig >>> @@ -369,7 +369,7 @@ CONFIG_PINCTRL_MSM8994=y >>> CONFIG_PINCTRL_MSM8996=y >>> CONFIG_PINCTRL_QDF2XXX=y >>> CONFIG_PINCTRL_QCOM_SPMI_PMIC=y >>> -CONFIG_PINCTRL_MT7622=y >>> +CONFIG_PINCTRL_MTK_MOORE=y >> >> This would disable pinctrl for mt7622, I don't think that is what we want. > > I don't think so, because PINCTRL_MT7622 is "default y" > > I compared the .config files before and after the patch series > to make sure no option changed unexpectedly. > Fair enough. Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
On Fri, Nov 09, 2018 at 02:03:20AM +0100, Marc Gonzalez wrote: > Commit e78d57b2f87c ("pinctrl: mediatek: add pinctrl-moore that > implements the generic pinctrl dt-bindings") made PINCTRL_MT7622 > depend on PINCTRL_MTK_MOORE. > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> Applied, needed touchups. -Olof
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 6fe418d72337..725b9471b21c 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -369,7 +369,7 @@ CONFIG_PINCTRL_MSM8994=y CONFIG_PINCTRL_MSM8996=y CONFIG_PINCTRL_QDF2XXX=y CONFIG_PINCTRL_QCOM_SPMI_PMIC=y -CONFIG_PINCTRL_MT7622=y +CONFIG_PINCTRL_MTK_MOORE=y CONFIG_GPIO_DWAPB=y CONFIG_GPIO_MB86S7X=y CONFIG_GPIO_PL061=y
Commit e78d57b2f87c ("pinctrl: mediatek: add pinctrl-moore that implements the generic pinctrl dt-bindings") made PINCTRL_MT7622 depend on PINCTRL_MTK_MOORE. Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr> --- arch/arm64/configs/defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)