mbox series

[v4,0/3] Enable ath10k wcn3990 wifi driver support on sdm845

Message ID 1541423318-19312-1-git-send-email-govinds@codeaurora.org (mailing list archive)
Headers show
Series Enable ath10k wcn3990 wifi driver support on sdm845 | expand

Message

Govind Singh Nov. 5, 2018, 1:08 p.m. UTC
This series enables ath10k wifi driver support for WCN3990 target
on sdm845 SOC. This series also updates the missing dt binding documentation
and adds optional iommu property.

Changes since v3:
    Moved interrupt/reg/reg-name to required property.
    Removed unused clocks.
    Corrected interrupt no's.

Changes since v2:
    dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi module
    device node patch from the series as dependent patch is not yet merged.
    Enabled status flag from sdm845-mtp.dts.

Changes since v1:
    Listed no of interrupts/clocks for each set of compatible.
    Added missing 'wifi' label to sdm845.dtsi.

Govind Singh (3):
  dt: bindings: add missing dt properties for WCN3990 wifi node
  dts: arm64/sdm845: Add WCN3990 WLAN module device node
  dt: bindings: add bindings for wifi iommu node

 .../bindings/net/wireless/qcom,ath10k.txt          | 62 ++++++++++++++--------
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
 arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
 3 files changed, 74 insertions(+), 22 deletions(-)

Comments

Kalle Valo Nov. 16, 2018, 1:29 p.m. UTC | #1
Govind Singh <govinds@codeaurora.org> writes:

> This series enables ath10k wifi driver support for WCN3990 target
> on sdm845 SOC. This series also updates the missing dt binding documentation
> and adds optional iommu property.
>
> Changes since v3:
>     Moved interrupt/reg/reg-name to required property.
>     Removed unused clocks.
>     Corrected interrupt no's.
>
> Changes since v2:
>     dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi module
>     device node patch from the series as dependent patch is not yet merged.
>     Enabled status flag from sdm845-mtp.dts.
>
> Changes since v1:
>     Listed no of interrupts/clocks for each set of compatible.
>     Added missing 'wifi' label to sdm845.dtsi.
>
> Govind Singh (3):
>   dt: bindings: add missing dt properties for WCN3990 wifi node
>   dts: arm64/sdm845: Add WCN3990 WLAN module device node
>   dt: bindings: add bindings for wifi iommu node
>
>  .../bindings/net/wireless/qcom,ath10k.txt          | 62 ++++++++++++++--------
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
>  3 files changed, 74 insertions(+), 22 deletions(-)

Via which tree are these patches going? That's not clear for me.
Govind Singh Nov. 16, 2018, 4:06 p.m. UTC | #2
On 2018-11-16 18:59, Kalle Valo wrote:
> Govind Singh <govinds@codeaurora.org> writes:
> 
>> This series enables ath10k wifi driver support for WCN3990 target
>> on sdm845 SOC. This series also updates the missing dt binding 
>> documentation
>> and adds optional iommu property.
>> 
>> Changes since v3:
>>     Moved interrupt/reg/reg-name to required property.
>>     Removed unused clocks.
>>     Corrected interrupt no's.
>> 
>> Changes since v2:
>>     dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990 wifi 
>> module
>>     device node patch from the series as dependent patch is not yet 
>> merged.
>>     Enabled status flag from sdm845-mtp.dts.
>> 
>> Changes since v1:
>>     Listed no of interrupts/clocks for each set of compatible.
>>     Added missing 'wifi' label to sdm845.dtsi.
>> 
>> Govind Singh (3):
>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>   dts: arm64/sdm845: Add WCN3990 WLAN module device node
>>   dt: bindings: add bindings for wifi iommu node
>> 
>>  .../bindings/net/wireless/qcom,ath10k.txt          | 62 
>> ++++++++++++++--------
>>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
>>  3 files changed, 74 insertions(+), 22 deletions(-)
> 
> Via which tree are these patches going? That's not clear for me.

I guess sdm845 dtsi change should be going to 
git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
I need to send v5 to address one comment from Brian.

BR,
Govind
Kalle Valo Nov. 17, 2018, 11:09 a.m. UTC | #3
Govind Singh <govinds@codeaurora.org> writes:

> On 2018-11-16 18:59, Kalle Valo wrote:
>> Govind Singh <govinds@codeaurora.org> writes:
>>
>>> This series enables ath10k wifi driver support for WCN3990 target
>>> on sdm845 SOC. This series also updates the missing dt binding
>>> documentation
>>> and adds optional iommu property.
>>>
>>> Changes since v3:
>>>     Moved interrupt/reg/reg-name to required property.
>>>     Removed unused clocks.
>>>     Corrected interrupt no's.
>>>
>>> Changes since v2:
>>>     dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990
>>> wifi module
>>>     device node patch from the series as dependent patch is not yet
>>> merged.
>>>     Enabled status flag from sdm845-mtp.dts.
>>>
>>> Changes since v1:
>>>     Listed no of interrupts/clocks for each set of compatible.
>>>     Added missing 'wifi' label to sdm845.dtsi.
>>>
>>> Govind Singh (3):
>>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>>   dts: arm64/sdm845: Add WCN3990 WLAN module device node
>>>   dt: bindings: add bindings for wifi iommu node
>>>
>>>  .../bindings/net/wireless/qcom,ath10k.txt          | 62
>>> ++++++++++++++--------
>>>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
>>>  arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
>>>  3 files changed, 74 insertions(+), 22 deletions(-)
>>
>> Via which tree are these patches going? That's not clear for me.
>
> I guess sdm845 dtsi change should be going to
> git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
> I need to send v5 to address one comment from Brian.

Ok, I'll then drop these from my queue.
Govind Singh Dec. 19, 2018, 3:41 p.m. UTC | #4
Hi Kalle,

On 2018-11-17 16:39, Kalle Valo wrote:
> Govind Singh <govinds@codeaurora.org> writes:
> 
>> On 2018-11-16 18:59, Kalle Valo wrote:
>>> Govind Singh <govinds@codeaurora.org> writes:
>>> 
>>>> This series enables ath10k wifi driver support for WCN3990 target
>>>> on sdm845 SOC. This series also updates the missing dt binding
>>>> documentation
>>>> and adds optional iommu property.
>>>> 
>>>> Changes since v3:
>>>>     Moved interrupt/reg/reg-name to required property.
>>>>     Removed unused clocks.
>>>>     Corrected interrupt no's.
>>>> 
>>>> Changes since v2:
>>>>     dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990
>>>> wifi module
>>>>     device node patch from the series as dependent patch is not yet
>>>> merged.
>>>>     Enabled status flag from sdm845-mtp.dts.
>>>> 
>>>> Changes since v1:
>>>>     Listed no of interrupts/clocks for each set of compatible.
>>>>     Added missing 'wifi' label to sdm845.dtsi.
>>>> 
>>>> Govind Singh (3):
>>>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>>>   dts: arm64/sdm845: Add WCN3990 WLAN module device node
>>>>   dt: bindings: add bindings for wifi iommu node
>>>> 
>>>>  .../bindings/net/wireless/qcom,ath10k.txt          | 62
>>>> ++++++++++++++--------
>>>>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
>>>>  arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
>>>>  3 files changed, 74 insertions(+), 22 deletions(-)
>>> 
>>> Via which tree are these patches going? That's not clear for me.
>> 
>> I guess sdm845 dtsi change should be going to
>> git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
>> I need to send v5 to address one comment from Brian.
> 
> Ok, I'll then drop these from my queue.

Can you pls apply below changes to ath10k tree, i will send sdm845 dtsi 
change as separate patch after rebase.
>>>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>>>   dt: bindings: add bindings for wifi iommu node

BR,
Govind
Kalle Valo Dec. 20, 2018, 11:58 a.m. UTC | #5
Govind Singh <govinds@codeaurora.org> writes:

> Hi Kalle,
>
> On 2018-11-17 16:39, Kalle Valo wrote:
>> Govind Singh <govinds@codeaurora.org> writes:
>>
>>> On 2018-11-16 18:59, Kalle Valo wrote:
>>>> Govind Singh <govinds@codeaurora.org> writes:
>>>>
>>>>> This series enables ath10k wifi driver support for WCN3990 target
>>>>> on sdm845 SOC. This series also updates the missing dt binding
>>>>> documentation
>>>>> and adds optional iommu property.
>>>>>
>>>>> Changes since v3:
>>>>>     Moved interrupt/reg/reg-name to required property.
>>>>>     Removed unused clocks.
>>>>>     Corrected interrupt no's.
>>>>>
>>>>> Changes since v2:
>>>>>     dropped [v2,4/4] dts: arm64/sdm845: Enable iommu for WCN3990
>>>>> wifi module
>>>>>     device node patch from the series as dependent patch is not yet
>>>>> merged.
>>>>>     Enabled status flag from sdm845-mtp.dts.
>>>>>
>>>>> Changes since v1:
>>>>>     Listed no of interrupts/clocks for each set of compatible.
>>>>>     Added missing 'wifi' label to sdm845.dtsi.
>>>>>
>>>>> Govind Singh (3):
>>>>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>>>>   dts: arm64/sdm845: Add WCN3990 WLAN module device node
>>>>>   dt: bindings: add bindings for wifi iommu node
>>>>>
>>>>>  .../bindings/net/wireless/qcom,ath10k.txt          | 62
>>>>> ++++++++++++++--------
>>>>>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts            |  8 +++
>>>>>  arch/arm64/boot/dts/qcom/sdm845.dtsi               | 26 +++++++++
>>>>>  3 files changed, 74 insertions(+), 22 deletions(-)
>>>>
>>>> Via which tree are these patches going? That's not clear for me.
>>>
>>> I guess sdm845 dtsi change should be going to
>>> git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
>>> I need to send v5 to address one comment from Brian.
>>
>> Ok, I'll then drop these from my queue.
>
> Can you pls apply below changes to ath10k tree, i will send sdm845
> dtsi change as separate patch after rebase.
>
>>>>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>>>>   dt: bindings: add bindings for wifi iommu node

Ok, these two are back in my queue:

https://patchwork.kernel.org/patch/10668237/

https://patchwork.kernel.org/patch/10668245/

I'll just modify the titles to use ath10k prefix to make it more clear
these are for ath10k:

   dt: bindings: ath10k: .....
Kalle Valo Dec. 20, 2018, 1:18 p.m. UTC | #6
Kalle Valo <kvalo@codeaurora.org> writes:

> Govind Singh <govinds@codeaurora.org> writes:
>
>> Hi Kalle,
>>
>> On 2018-11-17 16:39, Kalle Valo wrote:
>>> Govind Singh <govinds@codeaurora.org> writes:
>>>
>>>> On 2018-11-16 18:59, Kalle Valo wrote:
>>>>>
>>>>> Via which tree are these patches going? That's not clear for me.
>>>>
>>>> I guess sdm845 dtsi change should be going to
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
>>>> I need to send v5 to address one comment from Brian.
>>>
>>> Ok, I'll then drop these from my queue.
>>
>> Can you pls apply below changes to ath10k tree, i will send sdm845
>> dtsi change as separate patch after rebase.
>>
>>>>>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>>>>>   dt: bindings: add bindings for wifi iommu node
>
> Ok, these two are back in my queue:
>
> https://patchwork.kernel.org/patch/10668237/
>
> https://patchwork.kernel.org/patch/10668245/
>
> I'll just modify the titles to use ath10k prefix to make it more clear
> these are for ath10k:
>
>    dt: bindings: ath10k: .....

There were conflicts with this commit:

2b741a8aaa34 dt: bindings: add bindings for msa memory region

I fixed them in the pending branch, please double check carefully:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=5bb88d4d49783c75ac083e4ea19b7527bc115857

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=a6d53e207670eacd72a74277658bac1ab346fabd
Govind Singh Dec. 20, 2018, 1:24 p.m. UTC | #7
Hi Kalle,

On 2018-12-20 18:48, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
> 
>> Govind Singh <govinds@codeaurora.org> writes:
>> 
>>> Hi Kalle,
>>> 
>>> On 2018-11-17 16:39, Kalle Valo wrote:
>>>> Govind Singh <govinds@codeaurora.org> writes:
>>>> 
>>>>> On 2018-11-16 18:59, Kalle Valo wrote:
>>>>>> 
>>>>>> Via which tree are these patches going? That's not clear for me.
>>>>> 
>>>>> I guess sdm845 dtsi change should be going to
>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git.
>>>>> I need to send v5 to address one comment from Brian.
>>>> 
>>>> Ok, I'll then drop these from my queue.
>>> 
>>> Can you pls apply below changes to ath10k tree, i will send sdm845
>>> dtsi change as separate patch after rebase.
>>> 
>>>>>>>   dt: bindings: add missing dt properties for WCN3990 wifi node
>>>>>>>   dt: bindings: add bindings for wifi iommu node
>> 
>> Ok, these two are back in my queue:
>> 
>> https://patchwork.kernel.org/patch/10668237/
>> 
>> https://patchwork.kernel.org/patch/10668245/
>> 
>> I'll just modify the titles to use ath10k prefix to make it more clear
>> these are for ath10k:
>> 
>>    dt: bindings: ath10k: .....
> 
> There were conflicts with this commit:
> 
> 2b741a8aaa34 dt: bindings: add bindings for msa memory region
> 
> I fixed them in the pending branch, please double check carefully:
> 

Changes looks good to me.

> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=5bb88d4d49783c75ac083e4ea19b7527bc115857
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=a6d53e207670eacd72a74277658bac1ab346fabd

BR,
Govind