| Message ID | 20181119101616.8901-5-david@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v1,1/8] mm: balloon: update comment about isolation/migration/compaction | expand |
On 19/11/2018 11:16, David Hildenbrand wrote: > Mark inflated and never onlined pages PG_offline, to tell the world that > the content is stale and should not be dumped. > > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: Michal Hocko <mhocko@suse.com> > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > drivers/xen/balloon.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c > index 12148289debd..14dd6b814db3 100644 > --- a/drivers/xen/balloon.c > +++ b/drivers/xen/balloon.c > @@ -425,6 +425,7 @@ static int xen_bring_pgs_online(struct page *pg, unsigned int order) > for (i = 0; i < size; i++) { > p = pfn_to_page(start_pfn + i); > __online_page_set_limits(p); > + __SetPageOffline(p); > __balloon_append(p); > } This seems not to be based on current master. Could you please tell against which tree this should be reviewed? Juergen
On 19.11.18 13:22, Juergen Gross wrote: > On 19/11/2018 11:16, David Hildenbrand wrote: >> Mark inflated and never onlined pages PG_offline, to tell the world that >> the content is stale and should not be dumped. >> >> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> >> Cc: Juergen Gross <jgross@suse.com> >> Cc: Stefano Stabellini <sstabellini@kernel.org> >> Cc: Andrew Morton <akpm@linux-foundation.org> >> Cc: Matthew Wilcox <willy@infradead.org> >> Cc: Michal Hocko <mhocko@suse.com> >> Cc: "Michael S. Tsirkin" <mst@redhat.com> >> Signed-off-by: David Hildenbrand <david@redhat.com> >> --- >> drivers/xen/balloon.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c >> index 12148289debd..14dd6b814db3 100644 >> --- a/drivers/xen/balloon.c >> +++ b/drivers/xen/balloon.c >> @@ -425,6 +425,7 @@ static int xen_bring_pgs_online(struct page *pg, unsigned int order) >> for (i = 0; i < size; i++) { >> p = pfn_to_page(start_pfn + i); >> __online_page_set_limits(p); >> + __SetPageOffline(p); >> __balloon_append(p); >> } > > This seems not to be based on current master. Could you please tell > against which tree this should be reviewed? > Hi Juergen, this is based on linux-next/master. Thanks! > > Juergen >
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index 12148289debd..14dd6b814db3 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -425,6 +425,7 @@ static int xen_bring_pgs_online(struct page *pg, unsigned int order) for (i = 0; i < size; i++) { p = pfn_to_page(start_pfn + i); __online_page_set_limits(p); + __SetPageOffline(p); __balloon_append(p); } mutex_unlock(&balloon_mutex); @@ -493,6 +494,7 @@ static enum bp_state increase_reservation(unsigned long nr_pages) xenmem_reservation_va_mapping_update(1, &page, &frame_list[i]); /* Relinquish the page back to the allocator. */ + __ClearPageOffline(page); free_reserved_page(page); } @@ -519,6 +521,7 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp) state = BP_EAGAIN; break; } + __SetPageOffline(page); adjust_managed_page_count(page, -1); xenmem_reservation_scrub_page(page); list_add(&page->lru, &pages);
Mark inflated and never onlined pages PG_offline, to tell the world that the content is stale and should not be dumped. Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Matthew Wilcox <willy@infradead.org> Cc: Michal Hocko <mhocko@suse.com> Cc: "Michael S. Tsirkin" <mst@redhat.com> Signed-off-by: David Hildenbrand <david@redhat.com> --- drivers/xen/balloon.c | 3 +++ 1 file changed, 3 insertions(+)