| Message ID | mvma7m3n9l6.fsf_-_@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | net: phy: mscc: fix locking in vsc85xx_default_config | expand |
Hi Andreas, On Tue, Nov 20, 2018 at 02:48:37PM +0100, Andreas Schwab wrote: > Don't use locking phy_read/phy_write functions while inside > phy_select_patch/phy_restore_page region. > > Fixes: 6a0bfbbe20 ("net: phy: mscc: migrate to phy_select/restore_page functions") > Signed-off-by: Andreas Schwab <schwab@suse.de> Have you tested this patch? Does it solve your issue? Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com> anyway since it's to be done. You need to send your patch as a mail separate to this patch series. You also need to prefix your patch with [PATCH net-next] instead of only [PATCH]. This is specific to the net subsystem. Use scripts/get_maintainer.pl on your patch to get the people to put in Cc and in To. Thanks, Quentin
On Nov 20 2018, Quentin Schulz <quentin.schulz@bootlin.com> wrote: > You also need to prefix your patch with [PATCH net-next] instead of only > [PATCH]. This is specific to the net subsystem. Why next? This is a bug fix that needs to go in now, not next. > Use scripts/get_maintainer.pl on your patch to get the people to put in > Cc and in To. The same people as the original patch the added the bug. Why would it be different now? Andreas.
Hi Andreas, On Tue, Nov 20, 2018 at 03:01:25PM +0100, Andreas Schwab wrote: > On Nov 20 2018, Quentin Schulz <quentin.schulz@bootlin.com> wrote: > > > You also need to prefix your patch with [PATCH net-next] instead of only > > [PATCH]. This is specific to the net subsystem. > > Why next? This is a bug fix that needs to go in now, not next. > Indeed. Use [PATCH net] then. Please refer to https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt > > Use scripts/get_maintainer.pl on your patch to get the people to put in > > Cc and in To. > > The same people as the original patch the added the bug. Why would it > be different now? > First, people may have changed mail addresses (especially maintainers) and that is picked by get_maintainer. Second, other people may have worked on this driver since the patch was introduced and they might want to know about this change too and have their word on it. This is what happened with this driver. Gustavo and Heiner sent patches since then and they have already been merged. This is also part of the contribution process which is defined here: https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html You have not answered my question yet. Does this fix your issue, yes or no? Quentin
diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index a2e59f4f6f..a398ab9410 100644 --- a/drivers/net/phy/mscc.c +++ b/drivers/net/phy/mscc.c @@ -814,10 +814,10 @@ static int vsc85xx_default_config(struct phy_device *phydev) if (rc < 0) goto out_unlock; - reg_val = phy_read(phydev, MSCC_PHY_RGMII_CNTL); + reg_val = __phy_read(phydev, MSCC_PHY_RGMII_CNTL); reg_val &= ~(RGMII_RX_CLK_DELAY_MASK); reg_val |= (RGMII_RX_CLK_DELAY_1_1_NS << RGMII_RX_CLK_DELAY_POS); - phy_write(phydev, MSCC_PHY_RGMII_CNTL, reg_val); + __phy_write(phydev, MSCC_PHY_RGMII_CNTL, reg_val); out_unlock: rc = phy_restore_page(phydev, rc, rc > 0 ? 0 : rc);
Don't use locking phy_read/phy_write functions while inside phy_select_patch/phy_restore_page region. Fixes: 6a0bfbbe20 ("net: phy: mscc: migrate to phy_select/restore_page functions") Signed-off-by: Andreas Schwab <schwab@suse.de> --- drivers/net/phy/mscc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)