[0/5] Add migration support for VFIO device

Message

Kirti Wankhede Nov. 20, 2018, 8:39 p.m. UTC

Add migration support for VFIO device

This Patch set include patches as below:
- Define KABI for VFIO device for migration support.
- Added save and restore functions for PCI configuration space
- Generic migration functionality for VFIO device.
  * This patch set adds functionality only for PCI devices, but can be
    extended to other VFIO devices.
  * Added all the basic functions required for pre-copy, stop-and-copy and
    resume phases of migration.
  * Added state change notifier and from that notifier function, VFIO
    device's state changed is conveyed to VFIO device driver.
  * During save setup phase and resume/load setup phase, migration region
    is queried and is used to read/write VFIO device data.
  * .save_live_pending, .save_live_iterate and .is_active_iterate are
    implemented to use QEMU's functionality of iteration during pre-copy
    phase.
  * In .save_live_complete_precopy, that is in stop-and-copy phase,
    iteration to read data from VFIO device driver is implemented till pending
    bytes returned by driver are not zero.
  * .save_cleanup and .load_cleanup are implemented to unmap migration
    region that was setup duing setup phase.
  * Added function to get dirty pages bitmap for the pages which are used by
    driver.
- Add vfio_listerner_log_sync to mark dirty pages.
- Make VFIO PCI device migration capable. If migration region is not provided by
  driver, migration is blocked.

Below is the flow of state change for live migration where states in brackets
represent VM state, migration state and VFIO device state as:
    (VM state, MIGRATION_STATUS, VFIO_DEVICE_STATE)

Live migration save path:
        QEMU normal running state
        (RUNNING, _NONE, _RUNNING)
                        |
    migrate_init spawns migration_thread.
    (RUNNING, _SETUP, _MIGRATION_SETUP)
    Migration thread then calls each device's .save_setup()
                        |
    (RUNNING, _ACTIVE, _MIGRATION_PRECOPY)
    If device is active, get pending bytes by .save_live_pending()
    if pending bytes >= threshold_size,  call save_live_iterate()
    Data of VFIO device for pre-copy phase is copied.
    Iterate till pending bytes converge and are less than threshold
                        |
    migration_completion() stops vCPUs and calls .save_live_complete_precopy
    for each active  device. VFIO device is then transitioned in
     _MIGRATION_STOPNCOPY state.
    (FINISH_MIGRATE, _DEVICE, _MIGRATION_STOPNCOPY)
    For VFIO device, iterate in  .save_live_complete_precopy  until
    pending data is 0. Change VFIO device state.
    (FINISH_MIGRATE, _DEVICE, _MIGRATION_SAVE_COMPLETED)
                        |
    (FINISH_MIGRATE, _COMPLETED, _MIGRATION_SAVE_COMPLETED)
    Migraton thread schedule cleanup bottom half and exit
                        |
    (POST_MIGRATE, _COMPLETED, _MIGRATION_SAVE_COMPLETED)
    For each device, call .save_cleanup(). Unmap migration region.


Live migration resume path:
    Incomming migration calls .load_setup for each device
    (RESTORE_VM, _ACTIVE, _MIGRATION_RESUME)
                        |
    For each device, .load_state is called for that device section data
                        |
    At the end, called .load_cleanup for each device and vCPUs are started.
    (RUNNING, _NONE, _RUNNING)

Note that:
- Migration post copy is not supported.
- VFIO device driver version compatibility is not taken care in this series.

v1 -> v2:
- Defined MIGRATION region type and sub-type which should be used with region
  type capability.
- Re-structured vfio_device_migration_info. This structure will be placed at 0th
  offset of migration region.
- Replaced ioctl with read/write for trapped part of migration region.
- Added both type of access support, trapped or mmapped, for data section of the
  region.
- Moved PCI device functions to pci file.
- Added iteration to get dirty page bitmap until bitmap for all requested pages
  are copied.

Thanks,
Kirti

Kirti Wankhede (5):
  VFIO KABI for migration interface
  Add save and load functions for VFIO PCI devices
  Add migration functions for VFIO devices
  Add vfio_listerner_log_sync to mark dirty pages
  Make vfio-pci device migration capable.

 hw/vfio/Makefile.objs         |   2 +-
 hw/vfio/common.c              |  32 ++
 hw/vfio/migration.c           | 729 ++++++++++++++++++++++++++++++++++++++++++
 hw/vfio/pci.c                 | 108 ++++++-
 hw/vfio/pci.h                 |  29 ++
 include/hw/vfio/vfio-common.h |  23 ++
 linux-headers/linux/vfio.h    | 130 ++++++++
 7 files changed, 1045 insertions(+), 8 deletions(-)
 create mode 100644 hw/vfio/migration.c

Comments

Peter Xu Nov. 21, 2018, 5:47 a.m. UTC | #1

On Wed, Nov 21, 2018 at 02:09:38AM +0530, Kirti Wankhede wrote:
> Add migration support for VFIO device

Hi, Kirti,

I failed to apply the series cleanly onto master.  Could you push the
tree somewhere so that people might read the work easier?  Or would
you tell me the base commit, then I can apply it myself.

Thanks in advance,

Kirti Wankhede Nov. 22, 2018, 9:01 p.m. UTC | #2

On 11/21/2018 11:17 AM, Peter Xu wrote:
> On Wed, Nov 21, 2018 at 02:09:38AM +0530, Kirti Wankhede wrote:
>> Add migration support for VFIO device
> 
> Hi, Kirti,
> 
> I failed to apply the series cleanly onto master.  Could you push the
> tree somewhere so that people might read the work easier?  Or would
> you tell me the base commit, then I can apply it myself.
> 

Sorry of inconvenience.
These patches are on top of v3.0.0 release (tag: v3.0.0)

Thanks,
Kirti