| Message ID | 20181119052324.31456-5-chandan@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Remove fs specific fscrypt and fsverity build config options | expand |
Hi Chandan, On Mon, Nov 19, 2018 at 10:53:21AM +0530, Chandan Rajendra wrote: > Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds > S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity > information associated with it. > > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com> > --- > include/linux/fs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index bcfc40062757..8129617c9718 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1938,6 +1938,7 @@ struct super_operations { > #define S_DAX 0 /* Make all the DAX code disappear */ > #endif > #define S_ENCRYPTED 16384 /* Encrypted file (using fs/crypto/) */ > +#define S_VERITY 32768 /* File with fsverity info (using fs/verity) */ > The comment for S_VERITY is misleading because IS_VERITY() is used to check whether the verity bit is set *before* the fsverity_info is created. Can you change it to just mirror the fscrypt comment? #define S_VERITY 32768 /* Verity file (using fs/verity/) */ > /* > * Note that nosuid etc flags are inode-specific: setting some file-system > @@ -1978,6 +1979,7 @@ static inline bool sb_rdonly(const struct super_block *sb) { return sb->s_flags > #define IS_NOSEC(inode) ((inode)->i_flags & S_NOSEC) > #define IS_DAX(inode) ((inode)->i_flags & S_DAX) > #define IS_ENCRYPTED(inode) ((inode)->i_flags & S_ENCRYPTED) > +#define IS_VERITY(inode) ((inode)->i_flags & S_VERITY) > > #define IS_WHITEOUT(inode) (S_ISCHR(inode->i_mode) && \ > (inode)->i_rdev == WHITEOUT_DEV) > -- > 2.19.1 > Thanks, - Eric
On Tuesday, November 27, 2018 5:38:38 AM IST Eric Biggers wrote: > Hi Chandan, > > On Mon, Nov 19, 2018 at 10:53:21AM +0530, Chandan Rajendra wrote: > > Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds > > S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity > > information associated with it. > > > > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com> > > --- > > include/linux/fs.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/fs.h b/include/linux/fs.h > > index bcfc40062757..8129617c9718 100644 > > --- a/include/linux/fs.h > > +++ b/include/linux/fs.h > > @@ -1938,6 +1938,7 @@ struct super_operations { > > #define S_DAX 0 /* Make all the DAX code disappear */ > > #endif > > #define S_ENCRYPTED 16384 /* Encrypted file (using fs/crypto/) */ > > +#define S_VERITY 32768 /* File with fsverity info (using fs/verity) */ > > > > The comment for S_VERITY is misleading because IS_VERITY() is used to check > whether the verity bit is set *before* the fsverity_info is created. > > Can you change it to just mirror the fscrypt comment? > > #define S_VERITY 32768 /* Verity file (using fs/verity/) */ I will fix this up.
diff --git a/include/linux/fs.h b/include/linux/fs.h index bcfc40062757..8129617c9718 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1938,6 +1938,7 @@ struct super_operations { #define S_DAX 0 /* Make all the DAX code disappear */ #endif #define S_ENCRYPTED 16384 /* Encrypted file (using fs/crypto/) */ +#define S_VERITY 32768 /* File with fsverity info (using fs/verity) */ /* * Note that nosuid etc flags are inode-specific: setting some file-system @@ -1978,6 +1979,7 @@ static inline bool sb_rdonly(const struct super_block *sb) { return sb->s_flags #define IS_NOSEC(inode) ((inode)->i_flags & S_NOSEC) #define IS_DAX(inode) ((inode)->i_flags & S_DAX) #define IS_ENCRYPTED(inode) ((inode)->i_flags & S_ENCRYPTED) +#define IS_VERITY(inode) ((inode)->i_flags & S_VERITY) #define IS_WHITEOUT(inode) (S_ISCHR(inode->i_mode) && \ (inode)->i_rdev == WHITEOUT_DEV)
Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity information associated with it. Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com> --- include/linux/fs.h | 2 ++ 1 file changed, 2 insertions(+)