| Message ID | 20181123150600.27445-1-tiny.windzz@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | clk: nomadik: Change to use DEFINE_SHOW_ATTRIBUTE macro | expand |
Quoting Yangtao Li (2018-11-23 07:06:00) > Use macro to simplify the code. > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- Applied to clk-next
Quoting Stephen Boyd (2018-11-28 14:08:32) > Quoting Yangtao Li (2018-11-23 07:06:00) > > Use macro to simplify the code. > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > Applied to clk-next > Except this doesn't compile. I fixed it, but please actually compile your patches before sending next time. diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c index e331634d34df..a95aa96f4a68 100644 --- a/drivers/clk/clk-nomadik.c +++ b/drivers/clk/clk-nomadik.c @@ -455,7 +455,7 @@ static const char * const src_clk_names[] = { "RNGCCLK ", }; -static int nomadik_src_clk_show(struct seq_file *s, void *what) +static int nomadik_src_clk_debugfs_show(struct seq_file *s, void *what) { int i; u32 src_pcksr0 = readl(src_base + SRC_PCKSR0);
On Thu, Nov 29, 2018 at 6:12 AM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Stephen Boyd (2018-11-28 14:08:32) > > Quoting Yangtao Li (2018-11-23 07:06:00) > > > Use macro to simplify the code. > > > > > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > > --- > > > > Applied to clk-next > > > > Except this doesn't compile. I fixed it, but please actually compile > your patches before sending next time. Sorry, I will pay attention next time. MBR, Yangtao > > diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c > index e331634d34df..a95aa96f4a68 100644 > --- a/drivers/clk/clk-nomadik.c > +++ b/drivers/clk/clk-nomadik.c > @@ -455,7 +455,7 @@ static const char * const src_clk_names[] = { > "RNGCCLK ", > }; > > -static int nomadik_src_clk_show(struct seq_file *s, void *what) > +static int nomadik_src_clk_debugfs_show(struct seq_file *s, void *what) > { > int i; > u32 src_pcksr0 = readl(src_base + SRC_PCKSR0);
diff --git a/drivers/clk/clk-nomadik.c b/drivers/clk/clk-nomadik.c index 84a24875c629..e331634d34df 100644 --- a/drivers/clk/clk-nomadik.c +++ b/drivers/clk/clk-nomadik.c @@ -479,17 +479,7 @@ static int nomadik_src_clk_show(struct seq_file *s, void *what) return 0; } -static int nomadik_src_clk_open(struct inode *inode, struct file *file) -{ - return single_open(file, nomadik_src_clk_show, NULL); -} - -static const struct file_operations nomadik_src_clk_debugfs_ops = { - .open = nomadik_src_clk_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(nomadik_src_clk_debugfs); static int __init nomadik_src_clk_init_debugfs(void) { @@ -499,7 +489,7 @@ static int __init nomadik_src_clk_init_debugfs(void) src_pcksr0_boot = readl(src_base + SRC_PCKSR0); src_pcksr1_boot = readl(src_base + SRC_PCKSR1); debugfs_create_file("nomadik-src-clk", S_IFREG | S_IRUGO, - NULL, NULL, &nomadik_src_clk_debugfs_ops); + NULL, NULL, &nomadik_src_clk_debugfs_fops); return 0; } device_initcall(nomadik_src_clk_init_debugfs);
Use macro to simplify the code. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/clk/clk-nomadik.c | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-)