| Message ID | 20181129155249.30096-1-sean@poorly.run (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: TODO: Add DRM_MODESET_LOCK_ALL* conversion to todo.rst | expand |
On Thu, Nov 29, 2018 at 10:52:40AM -0500, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > We should also get the drivers using the helpers. Seems like a good > intermediate TODO item. > > Cc: Daniel Vetter <daniel@ffwll.ch> > Signed-off-by: Sean Paul <seanpaul@chromium.org> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > Documentation/gpu/todo.rst | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index ab347dec50796..1a6dc586fb156 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -241,6 +241,18 @@ struct drm_gem_object_funcs > GEM objects can now have a function table instead of having the callbacks on the > DRM driver struct. This is now the preferred way and drivers can be moved over. > > +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate > +--------------------------------------------------------- > + > +For cases where drivers are attempting to grab the modeset locks with a local > +acquire context. Replace the boilerplate code surrounding > +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and > +DRM_MODESET_LOCK_ALL_END() instead. Maybe add: "This should also be done for all places where drm_modest_lock_all() is still used." Cheers, Daniel > + > +As a reference, take a look at the conversions already completed in drm core. > + > +Contact: Sean Paul, respective driver maintainers > + > Core refactorings > ================= > > -- > Sean Paul, Software Engineer, Google / Chromium OS >
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index ab347dec50796..1a6dc586fb156 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -241,6 +241,18 @@ struct drm_gem_object_funcs GEM objects can now have a function table instead of having the callbacks on the DRM driver struct. This is now the preferred way and drivers can be moved over. +Use DRM_MODESET_LOCK_ALL_* helpers instead of boilerplate +--------------------------------------------------------- + +For cases where drivers are attempting to grab the modeset locks with a local +acquire context. Replace the boilerplate code surrounding +drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and +DRM_MODESET_LOCK_ALL_END() instead. + +As a reference, take a look at the conversions already completed in drm core. + +Contact: Sean Paul, respective driver maintainers + Core refactorings =================