diff mbox series

[01/41] scsi: BusLogic: mark expected switch fall-through

Message ID	de0c68b4f655080a7336d1ad256d77a83ab0b7d6.1543374820.git.gustavo@embeddedor.com (mailing list archive)
State	Accepted
Headers	show Return-Path: <linux-scsi-owner@kernel.org> Date: Tue, 27 Nov 2018 22:21:23 -0600 From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> To: Khalid Aziz <khalid@gonehiking.org> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" <gustavo@embeddedor.com> Subject: [PATCH 01/41] scsi: BusLogic: mark expected switch fall-through Message-ID: <de0c68b4f655080a7336d1ad256d77a83ab0b7d6.1543374820.git.gustavo@embeddedor.com> References: <cover.1543374820.git.gustavo@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1543374820.git.gustavo@embeddedor.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk
Series	scsi: Mark expected switch fall-throughs \| expand [00/41] scsi: Mark expected switch fall-throughs [01/41] scsi: BusLogic: mark expected switch fall-through [02/41] scsi: NCR5380: Mark expected switch fall-through [03/41] scsi: aacraid: aachba: Mark expected switch fall-throughs [04/41] scsi: aacraid: linit: Mark expected switch fall-through [05/41] scsi: aic7xxx: aic79xx: mark expected switch fall-through [06/41] scsi: aic7xxx: mark expected switch fall-throughs [07/41] scsi: be2iscsi: be_iscsi: Mark expected switch fall-through [08/41] scsi: be2iscsi: be_main: Mark expected switch fall-through [09/41] scsi: bfa: bfa_fcpim: Mark expected switch fall-throughs [10/41] scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughs [11/41] scsi: bfa: bfa_fcs_rport: Mark expected switch fall-throughs [12/41] scsi: bfa: bfa_ioc: Mark expected switch fall-throughs [13/41] scsi: csiostor: csio_wr: mark expected switch fall-through [14/41] scsi: esas2r: esas2r_init: mark expected switch fall-throughs [15/41] scsi: hpsa: mark expected switch fall-throughs [16/41] scsi: imm: mark expected switch fall-throughs [17/41] scsi: isci: phy: Mark expected switch fall-through [18/41] scsi: isci: remote_device: Mark expected switch fall-throughs [19/41] scsi: isci: remote_node_context: mark expected switch fall-throughs [20/41] scsi: isci: request: mark expected switch fall-through [21/41] scsi: libfc: fc_rport: Mark expected switch fall-through [22/41] scsi: lpfc: lpfc_ct: Mark expected switch fall-throughs [23/41] scsi: lpfc: lpfc_els: Mark expected switch fall-throughs [24/41] scsi: lpfc: lpfc_hbadisc: Mark expected switch fall-throughs [25/41] scsi: lpfc: lpfc_nportdisc: Mark expected switch fall-through [26/41] scsi: lpfc: lpfc_nvme: Mark expected switch fall-through [27/41] scsi: lpfc: lpfc_scsi: Mark expected switch fall-throughs [28/41] scsi: lpfc: lpfc_sli: Mark expected switch fall-throughs [29/41] scsi: megaraid: megaraid_sas_base: Mark expected switch fall-through [30/41] scsi: megaraid_sas_fusion: Mark expected switch fall-through [31/41] scsi: mpt3sas: mpt3sas_scsih: Mark expected switch fall-through [32/41] scsi: myrb: Mark expected switch fall-throughs [33/41] scsi: osd: osd_initiator: mark expected switch fall-throughs [34/41] scsi: osst: mark expected switch fall-throughs [35/41] scsi: ppa: mark expected switch fall-through [36/41] scsi: qla4xxx: ql4_os: mark expected switch fall-through [37/41] scsi: st: mark expected switch fall-throughs [38/41] scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs [39/41] scsi: sym53c8xx_2: sym_nvram: Mark expected switch fall-through [40/41] scsi: ufs: ufshcd: mark expected switch fall-throughs [41/41] scsi: xen-scsifront: mark expected switch fall-through

Commit Message

Gustavo A. R. Silva Nov. 28, 2018, 4:21 a.m. UTC

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1056537 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/scsi/BusLogic.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Khalid Aziz Dec. 3, 2018, 6:33 p.m. UTC | #1

On 11/27/18 9:21 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 1056537 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/scsi/BusLogic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
> index 9cee941f97d6..717eef3ee893 100644
> --- a/drivers/scsi/BusLogic.c
> +++ b/drivers/scsi/BusLogic.c
> @@ -2641,6 +2641,7 @@ static int blogic_resultcode(struct blogic_adapter *adapter,
>  	case BLOGIC_BAD_CMD_PARAM:
>  		blogic_warn("BusLogic Driver Protocol Error 0x%02X\n",
>  				adapter, adapter_status);
> +		/* fall through */
>  	case BLOGIC_DATA_UNDERRUN:
>  	case BLOGIC_DATA_OVERRUN:
>  	case BLOGIC_NOEXPECT_BUSFREE:
> 

Looks good.

Acked-by: Khalid Aziz <khalid@gonehiking.org>

Martin K. Petersen Dec. 8, 2018, 2:35 a.m. UTC | #2

Gustavo A.,

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.

Applied to 4.21/scsi-queue, thanks.

diff mbox series

Patch

diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index 9cee941f97d6..717eef3ee893 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -2641,6 +2641,7 @@  static int blogic_resultcode(struct blogic_adapter *adapter,
 	case BLOGIC_BAD_CMD_PARAM:
 		blogic_warn("BusLogic Driver Protocol Error 0x%02X\n",
 				adapter, adapter_status);
+		/* fall through */
 	case BLOGIC_DATA_UNDERRUN:
 	case BLOGIC_DATA_OVERRUN:
 	case BLOGIC_NOEXPECT_BUSFREE: