| Message ID | 1544425521-775-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V3,1/2] dt-bindings: iio: light: isl29018: update power supply name | expand |
On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote: > According to datasheet, the isl29018 has "vddd/vdda" power > supply, and isl29023/isl29035 ONLY has "vdd" power supply, > update the power supply name with "vdd" and "vdda" according > to datasheet to cover all devices and avoid confusion. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- > Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt b/Documentation/devicetree/bindings/iio/light/isl29018.txt > index b9bbde3..36f737d 100644 > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt > @@ -15,7 +15,9 @@ Optional properties: > Refer to interrupt-controller/interrupts.txt for generic interrupt client > node bindings. > > - - vcc-supply: phandle to the regulator that provides power to the sensor. > + - vdd-supply: phandle to the regulator that provides vdd power to the sensor. > + > + - vdda-supply: phandle to the regulator that provides vdda power to the sensor. Is this in use? You can't just change things if it is. Rob
Hi, Rob Best Regards! Anson Huang > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 2018年12月11日 7:24 > To: Anson Huang <anson.huang@nxp.com> > Cc: jic23@kernel.org; knaack.h@gmx.de; lars@metafoo.de; > pmeerw@pmeerw.net; mark.rutland@arm.com; linux-iio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > <linux-imx@nxp.com> > Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power > supply name > > On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote: > > According to datasheet, the isl29018 has "vddd/vdda" power supply, and > > isl29023/isl29035 ONLY has "vdd" power supply, update the power supply > > name with "vdd" and "vdda" according to datasheet to cover all devices > > and avoid confusion. > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > --- > > Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt > > b/Documentation/devicetree/bindings/iio/light/isl29018.txt > > index b9bbde3..36f737d 100644 > > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt > > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt > > @@ -15,7 +15,9 @@ Optional properties: > > Refer to interrupt-controller/interrupts.txt for generic interrupt client > > node bindings. > > > > - - vcc-supply: phandle to the regulator that provides power to the sensor. > > + - vdd-supply: phandle to the regulator that provides vdd power to the > sensor. > > + > > + - vdda-supply: phandle to the regulator that provides vdda power to the > sensor. > > Is this in use? You can't just change things if it is. I did NOT see any "vcc" in folder drivers/iio/light/, so I think it is NOT used at all, so I take this chance to update it according to datasheet. Thanks. Anson > > Rob
On Mon, Dec 10, 2018 at 7:40 PM Anson Huang <anson.huang@nxp.com> wrote: > > Hi, Rob > > Best Regards! > Anson Huang > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: 2018年12月11日 7:24 > > To: Anson Huang <anson.huang@nxp.com> > > Cc: jic23@kernel.org; knaack.h@gmx.de; lars@metafoo.de; > > pmeerw@pmeerw.net; mark.rutland@arm.com; linux-iio@vger.kernel.org; > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx > > <linux-imx@nxp.com> > > Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power > > supply name > > > > On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote: > > > According to datasheet, the isl29018 has "vddd/vdda" power supply, and > > > isl29023/isl29035 ONLY has "vdd" power supply, update the power supply > > > name with "vdd" and "vdda" according to datasheet to cover all devices > > > and avoid confusion. > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > --- > > > Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > b/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > index b9bbde3..36f737d 100644 > > > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > @@ -15,7 +15,9 @@ Optional properties: > > > Refer to interrupt-controller/interrupts.txt for generic interrupt client > > > node bindings. > > > > > > - - vcc-supply: phandle to the regulator that provides power to the sensor. > > > + - vdd-supply: phandle to the regulator that provides vdd power to the > > sensor. > > > + > > > + - vdda-supply: phandle to the regulator that provides vdda power to the > > sensor. > > > > Is this in use? You can't just change things if it is. > > I did NOT see any "vcc" in folder drivers/iio/light/, so I think it is NOT used at all, > so I take this chance to update it according to datasheet. Thanks. arch/arm/boot/dts/exynos5420-peach-pit.dts-629- light-sensor@44 { arch/arm/boot/dts/exynos5420-peach-pit.dts:630: compatible = "isil,isl29018"; arch/arm/boot/dts/exynos5420-peach-pit.dts-631- reg = <0x44>; arch/arm/boot/dts/exynos5420-peach-pit.dts-632- vcc-supply = <&tps65090_fet5>; arch/arm/boot/dts/exynos5420-peach-pit.dts-633- }; arch/arm/boot/dts/exynos5800-peach-pi.dts-629- light-sensor@44 { arch/arm/boot/dts/exynos5800-peach-pi.dts:630: compatible = "isil,isl29018"; arch/arm/boot/dts/exynos5800-peach-pi.dts-631- reg = <0x44>; arch/arm/boot/dts/exynos5800-peach-pi.dts-632- vcc-supply = <&tps65090_fet5>; arch/arm/boot/dts/exynos5800-peach-pi.dts-633- }; The rest of the dts files using this don't have a supply it seems. So you need permission from the Exynos folks if you want to just drop this. And also update their dts files. Rob
Hi, Fabio Obviously, some of the dts files (such as arch/arm/boot/dts/exynos5420-peach-pit.dts) using "vcc" as isl29018's power supply name, they are NOT matched with datasheet, so should we update those dts files with "vdd" as well or just using the "vcc" in isl29018 driver? Which solution is better? Best Regards! Anson Huang > -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 2018年12月11日 23:19 > To: Anson Huang <anson.huang@nxp.com> > Cc: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack > <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald > <pmeerw@pmeerw.net>; Mark Rutland <mark.rutland@arm.com>; > linux-iio@vger.kernel.org; devicetree@vger.kernel.org; > linux-kernel@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com> > Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: update power > supply name > > On Mon, Dec 10, 2018 at 7:40 PM Anson Huang <anson.huang@nxp.com> > wrote: > > > > Hi, Rob > > > > Best Regards! > > Anson Huang > > > > > -----Original Message----- > > > From: Rob Herring [mailto:robh@kernel.org] > > > Sent: 2018年12月11日 7:24 > > > To: Anson Huang <anson.huang@nxp.com> > > > Cc: jic23@kernel.org; knaack.h@gmx.de; lars@metafoo.de; > > > pmeerw@pmeerw.net; mark.rutland@arm.com; linux-iio@vger.kernel.org; > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; > > > dl-linux-imx <linux-imx@nxp.com> > > > Subject: Re: [PATCH V3 1/2] dt-bindings: iio: light: isl29018: > > > update power supply name > > > > > > On Mon, Dec 10, 2018 at 07:11:19AM +0000, Anson Huang wrote: > > > > According to datasheet, the isl29018 has "vddd/vdda" power supply, > > > > and > > > > isl29023/isl29035 ONLY has "vdd" power supply, update the power > > > > supply name with "vdd" and "vdda" according to datasheet to cover > > > > all devices and avoid confusion. > > > > > > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > > > > --- > > > > Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > > b/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > > index b9bbde3..36f737d 100644 > > > > --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > > +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt > > > > @@ -15,7 +15,9 @@ Optional properties: > > > > Refer to interrupt-controller/interrupts.txt for generic interrupt client > > > > node bindings. > > > > > > > > - - vcc-supply: phandle to the regulator that provides power to the > sensor. > > > > + - vdd-supply: phandle to the regulator that provides vdd power > > > > + to the > > > sensor. > > > > + > > > > + - vdda-supply: phandle to the regulator that provides vdda > > > > + power to the > > > sensor. > > > > > > Is this in use? You can't just change things if it is. > > > > I did NOT see any "vcc" in folder drivers/iio/light/, so I think it is > > NOT used at all, so I take this chance to update it according to datasheet. > Thanks. > > arch/arm/boot/dts/exynos5420-peach-pit.dts-629- light-sensor@44 { > arch/arm/boot/dts/exynos5420-peach-pit.dts:630: compatible = > "isil,isl29018"; > arch/arm/boot/dts/exynos5420-peach-pit.dts-631- reg = <0x44>; > arch/arm/boot/dts/exynos5420-peach-pit.dts-632- vcc-supply = > <&tps65090_fet5>; > arch/arm/boot/dts/exynos5420-peach-pit.dts-633- }; > > arch/arm/boot/dts/exynos5800-peach-pi.dts-629- light-sensor@44 { > arch/arm/boot/dts/exynos5800-peach-pi.dts:630: compatible = > "isil,isl29018"; > arch/arm/boot/dts/exynos5800-peach-pi.dts-631- reg = <0x44>; > arch/arm/boot/dts/exynos5800-peach-pi.dts-632- vcc-supply = > <&tps65090_fet5>; > arch/arm/boot/dts/exynos5800-peach-pi.dts-633- }; > > The rest of the dts files using this don't have a supply it seems. So you need > permission from the Exynos folks if you want to just drop this. And also update > their dts files. > > Rob
Hi Anson, On Wed, Dec 12, 2018 at 4:17 AM Anson Huang <anson.huang@nxp.com> wrote: > > Hi, Fabio > Obviously, some of the dts files (such as arch/arm/boot/dts/exynos5420-peach-pit.dts) using "vcc" as isl29018's power supply name, they are NOT matched with datasheet, so should we update those dts files with "vdd" as well or just using the "vcc" in isl29018 driver? Which solution is better? We should not break existing dtbs, so in this case just keep the existing supply name and you could add the new optional vdda supply as per the datasheet.
Hi, Fabio From Anson's iPhone 6 > > We should not break existing dtbs, so in this case just keep the > existing supply name and you could add the new optional vdda supply as > per the datasheet. Since the datasheet of isl29018 states the vdda and vddd MUST be shorted externally, and the later chips even remove vdda, ONLY has vdd one supply, so I think adding vdda does NOT make enough sense. Looks like the vcc they added is just for prepare, the driver did NOT support regulator operation at that time. So can we just use vcc in driver accordingly? Do we have to use the name “VDD” in datasheet for regulator name? Anson.
Hi Anson,
On Wed, Dec 12, 2018 at 10:49 AM Anson Huang <anson.huang@nxp.com> wrote:
> Since the datasheet of isl29018 states the vdda and vddd MUST be shorted externally, and the later chips even remove vdda, ONLY has vdd one supply, so I think adding vdda does NOT make enough sense. Looks like the vcc they added is just for prepare, the driver did NOT support regulator operation at that time. So can we just use vcc in driver accordingly? Do we have to use the name “VDD” in datasheet for regulator name?
Ok, understood. In this case, I would suggest keeping the existing name.
diff --git a/Documentation/devicetree/bindings/iio/light/isl29018.txt b/Documentation/devicetree/bindings/iio/light/isl29018.txt index b9bbde3..36f737d 100644 --- a/Documentation/devicetree/bindings/iio/light/isl29018.txt +++ b/Documentation/devicetree/bindings/iio/light/isl29018.txt @@ -15,7 +15,9 @@ Optional properties: Refer to interrupt-controller/interrupts.txt for generic interrupt client node bindings. - - vcc-supply: phandle to the regulator that provides power to the sensor. + - vdd-supply: phandle to the regulator that provides vdd power to the sensor. + + - vdda-supply: phandle to the regulator that provides vdda power to the sensor. Example:
According to datasheet, the isl29018 has "vddd/vdda" power supply, and isl29023/isl29035 ONLY has "vdd" power supply, update the power supply name with "vdd" and "vdda" according to datasheet to cover all devices and avoid confusion. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- Documentation/devicetree/bindings/iio/light/isl29018.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)