| Message ID | 20181206134705.18554-3-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2,1/3] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements | expand |
On Thu, Dec 06, 2018 at 02:47:05PM +0100, Hans de Goede wrote: > Add support for PMIC mipi sequences using the new > intel_soc_pmic_exec_mipi_pmic_seq_element function. Please document somewhere which machines you've found to need this (commit msg should be sufficient I suppose). Can make it much easier to respond to bug reports like "my machine X with DSI doesn't work". > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/gpu/drm/i915/intel_dsi_vbt.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c b/drivers/gpu/drm/i915/intel_dsi_vbt.c > index f27af47c6e49..6a2ed1ca72e0 100644 > --- a/drivers/gpu/drm/i915/intel_dsi_vbt.c > +++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c > @@ -29,6 +29,7 @@ > #include <drm/drm_edid.h> > #include <drm/i915_drm.h> > #include <linux/gpio/consumer.h> > +#include <linux/mfd/intel_soc_pmic.h> > #include <linux/slab.h> > #include <video/mipi_display.h> > #include <asm/intel-mid.h> > @@ -371,7 +372,11 @@ static const u8 *mipi_exec_spi(struct intel_dsi *intel_dsi, const u8 *data) > > static const u8 *mipi_exec_pmic(struct intel_dsi *intel_dsi, const u8 *data) > { > +#ifdef CONFIG_PMIC_OPREGION > + intel_soc_pmic_exec_mipi_pmic_seq_element(data); > +#else > DRM_DEBUG_KMS("Skipping PMIC element execution\n"); > +#endif > > return data + 15; > } > -- > 2.19.2
Hi, On 07-12-18 18:17, Ville Syrjälä wrote: > On Thu, Dec 06, 2018 at 02:47:05PM +0100, Hans de Goede wrote: >> Add support for PMIC mipi sequences using the new >> intel_soc_pmic_exec_mipi_pmic_seq_element function. > > Please document somewhere which machines you've found to need > this (commit msg should be sufficient I suppose). Can make it > much easier to respond to bug reports like "my machine X with > DSI doesn't work". Ok, I've added this info to the commit message for v3 of the patch-set. Regards, Hans > >> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> >> --- >> drivers/gpu/drm/i915/intel_dsi_vbt.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c b/drivers/gpu/drm/i915/intel_dsi_vbt.c >> index f27af47c6e49..6a2ed1ca72e0 100644 >> --- a/drivers/gpu/drm/i915/intel_dsi_vbt.c >> +++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c >> @@ -29,6 +29,7 @@ >> #include <drm/drm_edid.h> >> #include <drm/i915_drm.h> >> #include <linux/gpio/consumer.h> >> +#include <linux/mfd/intel_soc_pmic.h> >> #include <linux/slab.h> >> #include <video/mipi_display.h> >> #include <asm/intel-mid.h> >> @@ -371,7 +372,11 @@ static const u8 *mipi_exec_spi(struct intel_dsi *intel_dsi, const u8 *data) >> >> static const u8 *mipi_exec_pmic(struct intel_dsi *intel_dsi, const u8 *data) >> { >> +#ifdef CONFIG_PMIC_OPREGION >> + intel_soc_pmic_exec_mipi_pmic_seq_element(data); >> +#else >> DRM_DEBUG_KMS("Skipping PMIC element execution\n"); >> +#endif >> >> return data + 15; >> } >> -- >> 2.19.2 >
diff --git a/drivers/gpu/drm/i915/intel_dsi_vbt.c b/drivers/gpu/drm/i915/intel_dsi_vbt.c index f27af47c6e49..6a2ed1ca72e0 100644 --- a/drivers/gpu/drm/i915/intel_dsi_vbt.c +++ b/drivers/gpu/drm/i915/intel_dsi_vbt.c @@ -29,6 +29,7 @@ #include <drm/drm_edid.h> #include <drm/i915_drm.h> #include <linux/gpio/consumer.h> +#include <linux/mfd/intel_soc_pmic.h> #include <linux/slab.h> #include <video/mipi_display.h> #include <asm/intel-mid.h> @@ -371,7 +372,11 @@ static const u8 *mipi_exec_spi(struct intel_dsi *intel_dsi, const u8 *data) static const u8 *mipi_exec_pmic(struct intel_dsi *intel_dsi, const u8 *data) { +#ifdef CONFIG_PMIC_OPREGION + intel_soc_pmic_exec_mipi_pmic_seq_element(data); +#else DRM_DEBUG_KMS("Skipping PMIC element execution\n"); +#endif return data + 15; }
Add support for PMIC mipi sequences using the new intel_soc_pmic_exec_mipi_pmic_seq_element function. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/gpu/drm/i915/intel_dsi_vbt.c | 5 +++++ 1 file changed, 5 insertions(+)