diff mbox series

[for-3.1,2/2] i386: hvf: drop debug printf in decode_sldtgroup

Message ID 20181203100415.53027-2-r.bolshakov@yadro.com (mailing list archive)
State New, archived
Headers show
Series [for-3.1,1/2] i386: hvf: Fix overrun of _decode_tbl1 | expand

Commit Message

Roman Bolshakov Dec. 3, 2018, 10:04 a.m. UTC
It's going to clutter QEMU logs if 0x0f00 is trapped.

Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 target/i386/hvf/x86_decode.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Roman Bolshakov Dec. 12, 2018, 9:16 p.m. UTC | #1
On Mon, Dec 03, 2018 at 01:04:15PM +0300, Roman Bolshakov wrote:
> It's going to clutter QEMU logs if 0x0f00 is trapped.
> 
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---
>  target/i386/hvf/x86_decode.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c
> index d125a6ef83..5f513c5563 100644
> --- a/target/i386/hvf/x86_decode.c
> +++ b/target/i386/hvf/x86_decode.c
> @@ -525,8 +525,6 @@ static void decode_sldtgroup(CPUX86State *env, struct x86_decode *decode)
>          X86_DECODE_CMD_INVL
>      };
>      decode->cmd = group[decode->modrm.reg];
> -    printf("%llx: decode_sldtgroup: %d\n", env->hvf_emul->fetch_rip,
> -            decode->modrm.reg);
>  }
>  
>  static void decode_lidtgroup(CPUX86State *env, struct x86_decode *decode)
> -- 
> 2.17.2 (Apple Git-113)
> 

Could you please apply to trivial queue?

Thank you,
Roman
Laurent Vivier Dec. 13, 2018, 8:32 a.m. UTC | #2
On 12/12/2018 22:16, Roman Bolshakov wrote:
> On Mon, Dec 03, 2018 at 01:04:15PM +0300, Roman Bolshakov wrote:
>> It's going to clutter QEMU logs if 0x0f00 is trapped.
>>
>> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
>> ---
>>  target/i386/hvf/x86_decode.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c
>> index d125a6ef83..5f513c5563 100644
>> --- a/target/i386/hvf/x86_decode.c
>> +++ b/target/i386/hvf/x86_decode.c
>> @@ -525,8 +525,6 @@ static void decode_sldtgroup(CPUX86State *env, struct x86_decode *decode)
>>          X86_DECODE_CMD_INVL
>>      };
>>      decode->cmd = group[decode->modrm.reg];
>> -    printf("%llx: decode_sldtgroup: %d\n", env->hvf_emul->fetch_rip,
>> -            decode->modrm.reg);
>>  }
>>  
>>  static void decode_lidtgroup(CPUX86State *env, struct x86_decode *decode)
>> -- 
>> 2.17.2 (Apple Git-113)
>>
> 
> Could you please apply to trivial queue
Applied to my trivial-patches branch.

Thanks,
Laurent
diff mbox series

Patch

diff --git a/target/i386/hvf/x86_decode.c b/target/i386/hvf/x86_decode.c
index d125a6ef83..5f513c5563 100644
--- a/target/i386/hvf/x86_decode.c
+++ b/target/i386/hvf/x86_decode.c
@@ -525,8 +525,6 @@  static void decode_sldtgroup(CPUX86State *env, struct x86_decode *decode)
         X86_DECODE_CMD_INVL
     };
     decode->cmd = group[decode->modrm.reg];
-    printf("%llx: decode_sldtgroup: %d\n", env->hvf_emul->fetch_rip,
-            decode->modrm.reg);
 }
 
 static void decode_lidtgroup(CPUX86State *env, struct x86_decode *decode)