[v2,0/5] Add CPU clock support for Armada 7K/8K

Message

Gregory CLEMENT Dec. 6, 2018, 5:15 p.m. UTC

Hello,

This is the second version of a series allowing to manage the cpu
clock for Armada 7K/8K. For these SoCs, the CPUs share the same clock
by cluster, so actually the clock management is done at cluster level.

As for the other Armada 7K/8K clocks it is possible to have multiple
AP so here again we need to have unique name: the purpose of the second
patch is to share a common code which will be used in 3 drivers.

The last 2 patch enable the driver at dt and platform level and will
be applied through the mvebu subsystem.

Changelog v1->v2:
 - Header cleanup
 - Use unsigned int instead of it for cluster member of the ap_cpu_clk struct
 - Use clk_hw instead of clk
 - Use regmap_read_poll_timeout
 - Use for_each_of_cpu_node
 - Remove unnecessary WARN_ON()
 - Remove headers from armada_ap_cp_helper.h
 - Few other minor cleanup

Gregory CLEMENT (5):
  clk: mvebu: add helper file for Armada AP and CP clocks
  clk: mvebu: add CPU clock driver for Armada 7K/8K
  clk: mvebu: ap806: Fix clock name for the cluster
  arm64: marvell: enable the  Armada 7K/8K CPU clk driver
  arm64: dts: marvell: Add cpu clock node on Armada 7K/8K

 arch/arm64/Kconfig.platforms                  |   1 +
 .../boot/dts/marvell/armada-ap806-quad.dtsi   |   4 +
 arch/arm64/boot/dts/marvell/armada-ap806.dtsi |   6 +
 drivers/clk/mvebu/Kconfig                     |   8 +
 drivers/clk/mvebu/Makefile                    |   2 +
 drivers/clk/mvebu/ap-cpu-clk.c                | 259 ++++++++++++++++++
 drivers/clk/mvebu/ap806-system-controller.c   |  24 +-
 drivers/clk/mvebu/armada_ap_cp_helper.c       |  30 ++
 drivers/clk/mvebu/armada_ap_cp_helper.h       |  11 +
 drivers/clk/mvebu/cp110-system-controller.c   |  32 +--
 10 files changed, 335 insertions(+), 42 deletions(-)
 create mode 100644 drivers/clk/mvebu/ap-cpu-clk.c
 create mode 100644 drivers/clk/mvebu/armada_ap_cp_helper.c
 create mode 100644 drivers/clk/mvebu/armada_ap_cp_helper.h

Comments

Stephen Boyd Dec. 14, 2018, 10:09 p.m. UTC | #1

Quoting Gregory CLEMENT (2018-12-06 09:15:11)
> Hello,
> 
> This is the second version of a series allowing to manage the cpu
> clock for Armada 7K/8K. For these SoCs, the CPUs share the same clock
> by cluster, so actually the clock management is done at cluster level.
> 
> As for the other Armada 7K/8K clocks it is possible to have multiple
> AP so here again we need to have unique name: the purpose of the second
> patch is to share a common code which will be used in 3 drivers.
> 
> The last 2 patch enable the driver at dt and platform level and will
> be applied through the mvebu subsystem.
 
The binding "marvell,ap806-cpu-clock" is not documented. It was in the
previous series but then got dropped from this one? Why?

Gregory CLEMENT Dec. 16, 2018, 9:36 a.m. UTC | #2

Hi Stephen,
 
 On ven., déc. 14 2018, Stephen Boyd <[e-mail]> wrote:

> Quoting Gregory CLEMENT (2018-12-06 09:15:11)
>> Hello,
>> 
>> This is the second version of a series allowing to manage the cpu
>> clock for Armada 7K/8K. For these SoCs, the CPUs share the same clock
>> by cluster, so actually the clock management is done at cluster level.
>> 
>> As for the other Armada 7K/8K clocks it is possible to have multiple
>> AP so here again we need to have unique name: the purpose of the second
>> patch is to share a common code which will be used in 3 drivers.
>> 
>> The last 2 patch enable the driver at dt and platform level and will
>> be applied through the mvebu subsystem.
>  
> The binding "marvell,ap806-cpu-clock" is not documented. It was in the
> previous series but then got dropped from this one? Why?

I made a mistake and start my git-format on the wrong commit, I am
sending a new series right now with this missing patch.

Gregory

>