| Message ID | 1544544804-4039-2-git-send-email-bperumal@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ath10k: Add support to configure BB timing for external FEM | expand |
On Tue, 11 Dec 2018 21:43:22 +0530, Bhagavathi Perumal S wrote: > In qcom,ath10k documentation, ath10k is used as node name in the example of > pci based device. Normally, node name should be class of device and not the > model name, so fix it to node name "wifi". And remove the property device_type > pci since only pci bridges should have this property. > > Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org> > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Bhagavathi Perumal S <bperumal@codeaurora.org> wrote: > In qcom,ath10k documentation, ath10k is used as node name in the example of > pci based device. Normally, node name should be class of device and not the > model name, so fix it to node name "wifi". And remove the property device_type > pci since only pci bridges should have this property. > > Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> 3 patches applied to ath-next branch of ath.git, thanks. e5404969a335 dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example f3f587995c5a dt-bindings: net: ath10k: add new dt entry to identify external FEM 84758d4d43e9 ath10k: add support to configure BB timing over wmi
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index 2196d1a..ef60f25 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -74,9 +74,8 @@ pci { #address-cells = <3>; device_type = "pci"; - ath10k@0,0 { + wifi@0,0 { reg = <0 0 0 0 0>; - device_type = "pci"; qcom,ath10k-calibration-data = [ 01 02 03 ... ]; }; };
In qcom,ath10k documentation, ath10k is used as node name in the example of pci based device. Normally, node name should be class of device and not the model name, so fix it to node name "wifi". And remove the property device_type pci since only pci bridges should have this property. Signed-off-by: Bhagavathi Perumal S <bperumal@codeaurora.org> --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)